From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D698A04DD; Mon, 16 Nov 2020 00:06:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 85B72493D; Mon, 16 Nov 2020 00:06:41 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id BE99D37B4 for ; Mon, 16 Nov 2020 00:06:38 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 25C6B788; Sun, 15 Nov 2020 18:06:37 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 15 Nov 2020 18:06:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= vAz1Hjp/yDjijogOkj1OoqW4Ql0RwI83N/7CPAIlT94=; b=pwsSgu7wcDkGhcL2 6T76QDNC2Bgld0/4W2qcqzh8/NF213BSiquRZlgkpmqomrd8GPDq8sVgeddS4h7x JXgUCFB77ACp0tyUkkYr+PES6OyEfX0QUz9IYG15jhYtz/wwlol0Hj2qkkXQV6k/ S5lfaPLicxeUDuu9KWMXcylBAyzXBBtr00AafcSgd60i+XzWaATpeKt7TtyM/+LC LCsVbodt1deIga9hwzs3PbWrIqK7sZQPsYQrve7dwF4iqqHFYC1W3uBsy9oUWpSV 9iwSSFCAKCxlnRK+BUf/APAK+a2GM/3RQUYJJ9KcFT8f1MF9xMIOY2oRRUQH+1xP 7HaJTg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=vAz1Hjp/yDjijogOkj1OoqW4Ql0RwI83N/7CPAIlT 94=; b=A9VSiy57r6HwBW1yukf/A0tzM9oU7402TUw7ojgLTnlV8kRUtEeaiYcZK PmtOxpyzk12OYu/Xws4/vWVUmySsDfAdLt3JpmrcAHbJKZEHXp7V1HxbuQsX+73a ZHCObk1HRxXpAtg0Ez1szuJTn6ISxAOq+9jAcX5J41xIyw7yqV8HeOStvyX1u+w2 JK5KkRtzgL0EB8LNLv+pEhMPSFoK7oXjw8BOhFy9o0Wc3ipcu4cgMMTyoLqbwpBb PBS+gLbChw0cD2Sno2bYi/PCTNQGh918X8Gngg3z6uPGkSPPD+h6ZMr0//yR4+jA OZ7lJcCUFoURqHGhoYGd8tIZlC5cg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeftddgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0389B328005D; Sun, 15 Nov 2020 18:06:34 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: kevin.laatz@intel.com, dev@dpdk.org, Bruce Richardson , ciara.power@intel.com, david.marchand@redhat.com, robin.jarry@6wind.com Date: Mon, 16 Nov 2020 00:06:32 +0100 Message-ID: <9901465.vu9iHR7z8J@thomas> In-Reply-To: <20201104070043.27879-1-stephen@networkplumber.org> References: <20200906013133.26360-11-stephen@networkplumber.org> <20201104070043.27879-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] dpdk-telemetry-client: fix some pylint warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/11/2020 08:00, Stephen Hemminger: > Convert comments to docstrings as appropriate. Why inserting some spaces inside the docstrings? > Remove unnecessary paren in if statement. > Remove extra whitespace after print. > Remove extra semicolon; this is not C. > > Signed-off-by: Stephen Hemminger > Acked-by: Bruce Richardson Some issues are remaining: pycodestyle usertools/dpdk-telemetry-client.py usertools/dpdk-telemetry-client.py:12:80: E501 line too long (82 > 79 characters) usertools/dpdk-telemetry-client.py:14:80: E501 line too long (80 > 79 characters) usertools/dpdk-telemetry-client.py:15:80: E501 line too long (86 > 79 characters) usertools/dpdk-telemetry-client.py:18:1: E302 expected 2 blank lines, found 1 usertools/dpdk-telemetry-client.py:30:9: E722 do not use bare 'except' usertools/dpdk-telemetry-client.py:33:1: E302 expected 2 blank lines, found 1 usertools/dpdk-telemetry-client.py:46:9: E722 do not use bare 'except' usertools/dpdk-telemetry-client.py:50:80: E501 line too long (80 > 79 characters) usertools/dpdk-telemetry-client.py:71:80: E501 line too long (82 > 79 characters) usertools/dpdk-telemetry-client.py:82:80: E501 line too long (95 > 79 characters) usertools/dpdk-telemetry-client.py:84:24: E261 at least two spaces before inline comment usertools/dpdk-telemetry-client.py:84:25: E262 inline comment should start with '# ' usertools/dpdk-telemetry-client.py:107:32: E261 at least two spaces before inline comment usertools/dpdk-telemetry-client.py:107:33: E262 inline comment should start with '# ' usertools/dpdk-telemetry-client.py:107:80: E501 line too long (80 > 79 characters) usertools/dpdk-telemetry-client.py:120:13: E722 do not use bare 'except' usertools/dpdk-telemetry-client.py:123:1: E305 expected 2 blank lines after class or function definition, found 1