From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 261A441C4F; Thu, 9 Feb 2023 13:14:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E5344067B; Thu, 9 Feb 2023 13:14:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 462FD400D5 for ; Thu, 9 Feb 2023 13:14:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675944839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kmZ9wlGFGbTGb93eNcL3WWhb81mFaGIu+Pkv5F66sj0=; b=ECJGHrWMqDpHbg6iFaRM3oLo97i4AX3NaRuVQTmODfzAn5I6jAzfBmIK5PvbP+jGcsxQ/W h4lGjKcAISkzGJgyFcILKeTrkxkYNGPHJOEuPSbezxJGCRTBhstKasoICDYptTqBSc57X7 Z10WhDrGm/v+lUUcfGM9TO1yT7FyS2s= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-185-vpcIem49PCqg17aHc-AuUw-1; Thu, 09 Feb 2023 07:13:56 -0500 X-MC-Unique: vpcIem49PCqg17aHc-AuUw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6B3821875044; Thu, 9 Feb 2023 12:13:56 +0000 (UTC) Received: from [10.39.208.26] (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 61A7144037; Thu, 9 Feb 2023 12:13:55 +0000 (UTC) Message-ID: <9906a3d7-143f-48c7-d604-4ae2dc360ba6@redhat.com> Date: Thu, 9 Feb 2023 13:13:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2] vhost: decrease log level for unimplemented requests To: dev@dpdk.org, chenbo.xia@intel.com, ktraynor@redhat.com, david.marchand@redhat.com Cc: stable@dpdk.org References: <20230206150733.108910-1-maxime.coquelin@redhat.com> From: Maxime Coquelin In-Reply-To: <20230206150733.108910-1-maxime.coquelin@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/6/23 16:07, Maxime Coquelin wrote: > This patch changes VHOST_USER_SET_VRING_ERR and > VHOST_USER_SET_LOG_FD "not implemented" log levels from > INFO to DEBUG, as implementing these requests is not > mandatory. Having them being displayed at INFO level > may induce some confusion to the end-user. > > Fixes: fd29c33b651a ("vhost: handle unsupported message types in functions") > Cc: stable@dpdk.org > > Signed-off-by: Maxime Coquelin > --- > lib/vhost/vhost_user.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c > index 8f33d5f4d9..551908df8e 100644 > --- a/lib/vhost/vhost_user.c > +++ b/lib/vhost/vhost_user.c > @@ -1818,7 +1818,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev, > > if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK)) > close(ctx->fds[0]); > - VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n"); > + VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n"); > > return RTE_VHOST_MSG_RESULT_OK; > } > @@ -2336,7 +2336,7 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev, > return RTE_VHOST_MSG_RESULT_ERR; > > close(ctx->fds[0]); > - VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented.\n"); > + VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented.\n"); > > return RTE_VHOST_MSG_RESULT_OK; > } Applied to dpdk-next-virtio/main. Thanks, Maxime