DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Haifei Luo <haifeil@nvidia.com>,
	matan@nvidia.com, orika@nvidia.com, viacheslavo@nvidia.com,
	Xiaoyun Li <xiaoyun.li@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com
Subject: Re: [dpdk-dev] [PATCH v4] app/testpmd: add CLI for action meter color
Date: Wed, 12 May 2021 12:40:50 +0100	[thread overview]
Message-ID: <99136e0b-63ec-928c-59c7-520c004d5316@intel.com> (raw)
In-Reply-To: <20210512104933.27999-1-haifeil@nvidia.com>

On 5/12/2021 11:49 AM, Haifei Luo wrote:
> Currently action RTE_FLOW_ACTION_TYPE_METER_COLOR is defined.
> Add the CLI for this aciton:  color type (types)
> There are three types: green, yellow and red.
> 
> Example for the new policy meter CLIs:
>    add port meter policy 0 1 g_actions color type green / end y_actions
>      color type yellow / end r_actions color type red / end
> 
> In the above command, the action type is RTE_FLOW_ACTION_TYPE_METER_COLOR,
> the meter policy action list: green -> green, yellow -> yellow, red -> red.
> 
> V2: rebase the latest code.
> V3: update the document.
> V4: add sample in the document.
> 
> Signed-off-by: Haifei Luo <haifeil@nvidia.com>
> Acked-by: Ori Kam <orika@nvidia.com>
testpmd_funcs.rst:5033: WARNING: Block quote ends without a blank line;
unexpected unindent.

<...>

> @@ -5010,6 +5014,25 @@ rules like above for the peer port.
>  
>   testpmd> flow indirect_action 0 update 0 action conntrack_update dir / end
>  
> +Sample meter with policy rules
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +Meter with policy rules can be created by the following commands:
> +
> +Need to create policy first and actions are set for green/yellow/red colors.
> +Create meter with policy id. Create flow with meter id.
> +
> +Example for policy with meter color action.The purpose is to color the packet
> +to reflect the meter color result.The meter policy action list:

Space is missing between sentences.

> +green -> green, yellow -> yellow, red -> red.
> +
> +::
> +testpmd> add port meter profile srtcm_rfc2697 0 13 21504 2688 0 0
> +testpmd> add port meter policy 0 1 g_actions color type green / end y_actions color type yellow / end
> +         r_actions color type red / end
> +testpmd> create port meter 0 1 13 1 yes 0xffff 0 0
> +testpmd> flow create 0 priority 0 ingress group 1 pattern eth / end actions meter mtr_id 1 / end
> +

Gives build warning:
testpmd_funcs.rst:5032: WARNING: Unexpected indentation.
testpmd_funcs.rst:5033: WARNING: Block quote ends without a blank line;
unexpected unindent.

Will fix above issues while merging.

  reply	other threads:[~2021-05-12 11:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28 14:10 [dpdk-dev] [PATCH] app/testpmd: support meter color action in policy Haifei Luo
2021-04-30 12:50 ` Ferruh Yigit
2021-05-03 12:11   ` Dumitrescu, Cristian
2021-05-05 15:42     ` Ori Kam
2021-05-11  9:28 ` [dpdk-dev] [PATCH v2] app/testpmd: add CLI for action meter color Haifei Luo
2021-05-11 11:35   ` Ferruh Yigit
2021-05-11 12:34     ` Dumitrescu, Cristian
2021-05-11 13:20       ` Ferruh Yigit
2021-05-12 19:54         ` Dumitrescu, Cristian
2021-05-11 19:22   ` Ferruh Yigit
2021-05-12  1:41     ` Haifei Luo
2021-05-12  7:03       ` Haifei Luo
2021-05-12  7:02 ` [dpdk-dev] [PATCH v3] " Haifei Luo
2021-05-12  8:33   ` Ferruh Yigit
2021-05-12 10:49 ` [dpdk-dev] [PATCH v4] " Haifei Luo
2021-05-12 11:40   ` Ferruh Yigit [this message]
2021-05-12 12:08   ` Ferruh Yigit
2021-05-12 12:19 ` [dpdk-dev] [PATCH v5] " Haifei Luo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99136e0b-63ec-928c-59c7-520c004d5316@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=haifeil@nvidia.com \
    --cc=matan@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@nvidia.com \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).