From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE2BD455D4; Wed, 10 Jul 2024 16:58:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8432E41101; Wed, 10 Jul 2024 16:58:24 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2069.outbound.protection.outlook.com [40.107.100.69]) by mails.dpdk.org (Postfix) with ESMTP id 606CB40FDE for ; Wed, 10 Jul 2024 16:58:23 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OYSgllKsf3hZWS49D4zNE5yR9sTY+1/YX8x1U0Ar5szibhTD+JAS1ATZI+qDtAtk5go43fbp+dauwLcKL6gD1rpElOyWWrzfcxzfslkGZWP0EcAcga7yJ1o+iGDYOUK6UhzhTliv1gWTIpNj8Hb3bzI9OatMY2abe6ftXdXSvmt9ruYM8ApOgRJvlLvK7EVJhOhiJxi5Dtmc8+MXGc8Ah6NjHb9xUfXJPoeH7QoXFN+LMzfKbTPC+2bYQcP6s9mlsXm0Yho5gUOyzOaUz0rQq4wxl4dsymr/ai9C54bpiEYBHB5NmQGHeA7bbJLdBW6g4e3B45PxEsBCREuoeuHt9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p1Xno04jPRl3MOwnr4GhZc+kTU8Y5E+bZ8i7RD5WILY=; b=Bw5mvGm2eNo5JLJPu/c8yiJgtpIhWTg//rUWH1BLhkhMk8zy/WiT/2J8xzMDzxFrQ/G2Dp9rHzLq8HaKNbI9Bg0y1jlOIhi3FsrrJPAA5HD+qTcKf2c38s/VFHP1PfGoJgn+tbI6/4oo+5LRIR+0X160ZWdTFVDVptA38W2+kWKnQfNdJJZ6K+nCm3q2zdEhWLMybJWt8GfxP6DT4O//jhwMH6FOMWpoiJGMBUUpAvFLrBnIHgO+vpML1FMxanpHFgRb9pJTapkqMoH0NkagAKtT0CV2UykF3/FtGkquKYXcCrHiCpTVRuoUNLmfRYg0o7Ybqqe86gNvpEQFB93xYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p1Xno04jPRl3MOwnr4GhZc+kTU8Y5E+bZ8i7RD5WILY=; b=cW1VlaDhUcc7w/lyiKCqCy6m/MrPX+yAeFNIoMmao2EeCaMa5VnFWC2OaVPeZt1hOSXdnUwmG5QH/pS6k8AWsqCH34Cfi8Ii/X+irkwBwAlzgxDgMUpEA7lPISjWDVEDv+n+Os9toiFeABvwMXKiThPPPbQTsspHthdCVlfnfmI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH8PR12MB7351.namprd12.prod.outlook.com (2603:10b6:510:215::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.34; Wed, 10 Jul 2024 14:58:19 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7762.016; Wed, 10 Jul 2024 14:58:19 +0000 Message-ID: <991c4549-ea58-42c2-8e72-5b3d1ec06e90@amd.com> Date: Wed, 10 Jul 2024 15:58:14 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 03/23] net/ntnic: add minimal initialization for PCI device To: Serhii Iliushyk , "dev@dpdk.org" Cc: Mykola Kostenok , Christian Koue Muf , "andrew.rybchenko@oktetlabs.ru" , Uffe Jakobsen References: <20240530144929.4127931-1-sil-plv@napatech.com> <20240627073918.2039719-1-sil-plv@napatech.com> <20240627073918.2039719-3-sil-plv@napatech.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0150.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c7::10) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH8PR12MB7351:EE_ X-MS-Office365-Filtering-Correlation-Id: 05bb4bc0-0c98-40ba-3da9-08dca0f0bc74 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?U3B4SlI3YWJyZzkwNk1lVW5ZRDRYcWdKZldORzkzVTUzV2krbWNMeVJqa2lO?= =?utf-8?B?WWI0MDlJaUZhRTVtcXNCUDRMQjl2ZmErS05ENENocHlRYnJTbC9maXBwRVBx?= =?utf-8?B?V3p4cVFMT3RiVmZkTUt5a2lUSGVveWtIUVlneGU5TnBFRmpGakFCa05lUTNO?= =?utf-8?B?Y0FGaWFzQ25HZTQ5SWtwZTB2WHAxUWNYYkJtYXVLMFo1R2JlUVZPMHo5eTly?= =?utf-8?B?NDdRLzlKYm5aVzRray9iOVAxMmhhU2ltbTR1dktheGpSMjZWR1phZWx6SFVP?= =?utf-8?B?UW1semRoc1BtTjlvRlREZlF0eXFSMkZGYldZVzFjMUlaMGc2dGhxVFp2b0xL?= =?utf-8?B?bUFybll1WjRmUk5YREVsS3FRM0JDQkFlL2wrNG5DeVgrQU0wOGVPUlhTUW1C?= =?utf-8?B?clVsazFpbTF0ZkVDcVZ4Y3A5UTY2UWlMZkx1ME1UbkdmcGVEZ3dTZDFKOGFI?= =?utf-8?B?ZFhhSVFSU1RPMUVyOW8vdkpLempsUmk0VDNhZ3pzMStNS0dTN3R1U01CSXRi?= =?utf-8?B?SzNsNGVONTE2ZG02NERQMnlRT2t1bjNUaCt0MXdxSkEyK3VLakllbytYVEY3?= =?utf-8?B?eFdFSWIvZ0F6TnlTYjlOSDlFRnZKOWwwYUdKNjdvTytwTEQ5b0dETmpCVmgw?= =?utf-8?B?TFVtaVpVcDh0UmlNUlpHNDc2VTZJdnBzRE1BNEc0Z293UFFlQzRabHZmemov?= =?utf-8?B?ZDV0SlE3cWlocHhvUHhVTTUzZ213ajI0a2tyYk5zMGtGajdrUytTSWxRUFYw?= =?utf-8?B?cGxQZDVKeHFVeWhkS2xOTjRWMDhZN0FjOWdkUXZsZ2FZem1YUnVzMzd2TVJV?= =?utf-8?B?VXFTLytLTDYzRE9HMXg2RnZOZys0K2JwbkVkLy9BdnFCVGJEbjdLWFpIcXc5?= =?utf-8?B?d2ZVNk5xMmtxQVBwZUtVTkdkaU1ybkJnRlMvNkxDSnBqc1NNNVRlQVAwNjRn?= =?utf-8?B?cGxmSDVHOTlFd25GSE5lV3FKdnZkcnN1NWdsak9hL0cyR1paWmNkSkdlQXoy?= =?utf-8?B?OE84dXVuaW9EQk8xQWJ2MUJNazk3YThOajNOWHZJWUphNDlZY1kvQkRJY0hh?= =?utf-8?B?SHZFbHA4TmxjNExRMFdEcnlJTzA2YzlWc3NmRjBZQ3ppZVBjNXM1bUZPR0xr?= =?utf-8?B?SVdBWU0wOE9ubFg3QzdkTzM4KzBab09QeDJSbTVqYmd2T01GTjM2R1ZTYmtC?= =?utf-8?B?aG5kZm5kV0lFWEFIa2xOZURmeWVBOS9FTWRoYzIwaThabWgzNWNWVXNBTXZF?= =?utf-8?B?SDYwNHhRSEdCbGpEVXdOYVNCTy9nMFJTWk1ZVE9MY1JxUlFRRm5kK0EzSFhU?= =?utf-8?B?K045b1o2VWh6bUQxcGhxN3VYRkwwRURTZEV1SG43dnovelpIQ3pkc0FBU25m?= =?utf-8?B?cnY2Y0hTdUpEY0FSRTlsSVJHZWdKYkZhd2pnUi9WcU1LZ1dkV1Y1THkrZ0pJ?= =?utf-8?B?YUlGcUk1dzJjUHk1djdhU3B4UzNoRzEzNGE0eU5mSDdnVVhaOUVDbWRYK3Qz?= =?utf-8?B?RExvaFlNaEM5RWFVNDF0OGJGdmZLamxBRnR5RGFXeTJYUGY0YjRvMENmeGFh?= =?utf-8?B?QURZNFliNzQyblRIaEFVVXZ2NDBUSjZCbjNUZWZjakEwYWdEZE1ETW5QWjky?= =?utf-8?B?cGZIUDBWUGk2MExYdkFsRHFwNmM3bldTanlrTjR6TUNYaTlxSmpRMUsrd0g5?= =?utf-8?B?TnpCcm1tb3g4MVBIaFA5U1VUWmQ1amVtNkVJMFFFZDNlV0EzNDlFZEkxVDlK?= =?utf-8?Q?fiE0jF3ygHM8EE0St0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3pVODNWY1JTVGV4N2dYMStZVW1WbFNVK2RtWTNKWU9IQlF1dUs0UVZmYlhM?= =?utf-8?B?K0JndjBhU3Z5QnR3NW5UMFp4SFZMUFVQd0xtRUw1VmpiengxWHRhMU9QZnp4?= =?utf-8?B?UVhmaVp6UURmQ3dJTm0ybmRzeTl5VXB6ejNUS0F0bkRoRUI1TjhLVmgwVi9U?= =?utf-8?B?NmgySStTa2lXemZTa1BmcVpKU0s0dEpXQXM4UnBlVTc3MnZBMDBDVDUxUkMy?= =?utf-8?B?bHZxOUk5UVYxWnUxay9WQkZrQ0tNcm9EV3R2MUp2UWExQkw3OVFiNWpEeTRi?= =?utf-8?B?blMxVm1CMHNlRUIwQTRRNFEyRXhoVmhMOHpoclY2aWlMRFU4U1d2dnZUSVc3?= =?utf-8?B?K1NuZWVocmxVdFM4aWQ5VU1IdWpTTDFHeEVjUVZOSTdLYksyWngyRUkyZ0xG?= =?utf-8?B?bERtVEJxRm85ZG1yRVBkYXgrNThxaWNXeTBsa0p6OXZiZDJMOWgxNDFwZjNl?= =?utf-8?B?WHZVL3pzV0Q3L2ttL3cwdlNqekZiRDAyQUZHRWM2QWJaWXRKNUkvcjNkb3VW?= =?utf-8?B?aTJ1dGV3RDRkUDh0ZEt0NTcvaVlwbjRzN2FJcDkxaHJQUzJJQVY1djd6VzVS?= =?utf-8?B?L05LMGdHU056WU1CV0h5L1ZJMjRIakw1aGRkbGcxRzhnaUI4UXcxdWNINTl6?= =?utf-8?B?aVZieVNONnVQQ0hEWi9iNWJSaWVHM0luSzBReHQ5cjRqWU9pQ2NSdStPQUM2?= =?utf-8?B?UGgwTWV3L2FkR3FsN09BZXBYYVJvVlpqMDlJKzRHK2d2dUdOczZQeVVnUVQx?= =?utf-8?B?UmdncjRvVlV6UlpScDVTZlllWENzblE0SDlyNmI3MnNuSlV6KytHQTJpL29x?= =?utf-8?B?TXpiT24vTTR6NjlsSTJkLytuZHMyVTMvd1cxMDlSeE45clV5SFhZRk10d3Nm?= =?utf-8?B?UFI3WWdTOFNPNDRqSEhWNm9XRm1NYVEyMGdnS05sM1VoL1hBYW5PWE1YZW00?= =?utf-8?B?TCt4Q1ZGVVhBb3F6ZlZ0ZlhMZTNYd1Q3dWc4QkpuUE5tcnhhZktJVG1XbmJL?= =?utf-8?B?S2JTTFJMTnFiWGl1QVpXT1ViRTVLSi9BcnpabVpqUE1yWlF2cFMyLzRzUUJu?= =?utf-8?B?anY2cDZwN1E5KzBGTkIyeHhQOUNpWGlzSmxqS21YV0R3eGtLWkF6R3pzT21u?= =?utf-8?B?bXNlcHcwNWNJcm12Si9KRkxEWlNPS2I2eTlSV2tjYTJ6N0w2ejBIWFBCZUZB?= =?utf-8?B?UUg4NVZRWGVLQkx5bGdWQjRLTkZySnZmVVJHRmZ1Sld2clRYOGJ2Tk9PL3Jy?= =?utf-8?B?cVdlOTFKY3B1dC80U0ZwUTd1NkozL0NyenIxbDdPVGZjQ3Y3dVRzVDhrZlpB?= =?utf-8?B?bDlJdTE3VlY2T0JCZ25vL0NXU2ZZS2E0Ymx1b1djVFRYcVJzeDQ2cjJKYllK?= =?utf-8?B?WlJ4c2JWOGRkS2VqL1F1WHpRTEF4aTNVYUVKaThJckJubWppdW5DbXpaNHhE?= =?utf-8?B?cm1YZlliS0w5aDNMM1o0UmswQlpPK2t4SHFzUy9oanRwYkhlMXNMVDhPVDlW?= =?utf-8?B?dE16QWtQRlN5REtkNDhqVC9CSjRKVTF0bFJQUW0yK2FFSFJreGdoZGs4akJ5?= =?utf-8?B?bm04R1hOamtwRDFGNzNyWEtpdXd6dXFkRGdxWmZWWndiVDJEVlVhN296cXR4?= =?utf-8?B?dEVVWW8wVW5CRzRDeDY4TExuSHNOOWwyZkpZSFZiU0V3T2JBVXh2OTZZZ1A0?= =?utf-8?B?NFNNb2RHOE1sZ25jcFhnZXJNZkFFbGJyOWJPaHFOREEzYXhPMnFHTGNHdVFC?= =?utf-8?B?QlllS2FwZFlNYzFSdUFBNTg2RlFnZThjeGZYU2dPMmZsemwzSHFucERIK2NE?= =?utf-8?B?ckp6aFp1cm1PdlA1N2hub1hFSGp2dlZCNVpINnJiWXdDNHN6a3ZzVUU1OEgz?= =?utf-8?B?SmNGU3RFTzhzb0RIOTVlSnBqMU11aVhFKzZvS242TXdhdTBEdEE4b1lCV3RP?= =?utf-8?B?NGZDTDhYVlUwYTc1OHlNSk4rRGZMUTZZc2FWSll5NEVLTzEyQTh6R0pEb3RF?= =?utf-8?B?eU1CK3BkV2RVMXNiWWkzaGlzQlZ6blJJRVQ1b2JqWTZGUnhwdFk3TFI1SWxL?= =?utf-8?B?VDdhTkpRVVpuU3krUFQ4ajJYc0RJcGVlRERkMzBIL0MzdTBweXR1c2JYUHhL?= =?utf-8?Q?AD1ZZn8D65SJv280uUPMAJlVO?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05bb4bc0-0c98-40ba-3da9-08dca0f0bc74 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2024 14:58:19.6133 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bgfVz+HwGgNxCXYBkEAc2tF7P2MXFNWhqBZNhHJnJAlPLDO3mV7zccjnTU0yjP6Q X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7351 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/10/2024 3:30 PM, Serhii Iliushyk wrote: > Hi Ferruh, > > Please find our explanation for your comment according to device > initializationby function nthw_pci_dev_init. > > Our NIC handles multiple ports within the same PCI Bus Device Function > (BDF) - hence, we need to create several ETH devices during the probe init. > Allocation of multiple eth devices is handled inside the > nthw_pci_dev_init() function. > It appears to be similar to what the Octeontx driver does. > > We believe the current implementation fits better for our PMD, so we > would like to keep it as is, unless it is a blocking requirement for > upstreaming. > > Please let us know. > Hi Serhii, Please don't top post, it makes very hard to follow a discussion this way, instead prefered way is to response inline just below where your comment is valid. Like below there are bunch of comment, I am not sure which one you are reffering. But from context, I assume you refer to the one that suggests using 'rte_eth_dev_create()', firstly this is not hard requirement but suggestion to help you, so it is up to you. But initialisation is wrapped in that function, so it is helpful to use that function to handle boilerplate code correct. Current logic is: ``` probe() init() get n_phy_ports; foreach i in n_phy_ports // do ethdev allocation & initialization ``` I suggest it can be done as: ``` probe() get n_phy_ports; foreach i in n_phy_ports rte_eth_dev_create(pci_init, init) init() // only ethdev initialization // ethdev alloc and common init already done at this point ``` I may be missing some details, if above doesn't make sense or doesn't help you, feel free to ignore it. But please be sure basic ethdev allocation and initialization is done properly, as far as I remember I had some questions around it, that is why suggested to use the wrapper.   > > *From: *Ferruh Yigit > *Date: *Friday, 5 July 2024 at 01:44 > *To: *Serhii Iliushyk , dev@dpdk.org > *Cc: *Mykola Kostenok , Christian Koue Muf > , andrew.rybchenko@oktetlabs.ru > > *Subject: *Re: [PATCH v5 03/23] net/ntnic: add minimal initialization > for PCI device > > On 6/27/2024 8:38 AM, Serhii Iliushyk wrote: >> add implementation for probe/init and remove/deinit of the PCI device >> >> Signed-off-by: Serhii Iliushyk >> --- >>  drivers/net/ntnic/ntnic_ethdev.c | 104 ++++++++++++++++++++++++++++++- >>  1 file changed, 103 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/ntnic/ntnic_ethdev.c b/drivers/net/ntnic/ntnic_ethdev.c >> index 3079bd98e4..e9a584877f 100644 >> --- a/drivers/net/ntnic/ntnic_ethdev.c >> +++ b/drivers/net/ntnic/ntnic_ethdev.c >> @@ -17,14 +17,63 @@ >>  /* Global static variables: */ >>  >>  static int >> -nthw_pci_dev_init(struct rte_pci_device *pci_dev __rte_unused) >> +nthw_pci_dev_init(struct rte_pci_device *pci_dev) >>  { >> +     uint32_t n_port_mask = -1;      /* All ports enabled by default */ >> +     int n_phy_ports; >> +     NT_LOG_DBGX(DEBUG, NTNIC, "Dev %s PF #%i Init : %02x:%02x:%i\n", pci_dev->name, >> +             pci_dev->addr.function, pci_dev->addr.bus, pci_dev->addr.devid, >> +             pci_dev->addr.function); >> + >> +     n_phy_ports = 0; >> + >> +     for (int n_intf_no = 0; n_intf_no < n_phy_ports; n_intf_no++) { >> +             struct rte_eth_dev *eth_dev = NULL; >> +             char name[32]; >> + >> +             if ((1 << n_intf_no) & ~n_port_mask) >> +                     continue; >> + >> +             snprintf(name, sizeof(name), "ntnic%d", n_intf_no); >> + >> +             eth_dev = rte_eth_dev_allocate(name);   /* TODO: name */ >> > > Is this TODO still valid? > >> + >> +             if (!eth_dev) { >> +                     NT_LOG_DBGX(ERR, NTNIC, "%s: %s: error=%d\n", >> +                             (pci_dev->name[0] ? pci_dev->name : "NA"), name, -1); >> +                     return -1; >> +             } >> + >> +             NT_LOG_DBGX(DEBUG, NTNIC, "eth_dev %p, port_id %u, if_index %u\n", >> +                                     eth_dev, eth_dev->data->port_id, n_intf_no); >> + >> + >> +             struct rte_eth_link pmd_link; >> +             pmd_link.link_speed = RTE_ETH_SPEED_NUM_NONE; >> +             pmd_link.link_duplex = RTE_ETH_LINK_FULL_DUPLEX; >> +             pmd_link.link_status = RTE_ETH_LINK_DOWN; >> +             pmd_link.link_autoneg = RTE_ETH_LINK_AUTONEG; >> + >> +             eth_dev->device = &pci_dev->device; >> +             eth_dev->data->dev_link = pmd_link; >> +             eth_dev->data->numa_node = pci_dev->device.numa_node; >> > > rte_eth_copy_pci_info() should be setting numa_node, no need to > duplicate here. > > Please consider using 'rte_eth_dev_create()' to help these kind of > boilerplate initialization. I did same comment below. > >> +             eth_dev->dev_ops = NULL; >> +             eth_dev->state = RTE_ETH_DEV_ATTACHED; >> > > Shouldn't need to set state directly, please call > 'rte_eth_dev_probing_finish()' as a last thing in probe(). > This call will set the state, also will do some other required work. > >> + >> +             rte_eth_copy_pci_info(eth_dev, pci_dev); >> +             /* performs rte_eth_copy_pci_info() */ >> +             eth_dev_pci_specific_init(eth_dev, pci_dev); >> > > As comment says, 'eth_dev_pci_specific_init()' calls the > 'rte_eth_copy_pci_info()', so why calling it twice, can clean the init > and remove the comment. > >> + >> +             /* increase initialized ethernet devices - PF */ >> > > Is this comment valid here? > >> +     } >> + >>        return 0; >>  } >>  >>  static int >>  nthw_pci_dev_deinit(struct rte_eth_dev *eth_dev __rte_unused) >>  { >> +     NT_LOG_DBGX(DEBUG, NTNIC, "PCI device deinitialization\n"); >>        return 0; >>  } >>  >> @@ -33,13 +82,65 @@ nthw_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, >>        struct rte_pci_device *pci_dev) >>  { >>        int res; >> + >> +     NT_LOG_DBGX(DEBUG, NTNIC, "pcidev: name: '%s'\n", pci_dev->name); >> +     NT_LOG_DBGX(DEBUG, NTNIC, "devargs: name: '%s'\n", pci_dev->https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fdevice.name&c=E,1,V5OBhPhfiNSro_oj2bitVYkKYAABsPx-MKLgmN0q8g6JbMwgnOO1gKkhj3c3IxCQvEgNbC8ofBuQUVC8VRFgpnK79cZnIRMu2iT6BvGGlWlO-BxzlAK2eTwkKk9z&typo=1); >> + >> +     if (pci_dev->device.devargs) { >> +             NT_LOG_DBGX(DEBUG, NTNIC, "devargs: args: '%s'\n", >> +                     (pci_dev->device.devargs->args ? pci_dev->device.devargs->args : "NULL")); >> +             NT_LOG_DBGX(DEBUG, NTNIC, "devargs: data: '%s'\n", >> +                     (pci_dev->device.devargs->data ? pci_dev->device.devargs->data : "NULL")); >> +     } >> + >> +     const int n_rte_has_pci = rte_eal_has_pci(); >> +     NT_LOG(DBG, NTNIC, "has_pci=%d\n", n_rte_has_pci); >> + >> +     if (n_rte_has_pci == 0) { >> +             NT_LOG(ERR, NTNIC, "has_pci=%d: this PMD needs hugepages\n", n_rte_has_pci); >> > > It is checking PCI bus, but log is about hugepages. > >> +             return -1; >> +     } >> > > What is the intention here for the 'n_rte_has_pci' check? > If pci bus is disabled, this probe call should not be called at all, in > that manner this check is useless. > >> + >> +     const int n_rte_vfio_no_io_mmu_enabled = rte_vfio_noiommu_is_enabled(); >> +     NT_LOG(DBG, NTNIC, "vfio_no_iommu_enabled=%d\n", n_rte_vfio_no_io_mmu_enabled); >> + >> +     if (n_rte_vfio_no_io_mmu_enabled) { >> +             NT_LOG(ERR, NTNIC, "vfio_no_iommu_enabled=%d: this PMD needs VFIO IOMMU\n", >> +                     n_rte_vfio_no_io_mmu_enabled); >> +             return -1; >> +     } >> + >> +     const enum rte_iova_mode n_rte_io_va_mode = rte_eal_iova_mode(); >> +     NT_LOG(DBG, NTNIC, "iova mode=%d\n", n_rte_io_va_mode); >> + >> +     if (n_rte_io_va_mode != RTE_IOVA_PA) { >> +             NT_LOG(WRN, NTNIC, "iova mode (%d) should be PA for performance reasons\n", >> +                     n_rte_io_va_mode); >> +     } >> > > Is this comment valid? > Won't iommu be used for address translation both IOVA_VA and IOVA_PA > mode? How much performance improvement we are talking about? > >> + >> +     NT_LOG(DBG, NTNIC, >> +             "busid=" PCI_PRI_FMT >> +             " pciid=%04x:%04x_%04x:%04x locstr=%s @ numanode=%d: drv=%s drvalias=%s\n", >> +             pci_dev->addr.domain, pci_dev->addr.bus, pci_dev->addr.devid, >> +             pci_dev->addr.function, pci_dev->id.vendor_id, pci_dev->id.device_id, >> +             pci_dev->id.subsystem_vendor_id, pci_dev->id.subsystem_device_id, >> +             pci_dev->name[0] ? pci_dev->name : "NA",        /* locstr */ >> +             pci_dev->device.numa_node, >> +             pci_dev->driver->https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fdriver.name&c=E,1,5_F-hniqJt0w3GPG-nclekQA5nc17FmonNihbX6JRyTd2j6RA7sGlIJ9gBTq_T3p01-6DsO244rVP-3PFWsjaqFJ44V77omLRmCrWio_VmtBudxV30mhcou9&typo=1 ? pci_dev->driver->https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fdriver.name&c=E,1,frkLGUymGHY5ydpNKtk3f74kNLD7KupomSqM7BLD7aOyg83VIXzNCZfCJI9PDNuIjnexaqLnATwKsfczOq1DvmsNBhMbEgTT0QrJ7RKHxIw,&typo=1 : "NA", >> +             pci_dev->driver->driver.alias ? pci_dev->driver->driver.alias : "NA"); >> + >> + >>        res = nthw_pci_dev_init(pci_dev); >> > > Instead of calling 'nthw_pci_dev_init()' directly, you can use > 'rte_eth_dev_create()' and pass 'nthw_pci_dev_init()' as paramter, this > helps on some set of boilerplate code. > >> + >> +     NT_LOG_DBGX(DEBUG, NTNIC, "leave: res=%d\n", res); >>        return res; >> > > Doesn't really matter but mostly 'ret' is used as short version of > "return value", what 'res' is? > > >>  } >>  >>  static int >>  nthw_pci_remove(struct rte_pci_device *pci_dev) >>  { >> +     NT_LOG_DBGX(DEBUG, NTNIC); >> + >>        return rte_eth_dev_pci_generic_remove(pci_dev, nthw_pci_dev_deinit); >>  } >>  >> @@ -48,6 +149,7 @@ static struct rte_pci_driver rte_nthw_pmd = { >>                .name = "net_ntnic", >>        }, >>  >> +     .drv_flags = RTE_PCI_DRV_NEED_MAPPING, >>        .probe = nthw_pci_probe, >>        .remove = nthw_pci_remove, >>  }; >