From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
 [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 955771B64C
 for <dev@dpdk.org>; Tue,  3 Apr 2018 12:16:33 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id F27C720C5C;
 Tue,  3 Apr 2018 06:16:31 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Tue, 03 Apr 2018 06:16:31 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=ZDp3CMoE14jhyXEci6kQoE1LDe
 GNgZFCBkFd0Lob9XA=; b=Q1VTw8inGd1VWDeHk+4NEhSs20VV7ZXAGHTHM+Xovf
 yZ3vBJv3JBFmASXJbL6s+KdlCkvIfAtf3ORhRjYbaZahqLIrKgyt83+QRGJCFCty
 qhwlpbqVs3ON3LdPVtiF/uxLN9CCyza5YvTpXa7dD2NyoQKI7xhqedTX3WMJ0RsD
 k=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=ZDp3CM
 oE14jhyXEci6kQoE1LDeGNgZFCBkFd0Lob9XA=; b=VkSH662qK9oj838L+NUfGn
 8Sgo9KbGfXVJCVQIJJj03BFZPI2iIw45EFJquY3AgUaVpcaXAvYHPnVyKqiaYGgk
 Y/Pmnk14lFGPXNyXzejOUu+EB8/Kf5S/pDqC92482+hZGpxS3+ynXQwHvROxH9xL
 3Re+2NkblnXViBe0R07MgW25ccnB/N1W0YNMCT3bnz9XNXNTx8TKzQ61o6+uQGdt
 MgJB2WSQR2cLC1s3G8/Ls2FjCNpgnSUWNBoPpC6SUB2TR5WvagB/3gWpkB9yMqO4
 iVpkrpIB6rp9Ys2Z/yx8Li6AbJdibexk95Z47BRQriGZkHLnqYx5AlVokzdkjFBQ
 ==
X-ME-Sender: <xms:f1TDWqdt8sDm-ulCguoEs0RyaO6OZCRewoys3e3cuTnF0dI3hFJl9g>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 52288E444F;
 Tue,  3 Apr 2018 06:16:31 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com
Date: Tue, 03 Apr 2018 12:16:29 +0200
Message-ID: <9957048.blevZcPhfd@xps>
In-Reply-To: <1522744086-31507-1-git-send-email-hemant.agrawal@nxp.com>
References: <1522658173-13955-1-git-send-email-hemant.agrawal@nxp.com>
 <1522744086-31507-1-git-send-email-hemant.agrawal@nxp.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3 1/2] doc: add vfio api support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Apr 2018 10:16:33 -0000

03/04/2018 10:28, Hemant Agrawal:
> --- a/doc/api/doxy-api-index.md
> +++ b/doc/api/doxy-api-index.md
> @@ -179,4 +179,5 @@ The public API headers are grouped by topics:
>    [EAL config]         (@ref rte_eal.h),
>    [common]             (@ref rte_common.h),
>    [ABI compat]         (@ref rte_compat.h),
> -  [version]            (@ref rte_version.h)
> +  [version]            (@ref rte_version.h),
> +  [vfio]               (@ref rte_vfio.h)

It would be more appropriate after rte_pci.h in "device" section.

> diff --git a/doc/api/doxy-api.conf b/doc/api/doxy-api.conf
> index cda52fd..166612f 100644
> --- a/doc/api/doxy-api.conf
> +++ b/doc/api/doxy-api.conf
> @@ -82,6 +82,7 @@ INPUT                   = doc/api/doxy-api-index.md \
>  FILE_PATTERNS           = rte_*.h \
>                            cmdline.h
>  PREDEFINED              = __DOXYGEN__ \
> +			  VFIO_PRESENT \
>                            __attribute__(x)=

The indent is not the same as other lines.