From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <i.maximets@samsung.com> Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id A7D825B3E for <dev@dpdk.org>; Thu, 11 Apr 2019 10:53:49 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20190411085348euoutp01a32059186a634964cbcd51070b98cef0~UX4yJZlux3078630786euoutp01e for <dev@dpdk.org>; Thu, 11 Apr 2019 08:53:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190411085348euoutp01a32059186a634964cbcd51070b98cef0~UX4yJZlux3078630786euoutp01e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1554972828; bh=2FIhGYerCTbOdd+Fkz5GFmGP8wou2DrCAC1Z+AjC9Hw=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=vCO0fEgdf8wUO5t0aTorJDrhSXaGGrjUX8tzksG/EEDV5+PyKbi3BZStPqByKHJKj Mc7xkecZHGuM7PUFEBfbpwIKuIFKmuxjnUtORoTj5RpUT0A5k7J6J6bUHl70KRpbF6 Rp2jzTVwswdkpPJBxOsa4KcaI+4x27D5RJN9XBCY= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20190411085348eucas1p18469195f51427ea43d8bc23e7f912175~UX4xuomJi2208822088eucas1p1u; Thu, 11 Apr 2019 08:53:48 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 92.2C.04325.B900FAC5; Thu, 11 Apr 2019 09:53:47 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190411085347eucas1p27668b608c5c75727b3b6391d8c19d37e~UX4xAc7SB0473504735eucas1p2S; Thu, 11 Apr 2019 08:53:47 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20190411085347eusmtrp14e5b7f746b46444989265f1c8f42e11e~UX4wyZcQt1939419394eusmtrp1f; Thu, 11 Apr 2019 08:53:47 +0000 (GMT) X-AuditID: cbfec7f5-b75ff700000010e5-7e-5caf009b06a8 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 8D.0D.04146.A900FAC5; Thu, 11 Apr 2019 09:53:46 +0100 (BST) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190411085346eusmtip1e55e4fd416293aa7c74342b69e6988ce~UX4wNzEAv2513225132eusmtip1M; Thu, 11 Apr 2019 08:53:46 +0000 (GMT) To: David Marchand <david.marchand@redhat.com> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>, Tiwei Bie <tiwei.bie@intel.com>, dev <dev@dpdk.org>, Jens Freimann <jfreimann@redhat.com>, Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>, dpdk stable <stable@dpdk.org> From: Ilya Maximets <i.maximets@samsung.com> Message-ID: <995fd379-bed6-f7bc-bff3-40896661dafb@samsung.com> Date: Thu, 11 Apr 2019 11:53:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <CAJFAV8y=nUM9ekiyX8Ldk4j4U_Hz2P=H=qn3o8P4SksmtYn1Gw@mail.gmail.com> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHfXfOtrPRsddp+GCSMLNQTCsLDmF2IcIPfjD6oJi3Yx5UclM2 p6mRYjeVEC8fpFlpljktZ4luFrZyiOYl/aKYkChdtJlaeSNzah6Pkt9+/J/n+T/P/+WlCEWt 2I1KUqdxGjWbrJTISVPn8sChCofGyMNl00eZp29vkYzZUChhZufMImbwzrKU6X9eQzKdBW0k s5ZvlzItueui01Tw36oacfDjNpso+KdlSBJc1FyPQskIeWA8l5yUzmn8g2LliX8+2MnUT+Kr FkubNBe9IQuRjAJ8DGwDK4hnBTYgaB9ME3gBQY05TuB5BDO20O3+sieLG7PyDb0WQeu4SSQ0 /UYw3pLIszMOAftAtZhnF+wHJaamzQECf0bQU/dLwhck2Bd6nnVsbKYoGgeB2ezIyyT2gndf ijeP24PDYazzxaYPjZ2g+97XTV2GL0DTg/cEzwR2hbyFOrHAHmCeuU/wuwCbpDBpayB4f8Dn oK6MFgI4w1RXs1Rgd+gtu7v1EDkwdtOGhNl8BOXWNZFQOAXNP/qlvA+BvaHxtb8gnwGjcU4i 2DvCxxkn4QRHKDWVb22lIf+2QujeDyvttYTAbjAyOy8tRkr9jmD6HWH0O8Lo/++tQmQ9cuV0 WlUCpw1Qcxl+Wlal1akT/C6nqJrQxvfpXetabEUWe5wVYQopd9HMckOkQsymazNVVgQUoXSh PdaNkQo6ns3M4jQpMRpdMqe1or0UqXSlsx3GLylwApvGXeG4VE6zXRVRMrdcZKjsOTmclWEq Os9WlqD2trzoVWP+6sEQ32sVS1FnF2YshhhbqC5ift9w9UUPw6vdD/smqq0L9jAf5/KCeM/+ 0eMFN2Ld/VYCpirDiO/XH9mmJnO/RZd6Iq9A72xzvb1/aehld2mJSnZAPxqlG5nO7mtesXdM cHWsmjaeQOE5SlKbyB7xITRa9h+hG8jVOgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsVy+t/xu7qzGNbHGMy+ZmOxbH8ri8X2FV1s Fu8+bWeyuNL+k93i3JqlLBbHOvewWPzr+MNusbXhP5MDh8evBUtZPRbvecnk8X7fVTaPvi2r GANYovRsivJLS1IVMvKLS2yVog0tjPQMLS30jEws9QyNzWOtjEyV9O1sUlJzMstSi/TtEvQy fpz9w1Jwh7Vi37497A2Me1m6GDk5JARMJCYv+Qpkc3EICSxllDi2fxErREJK4sevC1C2sMSf a11sEEXvGSV+TVzFBJIQFvCR+HMeokFEQE9i4rZNYJOYBZ4wSrx/9gFshZDAJSaJ+zdEQWw2 AR2JU6uPMHYxcnDwCthJbN/OBxJmEVCVOPB4Ali5qECExJn3K8BsXgFBiZMzn4DZnAKBEpvm nmAGsZkF1CX+zLsEZYtLNH1ZyQphy0tsfzuHeQKj0Cwk7bOQtMxC0jILScsCRpZVjCKppcW5 6bnFhnrFibnFpXnpesn5uZsYgXG37djPzTsYL20MPsQowMGoxMM74ffaGCHWxLLiytxDjBIc zEoivPL/18UI8aYkVlalFuXHF5XmpBYfYjQFem4is5Rocj4wJeSVxBuaGppbWBqaG5sbm1ko ifOeN6iMEhJITyxJzU5NLUgtgulj4uCUamCcU3Rk05GL8XO0Plsf7+6q+7DhYtXpTyd+CYRy PRNY8oBlzeQ52rvenexxeJ56gPv9J8MWs5y5OfzxTLN1ctga9TqeSYSVPGQ+dnXyi0DTq7YR osGsfsV/X++fcGiSR1Kbw5vL86zLM080/u5fu/MO+2ZGmQ2LZxXun1zsZ+4vkloocfvsXsWf SizFGYmGWsxFxYkA8YaAANECAAA= X-CMS-MailID: 20190411085347eucas1p27668b608c5c75727b3b6391d8c19d37e X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190409133629eucas1p2ecfe7c4771bb6add694596cf75cf3e70 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190409133629eucas1p2ecfe7c4771bb6add694596cf75cf3e70 References: <CGME20190409133629eucas1p2ecfe7c4771bb6add694596cf75cf3e70@eucas1p2.samsung.com> <20190409133622.14729-1-i.maximets@samsung.com> <CAJFAV8w1cZppsxU_cMQEPK+HGKBGD-EgByJUr+zFmggQRfSBTA@mail.gmail.com> <2419f57d-3283-0fae-745d-002d7ff500e7@samsung.com> <CAJFAV8y=nUM9ekiyX8Ldk4j4U_Hz2P=H=qn3o8P4SksmtYn1Gw@mail.gmail.com> Subject: Re: [dpdk-dev] [PATCH] vhost: fix passing destroyed device to destroy callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 11 Apr 2019 08:53:50 -0000 On 10.04.2019 11:07, David Marchand wrote: > On Wed, Apr 10, 2019 at 9:53 AM Ilya Maximets <i.maximets@samsung.com <mailto:i.maximets@samsung.com>> wrote: > > On 10.04.2019 10:24, David Marchand wrote: > > For vhost maintainers, looking at vhost_user_add_connection, aren't we leaking a vid on errors ? either when new_connection notifier returns an error, or after calling destroy_connection. > > I think that you're right. > I spotted that too yesterday while preparing this patch, just had no time to > check deeper. It should be safe to call 'vhost_destroy_device' in these cases. > > > Yes, that's my understanding too. I'll prepare the patch for this. > > > -- > David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A8B8DA0096 for <public@inbox.dpdk.org>; Thu, 11 Apr 2019 10:53:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 92D415F17; Thu, 11 Apr 2019 10:53:50 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id A7D825B3E for <dev@dpdk.org>; Thu, 11 Apr 2019 10:53:49 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20190411085348euoutp01a32059186a634964cbcd51070b98cef0~UX4yJZlux3078630786euoutp01e for <dev@dpdk.org>; Thu, 11 Apr 2019 08:53:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190411085348euoutp01a32059186a634964cbcd51070b98cef0~UX4yJZlux3078630786euoutp01e DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1554972828; bh=2FIhGYerCTbOdd+Fkz5GFmGP8wou2DrCAC1Z+AjC9Hw=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=vCO0fEgdf8wUO5t0aTorJDrhSXaGGrjUX8tzksG/EEDV5+PyKbi3BZStPqByKHJKj Mc7xkecZHGuM7PUFEBfbpwIKuIFKmuxjnUtORoTj5RpUT0A5k7J6J6bUHl70KRpbF6 Rp2jzTVwswdkpPJBxOsa4KcaI+4x27D5RJN9XBCY= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20190411085348eucas1p18469195f51427ea43d8bc23e7f912175~UX4xuomJi2208822088eucas1p1u; Thu, 11 Apr 2019 08:53:48 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 92.2C.04325.B900FAC5; Thu, 11 Apr 2019 09:53:47 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190411085347eucas1p27668b608c5c75727b3b6391d8c19d37e~UX4xAc7SB0473504735eucas1p2S; Thu, 11 Apr 2019 08:53:47 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20190411085347eusmtrp14e5b7f746b46444989265f1c8f42e11e~UX4wyZcQt1939419394eusmtrp1f; Thu, 11 Apr 2019 08:53:47 +0000 (GMT) X-AuditID: cbfec7f5-b75ff700000010e5-7e-5caf009b06a8 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 8D.0D.04146.A900FAC5; Thu, 11 Apr 2019 09:53:46 +0100 (BST) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190411085346eusmtip1e55e4fd416293aa7c74342b69e6988ce~UX4wNzEAv2513225132eusmtip1M; Thu, 11 Apr 2019 08:53:46 +0000 (GMT) To: David Marchand <david.marchand@redhat.com> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>, Tiwei Bie <tiwei.bie@intel.com>, dev <dev@dpdk.org>, Jens Freimann <jfreimann@redhat.com>, Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>, dpdk stable <stable@dpdk.org> From: Ilya Maximets <i.maximets@samsung.com> Message-ID: <995fd379-bed6-f7bc-bff3-40896661dafb@samsung.com> Date: Thu, 11 Apr 2019 11:53:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <CAJFAV8y=nUM9ekiyX8Ldk4j4U_Hz2P=H=qn3o8P4SksmtYn1Gw@mail.gmail.com> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHfXfOtrPRsddp+GCSMLNQTCsLDmF2IcIPfjD6oJi3Yx5UclM2 p6mRYjeVEC8fpFlpljktZ4luFrZyiOYl/aKYkChdtJlaeSNzah6Pkt9+/J/n+T/P/+WlCEWt 2I1KUqdxGjWbrJTISVPn8sChCofGyMNl00eZp29vkYzZUChhZufMImbwzrKU6X9eQzKdBW0k s5ZvlzItueui01Tw36oacfDjNpso+KdlSBJc1FyPQskIeWA8l5yUzmn8g2LliX8+2MnUT+Kr FkubNBe9IQuRjAJ8DGwDK4hnBTYgaB9ME3gBQY05TuB5BDO20O3+sieLG7PyDb0WQeu4SSQ0 /UYw3pLIszMOAftAtZhnF+wHJaamzQECf0bQU/dLwhck2Bd6nnVsbKYoGgeB2ezIyyT2gndf ijeP24PDYazzxaYPjZ2g+97XTV2GL0DTg/cEzwR2hbyFOrHAHmCeuU/wuwCbpDBpayB4f8Dn oK6MFgI4w1RXs1Rgd+gtu7v1EDkwdtOGhNl8BOXWNZFQOAXNP/qlvA+BvaHxtb8gnwGjcU4i 2DvCxxkn4QRHKDWVb22lIf+2QujeDyvttYTAbjAyOy8tRkr9jmD6HWH0O8Lo/++tQmQ9cuV0 WlUCpw1Qcxl+Wlal1akT/C6nqJrQxvfpXetabEUWe5wVYQopd9HMckOkQsymazNVVgQUoXSh PdaNkQo6ns3M4jQpMRpdMqe1or0UqXSlsx3GLylwApvGXeG4VE6zXRVRMrdcZKjsOTmclWEq Os9WlqD2trzoVWP+6sEQ32sVS1FnF2YshhhbqC5ift9w9UUPw6vdD/smqq0L9jAf5/KCeM/+ 0eMFN2Ld/VYCpirDiO/XH9mmJnO/RZd6Iq9A72xzvb1/aehld2mJSnZAPxqlG5nO7mtesXdM cHWsmjaeQOE5SlKbyB7xITRa9h+hG8jVOgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHIsWRmVeSWpSXmKPExsVy+t/xu7qzGNbHGMy+ZmOxbH8ri8X2FV1s Fu8+bWeyuNL+k93i3JqlLBbHOvewWPzr+MNusbXhP5MDh8evBUtZPRbvecnk8X7fVTaPvi2r GANYovRsivJLS1IVMvKLS2yVog0tjPQMLS30jEws9QyNzWOtjEyV9O1sUlJzMstSi/TtEvQy fpz9w1Jwh7Vi37497A2Me1m6GDk5JARMJCYv+Qpkc3EICSxllDi2fxErREJK4sevC1C2sMSf a11sEEXvGSV+TVzFBJIQFvCR+HMeokFEQE9i4rZNYJOYBZ4wSrx/9gFshZDAJSaJ+zdEQWw2 AR2JU6uPMHYxcnDwCthJbN/OBxJmEVCVOPB4Ali5qECExJn3K8BsXgFBiZMzn4DZnAKBEpvm nmAGsZkF1CX+zLsEZYtLNH1ZyQphy0tsfzuHeQKj0Cwk7bOQtMxC0jILScsCRpZVjCKppcW5 6bnFhnrFibnFpXnpesn5uZsYgXG37djPzTsYL20MPsQowMGoxMM74ffaGCHWxLLiytxDjBIc zEoivPL/18UI8aYkVlalFuXHF5XmpBYfYjQFem4is5Rocj4wJeSVxBuaGppbWBqaG5sbm1ko ifOeN6iMEhJITyxJzU5NLUgtgulj4uCUamCcU3Rk05GL8XO0Plsf7+6q+7DhYtXpTyd+CYRy PRNY8oBlzeQ52rvenexxeJ56gPv9J8MWs5y5OfzxTLN1ctga9TqeSYSVPGQ+dnXyi0DTq7YR osGsfsV/X++fcGiSR1Kbw5vL86zLM080/u5fu/MO+2ZGmQ2LZxXun1zsZ+4vkloocfvsXsWf SizFGYmGWsxFxYkA8YaAANECAAA= X-CMS-MailID: 20190411085347eucas1p27668b608c5c75727b3b6391d8c19d37e X-Msg-Generator: CA Content-Type: text/plain; charset="UTF-8" X-RootMTR: 20190409133629eucas1p2ecfe7c4771bb6add694596cf75cf3e70 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190409133629eucas1p2ecfe7c4771bb6add694596cf75cf3e70 References: <CGME20190409133629eucas1p2ecfe7c4771bb6add694596cf75cf3e70@eucas1p2.samsung.com> <20190409133622.14729-1-i.maximets@samsung.com> <CAJFAV8w1cZppsxU_cMQEPK+HGKBGD-EgByJUr+zFmggQRfSBTA@mail.gmail.com> <2419f57d-3283-0fae-745d-002d7ff500e7@samsung.com> <CAJFAV8y=nUM9ekiyX8Ldk4j4U_Hz2P=H=qn3o8P4SksmtYn1Gw@mail.gmail.com> Subject: Re: [dpdk-dev] [PATCH] vhost: fix passing destroyed device to destroy callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190411085345.G5SNaRJXbdRYVeoFGjdLmgdSb3T7NNWl9W2WwS3hrw8@z> On 10.04.2019 11:07, David Marchand wrote: > On Wed, Apr 10, 2019 at 9:53 AM Ilya Maximets <i.maximets@samsung.com <mailto:i.maximets@samsung.com>> wrote: > > On 10.04.2019 10:24, David Marchand wrote: > > For vhost maintainers, looking at vhost_user_add_connection, aren't we leaking a vid on errors ? either when new_connection notifier returns an error, or after calling destroy_connection. > > I think that you're right. > I spotted that too yesterday while preparing this patch, just had no time to > check deeper. It should be safe to call 'vhost_destroy_device' in these cases. > > > Yes, that's my understanding too. I'll prepare the patch for this. > > > -- > David Marchand