From: Igor Russkikh <Igor.Russkikh@aquantia.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: Pavel Belous <Pavel.Belous@aquantia.com>,
Igor Russkikh <Igor.Russkikh@aquantia.com>
Subject: [dpdk-dev] [PATCH 08/10] net/atlantic: eliminate excessive log levels on rx/tx
Date: Sat, 2 Mar 2019 12:10:56 +0000 [thread overview]
Message-ID: <997f7e5e1eab9c5af41aa9c05140a2fd72a3b221.1551528549.git.igor.russkikh@aquantia.com> (raw)
In-Reply-To: <cover.1551528549.git.igor.russkikh@aquantia.com>
Default rxtx logging used ERR level, that caused logger to always
trigger. That caused perf degradation even if logger was not enabled but
compiled in.
Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
---
drivers/net/atlantic/atl_rxtx.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlantic/atl_rxtx.c
index aea58c0d5..f1519594a 100644
--- a/drivers/net/atlantic/atl_rxtx.c
+++ b/drivers/net/atlantic/atl_rxtx.c
@@ -946,7 +946,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
break;
}
- PMD_RX_LOG(ERR, "port_id=%u queue_id=%u tail=%u "
+ PMD_RX_LOG(DEBUG, "port_id=%u queue_id=%u tail=%u "
"eop=0x%x pkt_len=%u hash=0x%x hash_type=0x%x",
(unsigned int)rxq->port_id,
(unsigned int)rxq->queue_id,
@@ -981,7 +981,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
while (true) {
new_mbuf = rte_mbuf_raw_alloc(rxq->mb_pool);
if (new_mbuf == NULL) {
- PMD_RX_LOG(ERR,
+ PMD_RX_LOG(DEBUG,
"RX mbuf alloc failed port_id=%u "
"queue_id=%u", (unsigned int)rxq->port_id,
(unsigned int)rxq->queue_id);
@@ -1084,7 +1084,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
adapter->sw_stats.q_ibytes[rxq->queue_id] +=
rx_mbuf_first->pkt_len;
- PMD_RX_LOG(ERR, "add mbuf segs=%d pkt_len=%d",
+ PMD_RX_LOG(DEBUG, "add mbuf segs=%d pkt_len=%d",
rx_mbuf_first->nb_segs,
rx_mbuf_first->pkt_len);
}
@@ -1104,7 +1104,7 @@ atl_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
*/
nb_hold = (uint16_t)(nb_hold + rxq->nb_rx_hold);
if (nb_hold > rxq->rx_free_thresh) {
- PMD_RX_LOG(ERR, "port_id=%u queue_id=%u rx_tail=%u "
+ PMD_RX_LOG(DEBUG, "port_id=%u queue_id=%u rx_tail=%u "
"nb_hold=%u nb_rx=%u",
(unsigned int)rxq->port_id, (unsigned int)rxq->queue_id,
(unsigned int)tail, (unsigned int)nb_hold,
@@ -1129,8 +1129,6 @@ atl_xmit_cleanup(struct atl_tx_queue *txq)
struct hw_atl_txd_s *txd;
int to_clean = 0;
- PMD_INIT_FUNC_TRACE();
-
if (txq != NULL) {
sw_ring = txq->sw_ring;
int head = txq->tx_head;
@@ -1181,11 +1179,7 @@ atl_tso_setup(struct rte_mbuf *tx_pkt, union hw_atl_txc_s *txc)
uint32_t tx_cmd = 0;
uint64_t ol_flags = tx_pkt->ol_flags;
- PMD_INIT_FUNC_TRACE();
-
if (ol_flags & PKT_TX_TCP_SEG) {
- PMD_DRV_LOG(DEBUG, "xmit TSO pkt");
-
tx_cmd |= tx_desc_cmd_lso | tx_desc_cmd_l4cs;
txc->cmd = 0x4;
@@ -1240,8 +1234,6 @@ atl_xmit_pkt(struct aq_hw_s *hw, struct atl_tx_queue *txq,
u32 tx_cmd = 0U;
int desc_count = 0;
- PMD_INIT_FUNC_TRACE();
-
tail = txq->tx_tail;
txc = (union hw_atl_txc_s *)&txq->hw_ring[tail];
--
2.17.1
next prev parent reply other threads:[~2019-03-02 12:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 12:10 [dpdk-dev] [PATCH 00/10] net/atlantic: bugfixes and code cleanup Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 01/10] net/atlantic: Fix negative error codes Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 02/10] net/atlantic: remove unused variable Igor Russkikh
2019-03-04 21:22 ` Rami Rosen
2019-03-02 12:10 ` [dpdk-dev] [PATCH 03/10] net/atlantic: check for error codes Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 04/10] net/atlantic: fix buffer overflow Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 05/10] net/atlantic: use eeprom magic as a device address Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 06/10] net/atlantic: fix eeprom fetching for small and uneven lengths Igor Russkikh
2019-03-02 12:10 ` [dpdk-dev] [PATCH 07/10] net/atlantic: fix link configuration Igor Russkikh
2019-03-02 12:10 ` Igor Russkikh [this message]
2019-03-02 12:10 ` [dpdk-dev] [PATCH 09/10] net/atlantic: fix missing vlan filter offload Igor Russkikh
2019-03-02 12:11 ` [dpdk-dev] [PATCH 10/10] net/atlantic: fix xstats to return correct number of requested items Igor Russkikh
2019-03-04 21:12 ` Rami Rosen
2019-03-04 9:40 ` [dpdk-dev] [PATCH 00/10] net/atlantic: bugfixes and code cleanup David Marchand
2019-03-06 12:08 ` Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=997f7e5e1eab9c5af41aa9c05140a2fd72a3b221.1551528549.git.igor.russkikh@aquantia.com \
--to=igor.russkikh@aquantia.com \
--cc=Pavel.Belous@aquantia.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).