From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id A94D1A0562;
Sun, 28 Mar 2021 04:00:36 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 32C5D40042;
Sun, 28 Mar 2021 04:00:36 +0200 (CEST)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
by mails.dpdk.org (Postfix) with ESMTP id C978A40040
for <dev@dpdk.org>; Sun, 28 Mar 2021 04:00:33 +0200 (CEST)
IronPort-SDR: GTv75H1TiZmWM/jfF1DrfSHLHNN3rPAE6crtMQDbPBItElYuFxgBEWh1AeSRPq1TTO4HpWV3yq
MB5w+CxfNfQA==
X-IronPort-AV: E=McAfee;i="6000,8403,9936"; a="171359923"
X-IronPort-AV: E=Sophos;i="5.81,284,1610438400";
d="scan'208,217";a="171359923"
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
27 Mar 2021 19:00:32 -0700
IronPort-SDR: 6bMQvdQNIuuNSkiUvgjKBbZhsC/5PQUkVMgfcpv/54YRPBJXi6q/IvC9X7SOOlb/ppbBAAjkaS
tuPTWPsKcyFg==
X-IronPort-AV: E=Sophos;i="5.81,284,1610438400";
d="scan'208,217";a="375982290"
Received: from pkadam-mobl1.amr.corp.intel.com (HELO [10.255.231.96])
([10.255.231.96])
by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
27 Mar 2021 19:00:32 -0700
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org, thomas@monjalon.net
Cc: dmitry.kozliuk@gmail.com, ranjit.menon@intel.com, qiming.yang@intel.com,
qi.z.zhang@intel.com
References: <20210303215929.5616-1-pallavi.kadam@intel.com>
<20210311015848.4976-1-pallavi.kadam@intel.com>
<20210311015848.4976-3-pallavi.kadam@intel.com>
<cdcced0c-0cad-86f4-08fc-229fb0c9d540@intel.com>
From: "Kadam, Pallavi" <pallavi.kadam@intel.com>
Message-ID: <99952276-0761-a782-e558-c327d3bf3e24@intel.com>
Date: Sat, 27 Mar 2021 19:00:27 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <cdcced0c-0cad-86f4-08fc-229fb0c9d540@intel.com>
Content-Language: en-US
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [dpdk-dev] [PATCH v2 2/3] net/ice: build on Windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 3/26/2021 4:51 AM, Ferruh Yigit wrote:
> On 3/11/2021 1:58 AM, Pallavi Kadam wrote:
>> - Add Intel ice PMD support on Windows.
>> - Remove #include sys/ioctl header file as it is not needed.
>> - Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting
>> types.
>> - Replace POSIX usleep() API with rte API.
>> - Add a new macro for the access() API as the original function
>> has been deprecated on Windows.
>> - Add extra cflags '-fno-asynchronous-unwind-tables'
>> to avoid MinGW build error:
>> Error: invalid register for .seh_savexmm
>> - Add documentation to support ice PMD on Windows.
>> Update the release notes and features list for the same.
>>
>> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
>> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
>
> <...>
>
>> --- a/drivers/net/ice/base/ice_switch.c
>> +++ b/drivers/net/ice/base/ice_switch.c
>> @@ -6684,7 +6684,7 @@ ice_fill_valid_words(struct ice_adv_lkup_elem
>> *rule,
>> for (j = 0; j < sizeof(rule->m_u) / sizeof(u16); j++)
>> if (((u16 *)&rule->m_u)[j] &&
>> - rule->type < ARRAY_SIZE(ice_prot_ext)) {
>> + (unsigned long long)rule->type <
>> ARRAY_SIZE(ice_prot_ext)) {
>
> isn't 'ARRAY_SIZE' return type is 'size_t', if 'size_t' is supported
> in Windows why not cast to it, instead of "unsigned long long".
Ok. Yes, size_t works on Windows. Will replace it in v3.
>
> <...>
>
>> index b82d05fe7..01f8f409d 100644
>> --- a/drivers/net/ice/base/meson.build
>> +++ b/drivers/net/ice/base/meson.build
>> @@ -29,6 +29,10 @@ foreach flag: error_cflags
>> endif
>> endforeach
>> +if is_windows and cc.get_id() != 'clang'
>> + cflags += ['-fno-asynchronous-unwind-tables']
>> +endif
>> +
>
> This seems not having affect [1], may be because 'cflags' is not used
> for build but 'c_args', moving the block above "c_args = cflags"
> assignment may work.
>
> [1]
> http://mails.dpdk.org/archives/test-report/2021-March/182218.html
Thanks, Ferrruh. Ok, will move this cflag above the assignment and give
it a try.
Either way I am not able to reproduce this error. Let's see if UNH lab
still reports it.