From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80CCEA034F; Wed, 6 May 2020 11:37:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 684E51D70B; Wed, 6 May 2020 11:37:12 +0200 (CEST) Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 574461D705 for ; Wed, 6 May 2020 11:37:11 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200506093710euoutp01479cf40612df250127570365d1082ae7~MZtRV01bc0185701857euoutp01v for ; Wed, 6 May 2020 09:37:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200506093710euoutp01479cf40612df250127570365d1082ae7~MZtRV01bc0185701857euoutp01v DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1588757830; bh=8YBF9SltQayie6kKrHavXmq5+/DKc5Oc+dOfYCqvKpY=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=WfgkWvUa6MSo6LaUlUL2iB9xxlAHRIAw2c5G+E9qPSDvy9wYifGMbcgfdU2xBoKsD wryfO85fmZD2F9vY2ZAvYCJRt+NLr1beZ9icgUZ3IYir2DlooJ21n16ABrxQfK3PeN e4UgM/DKDLGJit+ABp4EdH463r7lu3htXlyGVON4= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200506093710eucas1p2d687652fde87be6bda40a5466aad3972~MZtRJn2kL1033210332eucas1p2J; Wed, 6 May 2020 09:37:10 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 9F.EE.60698.64582BE5; Wed, 6 May 2020 10:37:10 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200506093710eucas1p267539a7a4b5740df9c1910d0b9f1e3d3~MZtQ3qKgB2115421154eucas1p2i; Wed, 6 May 2020 09:37:10 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200506093710eusmtrp285dc469096f3decced272f139225c9d0~MZtQ3E90F0456004560eusmtrp2V; Wed, 6 May 2020 09:37:10 +0000 (GMT) X-AuditID: cbfec7f5-a0fff7000001ed1a-bd-5eb285467cce Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id C2.08.07950.64582BE5; Wed, 6 May 2020 10:37:10 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200506093709eusmtip25613a2d0f249caeb68b6dfcfd4df7c00~MZtQMvmP02678226782eusmtip2I; Wed, 6 May 2020 09:37:09 +0000 (GMT) To: Praveen Shetty , dev@dpdk.org, declan.doherty@intel.com, akhil.goyal@nxp.com, anoobj@marvell.com Cc: bernard.iremonger@intel.com, konstantin.ananyev@intel.com From: Lukasz Wojciechowski Message-ID: <99b1cabf-d1e1-bd22-52f4-14a67c306752@partner.samsung.com> Date: Wed, 6 May 2020 11:37:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200506090240.19214-1-praveen.shetty@intel.com> Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrKKsWRmVeSWpSXmKPExsWy7djPc7purZviDJp3S1msPzOP0WLZlq1M FpsbhS3ePGhisXj3aTuTxfs/i1gsmnbcZnNg9/i1YCmrx+I9L5k8Ji+8yOyx8d0OpgCWKC6b lNSczLLUIn27BK6MV7072Arm81b87p/I1sD4mKuLkZNDQsBEYsL7ycwgtpDACkaJvu3ZXYxc QPYXRoljU0+wQjifGSXerfzFBNOx4OwRJojEcqCqi69YIJy3jBLrv9wBqxIWCJTYcvIBO0hC RKCBUaL150s2kASzgK3E2XnzWUBsNiD7yMyvrCA2r4CbxPyua2A1LAIqEvPmrgKKc3CICsRK TL8WAlEiKHFy5hOwVk4BO4nrH46wQ4yUl2jeOpsZwhaXuPVkPtSlq9glmk9xQtguEl8mH2aE sIUlXh3fwg5hy0j83zkf7BsJgW2MEld//2SEcPYzSlzvXQFVZS1x+N9vNpCDmAU0Jdbv0ocI O0p8XPKfBSQsIcAnceOtIMQNfBKTtk1nhgjzSnS0CUFU60k87ZnKCLP2z9onLBMYlWYh+WwW km9mIflmFsLeBYwsqxjFU0uLc9NTi43zUsv1ihNzi0vz0vWS83M3MQITz+l/x7/uYNz3J+kQ owAHoxIP7w2XjXFCrIllxZW5hxglOJiVRHh5fgCFeFMSK6tSi/Lji0pzUosPMUpzsCiJ8xov ehkrJJCeWJKanZpakFoEk2Xi4JRqYAzepsbMEeW5yGreHS+3qepOcsc07c/c6e878LxVIEC7 hPtaRvK7z95rX7HzBP87tmhT1+MozuyaTxXRmS851T5v/q2gc+rjp9XvXr4r97S9U1B6w+/v Btk/KnvElSakhAYkdO9Zd/tuwu7yHbdaF4RahrBcZ7p/eudxfeevYSceJvaIXuNh41ViKc5I NNRiLipOBADb9ymfOAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRmVeSWpSXmKPExsVy+t/xe7purZviDBbf57RYf2Yeo8WyLVuZ LDY3Clu8edDEYvHu03Ymi/d/FrFYNO24zebA7vFrwVJWj8V7XjJ5TF54kdlj47sdTAEsUXo2 RfmlJakKGfnFJbZK0YYWRnqGlhZ6RiaWeobG5rFWRqZK+nY2Kak5mWWpRfp2CXoZr3p3sBXM 56343T+RrYHxMVcXIyeHhICJxIKzR5hAbCGBpYwSk09ydDFyAMVlJD5cEoAoEZb4c62LrYuR C6jkNaPEgzfLGEESwgKBEltOPmAHSYgINDBKvDw+gQ0kwSxgK3F23nwWiI6JQIm1n5lBEmxA iSMzv7KC2LwCbhLzu66BNbAIqEjMm7uKFWSzqECsRMtFTYgSQYmTM5+wgNicAnYS1z8cYYeY byYxb/NDZghbXqJ562woW1zi1pP5TBMYhWYhaZ+FpGUWkpZZSFoWMLKsYhRJLS3OTc8tNtIr TswtLs1L10vOz93ECIy0bcd+btnB2PUu+BCjAAejEg+vgfvGOCHWxLLiytxDjBIczEoivDw/ gEK8KYmVValF+fFFpTmpxYcYTYF+m8gsJZqcD0wCeSXxhqaG5haWhubG5sZmFkrivB0CB2OE BNITS1KzU1MLUotg+pg4OKUaGP3/bj2a9tSlJCxt6vbknWL7Q2RPGVxWmOcy5b5Y0tp65r2/ sgTbN7vl2O6VWHCeNSFYR0inxuGDx623QXlcsZoJzI8u9H3Y8pAlQS5so7P9R559n/ctLd39 XEed73PolX37vbR/Hr3468cR/22SNslHGqMTRPo3KFd4WlfbrXnjJxZmOeV7nBJLcUaioRZz UXEiAMNFdOXKAgAA X-CMS-MailID: 20200506093710eucas1p267539a7a4b5740df9c1910d0b9f1e3d3 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200506090256eucas1p1c4457861c66c164d46000835709ccd84 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200506090256eucas1p1c4457861c66c164d46000835709ccd84 References: <20200506090240.19214-1-praveen.shetty@intel.com> Subject: Re: [dpdk-dev] [PATCH v1] examples/ipsec-secgw: resolve coverity issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 06.05.2020 o 11:02, Praveen Shetty pisze: > Function create_ipsec_esp_flow returns a negative number in case of any > failure. But passing negative number to strerror is causing the coverity > issue. > In case of failure, displaying exact error message to console is handled > in create_ipsec_esp_flow function.So it is not required to print the > error message again using strerror. > This patch will remove the unnecessary calling of strerror function > to fix the coverity issue. > > Coverity issue: 357691 > Fixes: 6738c0a95695 ("examples/ipsec-secgw: support flow director") > Cc: praveen.shetty@intel.com > > Signed-off-by: Praveen Shetty > --- > examples/ipsec-secgw/sa.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/examples/ipsec-secgw/sa.c b/examples/ipsec-secgw/sa.c > index e3a1a5aff..632482176 100644 > --- a/examples/ipsec-secgw/sa.c > +++ b/examples/ipsec-secgw/sa.c > @@ -1223,8 +1223,7 @@ sa_add_rules(struct sa_ctx *sa_ctx, const struct ipsec_sa entries[], > rc = create_ipsec_esp_flow(sa); > if (rc != 0) > RTE_LOG(ERR, IPSEC_ESP, > - "create_ipsec_esp_flow() failed %s\n", > - strerror(rc)); > + "create_ipsec_esp_flow() failed\n"); > } > print_one_sa_rule(sa, inbound); > } great!, especially that create_ipsec_esp_flow returns mostly -1 in case of errors and that would be -EPERM ;) Acked-by: Lukasz Wojciechowski -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com