From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 86CC81BDA6 for ; Fri, 13 Apr 2018 15:23:10 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id s12so8268428wrc.8 for ; Fri, 13 Apr 2018 06:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=aCvMr5aaWcLLQZO5iMNSFvQfxbFVfOhaIKZwRgCuz5A=; b=UwyKeLcuN9bD3kGa4tCMXYB6OQ3NyZJlQNtJ+UREfCI/a4hoCx3t80ZO4jfMIsycc/ nn6RlRVrKnukVWJJVzwMuXXI6IX2nX38eVC/ysEn735vpx9IgWlB6ISOqbSbtWcO7Z+A mtw8tnViTYBdkm3Thl4JFbo+OaDpMT28jLh5HnH5B1eNQyhe6qOj4ETqHSCjMt47/iFO rw1Z4D+vr+mEbF2qpSBc2tKymU6N5IVn91ode4x0ZKWvfOYcoEtClpZEPqGUKZId2d/y +QFsoPXira9z+iNlDHuDfxPNPvEtR5d5jS6/ft9Ywq+0f/tDEdNJ7JtiO3gIx/QFdDN5 344w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=aCvMr5aaWcLLQZO5iMNSFvQfxbFVfOhaIKZwRgCuz5A=; b=B9DSr65HdDYPGgUiDdblyOCzomE6O95oUhEk+hme2qDpclAQn/5yvADS/oDSCDSehE eri2pVNIP4nk6SVg0nYfACNSBqWdrAjMqMIh28K6Hw0EynDoOziWXPsmCqexqZLC0u0X P/S6yLACKKGcfryMIxrA9QZtznPepxER9ZroFi2Dt8KRQ/gZN47+sANdBVOYX8t4tvWv 0kAcrMosQd15zzO7hECr50zqcg/5OS5JQ99owGMp8XJz0HuIjYkHWeTeMnjAKueCWZQ6 It2yDiYT0F5tIeFEi95g23z019Q4VoWlRbK/EwD+S4Q+OevDfJNV7XOvOQByYnwF8uZa pdlA== X-Gm-Message-State: ALQs6tCNoE1r260zLifKt/2xHvbcv99QeM0Iqy+WRXxmsHaLM+R2GN+8 gtM3sTW67XubC1H/LP1k3/Mlh3qd X-Google-Smtp-Source: AIpwx4+j9rifUqmauvPE2Q+aoxkLniSy0bDOfDwr3atuk9oxNrMKIKJ1Qd0mogXCFXS6qRkL9ObUvQ== X-Received: by 10.223.201.146 with SMTP id f18mr3652470wrh.202.1523625789694; Fri, 13 Apr 2018 06:23:09 -0700 (PDT) Received: from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id r200sm2377244wmb.9.2018.04.13.06.23.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Apr 2018 06:23:08 -0700 (PDT) From: Gaetan Rivet To: dev@dpdk.org Cc: Gaetan Rivet Date: Fri, 13 Apr 2018 15:22:25 +0200 Message-Id: <99b4bfeb38a0d897297116fad75f8f7656c57877.1523625525.git.gaetan.rivet@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v6 10/22] eal/dev: implement device iteration initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 13:23:11 -0000 Parse a device description. Split this description in their relevant part for each layers. No dynamic allocation is performed. Signed-off-by: Gaetan Rivet --- lib/Makefile | 1 + lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/common/eal_common_dev.c | 148 ++++++++++++++++++++++++++++++++ lib/librte_eal/common/include/rte_dev.h | 24 ++++++ lib/librte_eal/linuxapp/eal/Makefile | 1 + lib/librte_eal/rte_eal_version.map | 1 + 6 files changed, 176 insertions(+) diff --git a/lib/Makefile b/lib/Makefile index fc7a55a37..1b17526f7 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -6,6 +6,7 @@ include $(RTE_SDK)/mk/rte.vars.mk DIRS-y += librte_compat DIRS-$(CONFIG_RTE_LIBRTE_KVARGS) += librte_kvargs DIRS-$(CONFIG_RTE_LIBRTE_EAL) += librte_eal +DEPDIRS-librte_eal := librte_kvargs DIRS-$(CONFIG_RTE_LIBRTE_PCI) += librte_pci DEPDIRS-librte_pci := librte_eal DIRS-$(CONFIG_RTE_LIBRTE_RING) += librte_ring diff --git a/lib/librte_eal/bsdapp/eal/Makefile b/lib/librte_eal/bsdapp/eal/Makefile index de0e6d166..35f98448c 100644 --- a/lib/librte_eal/bsdapp/eal/Makefile +++ b/lib/librte_eal/bsdapp/eal/Makefile @@ -18,6 +18,7 @@ CFLAGS += $(WERROR_FLAGS) -O3 LDLIBS += -lexecinfo LDLIBS += -lpthread LDLIBS += -lgcc_s +LDLIBS += -lrte_kvargs EXPORT_MAP := ../../rte_eal_version.map diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c index 149e9ad72..d8e306926 100644 --- a/lib/librte_eal/common/eal_common_dev.c +++ b/lib/librte_eal/common/eal_common_dev.c @@ -10,9 +10,12 @@ #include #include +#include #include #include #include +#include +#include #include #include #include @@ -368,3 +371,148 @@ dev_callback_process(char *device_name, enum rte_dev_event_type event) } rte_spinlock_unlock(&dev_event_lock); } + +static size_t +dev_layer_count(const char *s) +{ + size_t i = s ? 1 : 0; + + while (s != NULL && s[0] != '\0') { + i += s[0] == '/'; + s++; + } + return i; +} + +__rte_experimental +int +rte_dev_iterator_init(struct rte_dev_iterator *it, + const char *devstr) +{ + struct { + const char *key; + const char *str; + struct rte_kvargs *kvlist; + } layers[] = { + { "bus=", NULL, NULL, }, + { "class=", NULL, NULL, }, + { "driver=", NULL, NULL, }, + }; + struct rte_kvargs_pair *kv = NULL; + struct rte_class *cls = NULL; + struct rte_bus *bus = NULL; + const char *s = devstr; + size_t nblayer; + size_t i = 0; + + /* Having both busstr and clsstr NULL is illegal, + * marking this iterator as invalid unless + * everything goes well. + */ + it->busstr = NULL; + it->clsstr = NULL; + /* Split each sub-lists. */ + nblayer = dev_layer_count(devstr); + if (nblayer > RTE_DIM(layers)) { + RTE_LOG(ERR, EAL, "Invalid query: too many layers (%zu)\n", + nblayer); + rte_errno = EINVAL; + goto get_out; + } + while (s != NULL) { + char *copy; + char *end; + + if (strncmp(layers[i].key, s, + strlen(layers[i].key))) + goto next_layer; + layers[i].str = s; + copy = strdup(s); + if (copy == NULL) { + RTE_LOG(ERR, EAL, "OOM\n"); + rte_errno = ENOMEM; + goto get_out; + } + end = strchr(copy, '/'); + end = end ? end : strchr(copy, '\0'); + end[0] = '\0'; + layers[i].kvlist = rte_kvargs_parse(copy, NULL); + free(copy); + if (layers[i].kvlist == NULL) { + RTE_LOG(ERR, EAL, "Could not parse %s\n", s); + rte_errno = EINVAL; + goto get_out; + } + s = strchr(s, '/'); + if (s != NULL) + s++; +next_layer: + if (i >= RTE_DIM(layers)) { + RTE_LOG(ERR, EAL, "Unrecognized layer %s\n", s); + rte_errno = EINVAL; + goto get_out; + } + i++; + } + /* Parse each sub-list. */ + for (i = 0; i < RTE_DIM(layers); i++) { + if (layers[i].kvlist == NULL) + continue; + kv = &layers[i].kvlist->pairs[0]; + if (strcmp(kv->key, "bus") == 0) { + bus = rte_bus_find_by_name(kv->value); + if (bus == NULL) { + RTE_LOG(ERR, EAL, "Could not find bus \"%s\"\n", + kv->value); + rte_errno = EFAULT; + goto get_out; + } + } else if (strcmp(kv->key, "class") == 0) { + cls = rte_class_find_by_name(kv->value); + if (cls == NULL) { + RTE_LOG(ERR, EAL, "Could not find class \"%s\"\n", + kv->value); + rte_errno = EFAULT; + goto get_out; + } + } else if (strcmp(kv->key, "driver") == 0) { + /* Ignore */ + continue; + } + } + /* The string should have at least + * one layer specified. + */ + if (bus == NULL && cls == NULL) { + RTE_LOG(ERR, EAL, + "Either bus or class must be specified.\n"); + rte_errno = EINVAL; + goto get_out; + } + if (bus != NULL && bus->dev_iterate == NULL) { + RTE_LOG(ERR, EAL, "Bus %s not supported\n", bus->name); + rte_errno = ENOTSUP; + goto get_out; + } + if (cls != NULL && cls->dev_iterate == NULL) { + RTE_LOG(ERR, EAL, "Class %s not supported\n", cls->name); + rte_errno = ENOTSUP; + goto get_out; + } + /* Fill iterator fields. */ + if (bus != NULL) + it->busstr = layers[0].str; + if (cls != NULL) + it->clsstr = layers[1].str; + it->devstr = devstr; + it->bus = bus; + it->cls = cls; + it->device = NULL; + it->class_device = NULL; +get_out: + for (i = 0; i < RTE_DIM(layers); i++) { + if (layers[i].kvlist) + rte_kvargs_free(layers[i].kvlist); + } + return -rte_errno; +} diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h index a789defc3..eb1ad6182 100644 --- a/lib/librte_eal/common/include/rte_dev.h +++ b/lib/librte_eal/common/include/rte_dev.h @@ -329,6 +329,30 @@ typedef void *(*rte_dev_iterate_t)(const void *start, const char *devstr, const struct rte_dev_iterator *it); +/** + * Initializes a device iterator. + * + * This iterator allows accessing a list of devices matching a criteria. + * The device matching is made among all buses and classes currently registered, + * filtered by the device description given as parameter. + * + * This function will not allocate any memory. It is safe to stop the + * iteration at any moment and let the iterator go out of context. + * + * @param it + * Device iterator handle. + * + * @param str + * Device description string. + * + * @return + * 0 on successful initialization. + * <0 on error. + */ +__rte_experimental +int +rte_dev_iterator_init(struct rte_dev_iterator *it, const char *str); + #ifdef __cplusplus } #endif diff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile index b11f92e03..47fd07323 100644 --- a/lib/librte_eal/linuxapp/eal/Makefile +++ b/lib/librte_eal/linuxapp/eal/Makefile @@ -27,6 +27,7 @@ LDLIBS += -lrt ifeq ($(CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES),y) LDLIBS += -lnuma endif +LDLIBS += -lrte_kvargs # specific to linuxapp exec-env SRCS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) := eal.c diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map index 75121b08d..1a41e9413 100644 --- a/lib/librte_eal/rte_eal_version.map +++ b/lib/librte_eal/rte_eal_version.map @@ -223,6 +223,7 @@ EXPERIMENTAL { rte_eal_devargs_remove; rte_class_register; rte_class_unregister; + rte_dev_iterator_init; rte_eal_hotplug_add; rte_eal_hotplug_remove; rte_eal_mbuf_user_pool_ops; -- 2.11.0