From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB70CA04C7; Mon, 14 Sep 2020 17:02:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C35A21BE95; Mon, 14 Sep 2020 17:02:27 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 82FF92C36 for ; Mon, 14 Sep 2020 17:02:25 +0200 (CEST) IronPort-SDR: VY5tc3TwZplUWKeOyusDy/Oz80hxpDTzcg3djZOUTos8lDW0Wf1bQPLKUAMpKqXkt0twYLCnBz MNGRIb0mvCaA== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="146829075" X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="146829075" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 08:02:07 -0700 IronPort-SDR: O9uX+kLIUg5v2hoZe/fCKdLYfYHgm2NwH34GrfjIw8IZFaPD05hA/SC6J1e/6w3ccpEAe0V8FY ESeLjBiquteQ== X-IronPort-AV: E=Sophos;i="5.76,426,1592895600"; d="scan'208";a="482370629" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.251.82.108]) ([10.251.82.108]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 08:02:06 -0700 To: Stephen Hemminger , dev@dpdk.org References: <20200911190701.29171-1-stephen@networkplumber.org> <20200911190701.29171-7-stephen@networkplumber.org> From: "Burakov, Anatoly" Message-ID: <99ef37e3-15f3-c911-6865-4f2420eda7f0@intel.com> Date: Mon, 14 Sep 2020 16:02:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200911190701.29171-7-stephen@networkplumber.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 06/15] app/test: replace uses of master/slave X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11-Sep-20 8:06 PM, Stephen Hemminger wrote: > Replace master lcore with main lcore and slave lcore with worker lcore. > Mostly automatic replacement. > > Signed-off-by: Stephen Hemminger > --- > app/test/autotest_test_funcs.py | 2 +- > app/test/meson.build | 2 +- > app/test/test.c | 2 +- > app/test/test_atomic.c | 26 +++--- > app/test/test_barrier.c | 2 +- > app/test/test_compressdev_test_buffer.h | 2 +- > app/test/test_cryptodev.c | 12 +-- > app/test/test_distributor.c | 8 +- > app/test/test_distributor_perf.c | 10 +-- > app/test/test_eal_flags.c | 32 +++---- > app/test/test_efd.c | 2 +- > app/test/test_efd_perf.c | 2 +- > app/test/test_func_reentrancy.c | 6 +- > app/test/test_hash_multiwriter.c | 4 +- > app/test/test_hash_readwrite.c | 39 +++++---- > app/test/test_kni.c | 16 ++-- > app/test/test_lpm_perf.c | 4 +- > app/test/test_malloc.c | 12 +-- > app/test/test_mbuf.c | 33 ++++---- > app/test/test_mcslock.c | 28 +++---- > app/test/test_mempool_perf.c | 10 +-- > app/test/test_mp_secondary.c | 2 +- > app/test/test_pdump.c | 2 +- > app/test/test_per_lcore.c | 14 ++-- > app/test/test_pmd_perf.c | 20 ++--- > app/test/test_rcu_qsbr.c | 2 +- > app/test/test_rcu_qsbr_perf.c | 2 +- > app/test/test_ring_perf.c | 14 ++-- > app/test/test_ring_stress_impl.h | 10 +-- > app/test/test_rwlock.c | 28 +++---- > app/test/test_service_cores.c | 14 ++-- > app/test/test_spinlock.c | 34 ++++---- > app/test/test_stack.c | 2 +- > app/test/test_stack_perf.c | 6 +- > app/test/test_ticketlock.c | 36 ++++---- > app/test/test_timer.c | 106 ++++++++++++------------ > app/test/test_timer_racecond.c | 26 +++--- > app/test/test_timer_secondary.c | 2 +- > app/test/test_trace_perf.c | 4 +- > 39 files changed, 288 insertions(+), 290 deletions(-) > Overall, Acked-by: Anatoly Burakov However, couple of missed instances below. > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > index 70bf6fe2c1a6..fc059fe3dcfc 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -479,29 +479,29 @@ testsuite_setup(void) > char vdev_args[VDEV_ARGS_SIZE] = {""}; > char temp_str[VDEV_ARGS_SIZE] = {"mode=multi-core," > "ordering=enable,name=cryptodev_test_scheduler,corelist="}; > - uint16_t slave_core_count = 0; > + uint16_t worker_core_count = 0; > uint16_t socket_id = 0; > > if (gbl_driver_id == rte_cryptodev_driver_id_get( > RTE_STR(CRYPTODEV_NAME_SCHEDULER_PMD))) { > > /* Identify the Slave Cores > - * Use 2 slave cores for the device args > + * Use 2 worker cores for the device args > */ Missed the beginning of this comment. > index f5ddd03d7670..ffa0fd2380a3 100644 > --- a/app/test/test_func_reentrancy.c > +++ b/app/test/test_func_reentrancy.c > @@ -58,7 +58,7 @@ static rte_atomic32_t obj_count = RTE_ATOMIC32_INIT(0); > static rte_atomic32_t synchro = RTE_ATOMIC32_INIT(0); > > #define WAIT_SYNCHRO_FOR_SLAVES() do{ \ > - if (lcore_self != rte_get_master_lcore()) \ > + if (lcore_self != rte_get_main_lcore()) \ > while (rte_atomic32_read(&synchro) == 0); \ Macro should've been renamed too, along with all of its usages. -- Thanks, Anatoly