From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB11FA00C2; Thu, 10 Feb 2022 11:31:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A484E40140; Thu, 10 Feb 2022 11:31:40 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id B40544013F for ; Thu, 10 Feb 2022 11:31:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644489098; x=1676025098; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=T4DdrsFWSHiZdjs0/+rB6eHXoYanwC292SHQ4v0uc/Q=; b=KK0j7JNSx2UfDN48CoxXRaVCmhiQyAtaRkeSw+TD4RVchG/loU6FW+CR WeeQ64YyvHbWwffqpQBqTAPWR6SAOyTIN9aLyFPSvwUbxJqXyudhVtsz+ ctC/Iv6IEKAQyItaELYsV7PH57A7A23Yo0so/PV4kzI4B5AIZM9SUCin5 EjZCy0PG9Fjbdv6ofG3fCeRo7bCHgdqZtfRC8o4Ews9MWdssaFBoiw5zh uyM2/gMlZwkdSVPXipSDBfCMj/SO7O4KWakaqLqlMPH7upYSkON51XliU y0iFdWnxVKO0PO2UYuauUxUmrMJeKh5HF82/cqUxrphwENhHnG75M6f1j w==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="249409970" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="249409970" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 02:31:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="629643876" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga002.fm.intel.com with ESMTP; 10 Feb 2022 02:31:37 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 10 Feb 2022 02:31:36 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 10 Feb 2022 02:31:36 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 10 Feb 2022 02:31:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B1mvZKfbhXMSqkjqvGi+v28Ne5+r7gJnkgwZQiI+aRpEpjz0P9NmrV7scFc941hBvkPbU4m8YKNZdGkP7pQ17Wa1DA7QOud7oB6yhBkGAbC4NzGVLn88JnXeigj6c+dtGhS4Rh+y7093qISpGgsZU4EglSfb8Wi9P0Oo8N++GKTPuNZiPyJfiTVQKal8AwPWUXLhkoogq99gKSxVY+7DFh8OVxd65Udm5/YFkRo3NYaejCroydCJQ5CeOsBBx4AycG95HkQnlkGeUZrEl3EPFuX6/VUcuREARCNwwEKR9aoY5GSIKSKm+ng80jHNgPEpD/uiJg2i4yCprKabRF6VWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UO893zkSvrfvg6FUy7cW9uoSt8bqn9Sowpd45AAP10A=; b=oAYcFqf5BzyBLeU/F4D6Ub7xsBfAn7DKZqgqLmyNvx04MeW6AKBPHdPzwYEjGe2BKbe/SVVS3PIzJDchp51+MpXTzyjNXjerboNEKLSzznQceGQ6EbfuXvCZ/W0vG41zYWAjBlLO1lbknkcNQtOfgM590j/8giXXoEfYOYpRJ9qEf2ZU1i2BI5A74kg/4rmGm5m54bpD6ixj+j7AcAEtTN5voXNdB9h7tuo2Rt0cSTlw/hZPNhD5GjT7V5miRbuE1JCyPQPj79GijUcIKz+o0MPoY4Jqu8jZGQLoxHguzutdD3oZ4o6Crjq8GBkv/SAFRuUn2H8RqX4Ctjfm4ln8GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BN7PR11MB2851.namprd11.prod.outlook.com (2603:10b6:406:ac::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Thu, 10 Feb 2022 10:31:33 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.011; Thu, 10 Feb 2022 10:31:33 +0000 Message-ID: <99fecfc6-a52b-46c0-f79f-96260008f1bb@intel.com> Date: Thu, 10 Feb 2022 10:31:27 +0000 Subject: Re: [PATCH v1] net/af_xdp: make umem configure code more readable Content-Language: en-US To: "Loftus, Ciara" , "Wang, Haiyue" , "dev@dpdk.org" CC: "Zhang, Qi Z" References: <20220209124358.137807-1-haiyue.wang@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0345.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:d::21) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 503d9514-9ac2-48fb-d226-08d9ec8081ca X-MS-TrafficTypeDiagnostic: BN7PR11MB2851:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3826; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: teEIu80wrTkF2A//FqrEK/VSM4M1QJe98YwcfEztgpqxZvZc5JdkMA2onpFsKGmrJPwVOuu38cZuXIcuTc3HGqi1y1ktwkU13PU9XUs6btrgFav787O1VwnHKfHOpcqWs+trUE4RIuRasE0gz+DHnt7M90z54xQuLach5ZNIhagjtq8CUCxSEW4xYCZ5GWg92u6t2DFkwfa52Ym157qSBTYRE5pEWicovnVx8g9tykynS88c1SHrJXCmY9oMPAtLY7CRjkI4ba+WQEnt4RrmXA+fUoBT8uK4Citm/5liMnipdjXHyrYtipVXx7PDh7VSn7gkYgYtEHj2OnUhfm4q60q1vtKIeyR/ln/2x8fxOLzyR/OMxkTJ/VZ08UtANPbifnS774U7x0EFt6Y+rQix4rsisfwpn/mAMaNp+87TCYek/2iCGgaD3y9NywxVfCyidBI1skhaRoJZ3F5LE9+P/i5pKj2s6SHUFXJTeOPcYeA6vEgJzUS/dR9LmS62yXjX9W0+MbgP9sMTxS8YV4yTl8nEOTumpo0UAmmUPZPkXQaZ+r+Zx6VdGRHrej4Ik/zxbXYdbGqt+Ml7fH7QiZOWlpGW1tnDzy+edYXBBiWQeZsQUt/aCZ9L3gP75GhyaK6ROOmWgOkxzWJJ8mSVEWxtaUL4RspQK7G+sIy46Sf0khjq2OmCxZS5rtgS8QLWlJHmIr45xwgpTSzpEZTKVUXhYQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8676002)(66476007)(66946007)(66556008)(4326008)(38100700002)(31686004)(5660300002)(8936002)(110136005)(316002)(44832011)(36756003)(2906002)(4744005)(6486002)(6506007)(53546011)(31696002)(55236004)(508600001)(186003)(26005)(2616005)(6512007)(83380400001)(107886003)(86362001)(6666004)(82960400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWI2ejg2azNNVUxFVkFSTGx1U3NRelJpNmhkM3pseVNUa0hybExFYisrMGVE?= =?utf-8?B?VTI2MXJZQnd5QkJLdEN4NEdXTnE2L1FWazRZcTY2Z3BmWFMxT3FDbzRyZVAx?= =?utf-8?B?cGl5bnJhcHAzc2VZeTIwakVuL08xRTZPRk8vVEZ4YlY1MjdvZmYxVDZZSEJQ?= =?utf-8?B?NFZmelRoNURnaERtQWd2TDRHeS9ESlNjeWhVRVovVTFvOXY5Qi9nbTRTV08y?= =?utf-8?B?dHpVSmI1RjFESFpBdWsydlNRMkRtMmdnTUh5UXBFV2hqL1JvdmlMdnZvWUFv?= =?utf-8?B?NGFUcUpESTdqMlFXM1B3MDl4NUV3YjYxa3IweXBoajJ6bnY3bEM3Rk9ZcHZZ?= =?utf-8?B?VHdSdWpJWmExYXFDa0JsOGlWMWdnY0R4M21CQXRtYXVndmY0MEU2dGZCQlgr?= =?utf-8?B?N3Q3K2pwNXI4TThhMFd1ZVduNGE1K3krRzZVSHFmLytYNHo2aThFQnBvT1Jh?= =?utf-8?B?RWlHNy9jOTllb0ZBZVdpbVd6bFRtM1orRE1uRi95bllXYUxMakh3V1Z2S1Zq?= =?utf-8?B?WHVlTjFOV0xYYnJzb1o0YzRJYzJ1LzBORlFNZUMzSXgzSm9iZnJNRld5OEpN?= =?utf-8?B?dVpNZHRpWXBjdFB1d2I3QUZvM0l3MFFYcU5ZKzVtOHQwOGVSbXNnNHpJWG5n?= =?utf-8?B?dS85Wmtxa2FOU1Vxb3pMQkxwNmd6VnFiS2NPcnBISytoa0tnQTNUTmNLbnVG?= =?utf-8?B?b3E1KzNteVRKSG1lbG9BZW41NFh4dkpiZHFQeTl1RlFzRjNvQnc2aVR3bnh3?= =?utf-8?B?d0ZhZTJZYTcwckRheHQxT3VsZFBlNlVHT1RpSjlDYUg1THp4aGxyeEQ3ZGps?= =?utf-8?B?bjk1cWNDRnd6M2F1eGxPZDdnMVc5Q0V2akF5MjBKZTBXWkhLRVdhby9qb1Rj?= =?utf-8?B?VTRrWm1MdlFvTWRxcmd5MWVSNHQvYVFvcitqWEhYYnd2ZThzMzV6ekhRN0Rs?= =?utf-8?B?YTlRbjVRNFVZamp2VEk1RlVQd1hzVWF6bDMwSTM2QnpsazliRGtDQ0VZQ3hI?= =?utf-8?B?K0VXdjJweGYrcDFyYjNrVGtiNi8rM1FrcE8vVGNKYlpjRS9zazE0QWdLcDZS?= =?utf-8?B?UitlS2xnblYrMVdGb0xzbVpHdzA0bTg1RWlIUUdqR2RTcDZkRHcrQm8yQ2tE?= =?utf-8?B?MFBkc2RzSTlJT1FHZXZrdlEyVVh2ZnpwenZvOGNDNGg0MXFxZUhrWE1heXRP?= =?utf-8?B?cWMwVW9TRmttYWVwVG40b08xYTl2WW0yQ1AzdEpRbFFjWkZvZEdRVWc4b3k0?= =?utf-8?B?Tlc0dm4wUEF1YlYrbm5Pa0E5R1ZRaWpUOGljamFUTmlEK3lpZjB5NngvbU9E?= =?utf-8?B?c0JFMlVNRFY2K3NaNWI4WkFpQytDZlJmdENzK3hUSk1nQ2dJS0I1Mnd5OU1a?= =?utf-8?B?UlUwRWF5U09yYTMrTHhiWlV5WUxFb3ZBSjMvZ1NWcld5cVhQVWIxRDViNk41?= =?utf-8?B?Ri9HUVdWNlZSZDNTeWRjWmp6c2lvSDRCeDlKYnd0U3JkWUVacGtZdlM5czFF?= =?utf-8?B?YmxRd0xxcDRMS3BCMFFuUldqNUt6Vnk3QVkwZFJTRENwUXViMW9NenlGbngr?= =?utf-8?B?NnkvZjZITkJ5WXZzUE1YQ1NUdGRDbk5WNVFZaHFPVHRvWGNwQ1QvWFBRWlMw?= =?utf-8?B?UE1GTHFDQzl3UnlsUSt4QXNZTzJIWWRML3o5Y3hVUE9rL2pUVFlyb1JXY28r?= =?utf-8?B?aEJIb1ZCNWdLUVpUdGZkR2Vab3JYL2ROTzRKUTFMMmdIbWhRcHJJdUxISFkw?= =?utf-8?B?azZBL3MvcGhXNmIybWVzc3Mvb1FHS3drb3p0WXovSzEvcnZISjY2SDlNa0hY?= =?utf-8?B?aWs1Y2ZOOEx2cnpFS0duNFFaQ1RadzNFNlRUK1JxNHNiWmJDTEhNTXVUa3Mz?= =?utf-8?B?STFiMlpjcVY0R1BFbmlreXNibHQ5YU5aRldDVHU0OE9kSFhYNHU1clJmc2RL?= =?utf-8?B?cmpCWnEreFJ3V2ExT29jVXNSZmZjV2o0SFpqWW1vam1JaXJtUmVuVzlIVEhk?= =?utf-8?B?UWdUT1E2Y0dKd1MrTENpU1JmMmtGVnNsekNIT2dWNWZ6NEZsdUhwQ082ckkw?= =?utf-8?B?Y3dacVVQV0Y2NDRINGZOQ0RXcGc2WUZTYUhFSEhDckxUZmhhWitoZjBaYS96?= =?utf-8?B?bW9vN1pGUkFzWElPVmNKVDZ2WUpCUUhUa1I2SE90aXoyODlxTGp1bFFETTF4?= =?utf-8?Q?ChBUncpKltnYaYCAM05YnGc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 503d9514-9ac2-48fb-d226-08d9ec8081ca X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2022 10:31:32.9983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IjQgt2l2IQ0/jWiLXzWkXBXh4mQsnEPeRivyBWJh2pNCDb8Dt488nIdk4kra3rkfJAOEpQMCmzJNFy8LIYbTaQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR11MB2851 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/10/2022 8:53 AM, Loftus, Ciara wrote: >> Subject: [PATCH v1] net/af_xdp: make umem configure code more readable >> >> The below compile time defined style make the code not so readable, the >> first function end block is after "#endif" segment. >> >> #if defined(XDP_UMEM_UNALIGNED_CHUNK_FLAG) >> >> xdp_umem_configure() >> { >> >> #else >> xdp_umem_configure() >> { >> >> #endif >> 'shared code block' >> } >> >> Signed-off-by: Haiyue Wang > > Thanks for the patch! > > Acked-by: Ciara Loftus > Applied to dpdk-next-net/main, thanks.