From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 77F3D20F for ; Tue, 27 Oct 2015 09:22:33 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 27 Oct 2015 01:22:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,204,1444719600"; d="scan'208";a="672523785" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 27 Oct 2015 01:22:32 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 27 Oct 2015 01:22:31 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.253]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.204]) with mapi id 14.03.0248.002; Tue, 27 Oct 2015 16:22:30 +0800 From: "Sun, Xutao" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] examples/vmdq: Fix the core dump issue when mem_pool is more than 34 Thread-Index: AQHREIzLVI4p8H9t+Uq16G801/lXBJ5+/bKw Date: Tue, 27 Oct 2015 08:22:29 +0000 Message-ID: <9AC567D38896294095E6F3228F697FC8021C49FD@shsmsx102.ccr.corp.intel.com> References: <1444721365-1065-1-git-send-email-xutao.sun@intel.com> <1445922658-4955-1-git-send-email-xutao.sun@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] examples/vmdq: Fix the core dump issue when mem_pool is more than 34 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2015 08:22:33 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Tuesday, October 27, 2015 3:55 PM > To: Sun, Xutao; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] examples/vmdq: Fix the core dump issue > when mem_pool is more than 34 >=20 > Hi Xutao, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xutao Sun > > Sent: Tuesday, October 27, 2015 5:11 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v2] examples/vmdq: Fix the core dump issue > > when mem_pool is more than 34 > > > > Macro MAX_QUEUES was defined to 128, only allow 16 vmdq_pools in > > theory. > > When running vmdq_app with more than 34 vmdq_pools, it will cause the > > core_dump issue. > > Change MAX_QUEUES to 1024 will solve this issue. > > > > Signed-off-by: Xutao Sun > > --- > > v2: > > - rectify the NUM_MBUFS_PER_PORT since MAX_QUEUES has been > changed > > > > examples/vmdq/main.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c index > > a142d49..bba5164 100644 > > --- a/examples/vmdq/main.c > > +++ b/examples/vmdq/main.c > > @@ -69,12 +69,13 @@ > > #include > > #include > > > > -#define MAX_QUEUES 128 > > +#define MAX_QUEUES 1024 > > /* > > * For 10 GbE, 128 queues require roughly > > * 128*512 (RX/TX_queue_nb * RX/TX_ring_descriptors_nb) per port. > > */ > > -#define NUM_MBUFS_PER_PORT (128*512) > > +#define NUM_MBUFS_PER_PORT (MAX_QUEUES * > > RTE_MAX(RTE_TEST_RX_DESC_DEFAULT, \ > > + > > RTE_TEST_TX_DESC_DEFAULT)) > > #define MBUF_CACHE_SIZE 64 > > > > #define MAX_PKT_BURST 32 > > -- > > 1.9.3 >=20 > Please, change the comment above, as you have change code related to it, > i.e. it is not 128*512 anymore. >=20 > Pablo Hi, Pablo I described how I changed code in version 2 below "v2". And I think the main feature of the patch to is modify the number of MAX_QU= EUES. So I just described the other features briefly. Thanks, Xutao