From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 315E1C3A6 for ; Thu, 28 Jan 2016 10:05:51 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 28 Jan 2016 01:05:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,357,1449561600"; d="scan'208";a="890863391" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 28 Jan 2016 01:05:46 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 28 Jan 2016 01:05:44 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 28 Jan 2016 01:05:43 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.172]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.117]) with mapi id 14.03.0248.002; Thu, 28 Jan 2016 17:05:42 +0800 From: "Sun, Xutao" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 1/4] lib/ether: optimize the 'rte_eth_tunnel_filter_conf' structure Thread-Index: AQHRWZ3VFvDJDgIjSUGXF3ccW+eDRJ8QEIwAgACR2AA= Date: Thu, 28 Jan 2016 09:05:41 +0000 Message-ID: <9AC567D38896294095E6F3228F697FC803528AAC@shsmsx102.ccr.corp.intel.com> References: <1453706722-29427-1-git-send-email-xutao.sun@intel.com> <1453966217-10510-1-git-send-email-xutao.sun@intel.com> <1453966217-10510-2-git-send-email-xutao.sun@intel.com> <5550736.IEy5vK2CRV@xps13> In-Reply-To: <5550736.IEy5vK2CRV@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 1/4] lib/ether: optimize the 'rte_eth_tunnel_filter_conf' structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jan 2016 09:05:51 -0000 Hi, Thomas > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Thursday, January 28, 2016 4:22 PM > To: Sun, Xutao > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/4] lib/ether: optimize the > 'rte_eth_tunnel_filter_conf' structure >=20 > 2016-01-28 15:30, Xutao Sun: > > Change the fields of outer_mac and inner_mac from pointer to struct in > order to keep the code's readability. >=20 > [...] > > - tunnel_filter_conf.outer_mac =3D &res->outer_mac; > > - tunnel_filter_conf.inner_mac =3D &res->inner_mac; > > + (void)rte_memcpy(&tunnel_filter_conf.outer_mac, &res- > >outer_mac, > > + ETHER_ADDR_LEN); > > + (void)rte_memcpy(&tunnel_filter_conf.inner_mac, &res- > >inner_mac, > > + ETHER_ADDR_LEN); >=20 > The (void) casting is useless here. >=20 > > --- a/lib/librte_ether/rte_eth_ctrl.h > > +++ b/lib/librte_ether/rte_eth_ctrl.h > > @@ -280,8 +280,8 @@ enum rte_tunnel_iptype { > > * Tunneling Packet filter configuration. > > */ > > struct rte_eth_tunnel_filter_conf { > > - struct ether_addr *outer_mac; /**< Outer MAC address filter. */ > > - struct ether_addr *inner_mac; /**< Inner MAC address filter. */ > > + struct ether_addr outer_mac; /**< Outer MAC address filter. */ > > + struct ether_addr inner_mac; /**< Inner MAC address filter. */ >=20 > It is an API change. > Please remove the deprecation notice and update the release notes in this > patch (atomically). I will remove the deprecation notice and update the release notes. Is it an ABI change instead of an API change? Thanks, Xutao