From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4EB1FC432 for ; Fri, 19 Feb 2016 03:40:49 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP; 18 Feb 2016 18:40:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,468,1449561600"; d="scan'208";a="50603086" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga004.fm.intel.com with ESMTP; 18 Feb 2016 18:40:48 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 18 Feb 2016 18:40:47 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.172]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.4]) with mapi id 14.03.0248.002; Fri, 19 Feb 2016 10:40:45 +0800 From: "Sun, Xutao" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Thread-Topic: [PATCH v4 4/4] app/test-pmd: test tunnel filter for IP in GRE Thread-Index: AQHRajL1WJNgGIAQpUmz5qV3ShXvUJ8xMfSAgAF3LWA= Date: Fri, 19 Feb 2016 02:40:45 +0000 Message-ID: <9AC567D38896294095E6F3228F697FC80352C0D6@shsmsx102.ccr.corp.intel.com> References: <1453976778-27807-1-git-send-email-xutao.sun@intel.com> <1455789499-15975-1-git-send-email-xutao.sun@intel.com> <1455789499-15975-5-git-send-email-xutao.sun@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWE4NDM2MmMtYjM4Yy00N2RkLTllMDctN2U3YjJiNDMxNDFjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlhYNUdaczQzelVuN0RmTmkrMjdcL1lGQkcyd2l0U1FtRlwvVU5QTEVpTWJYaz0ifQ== x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 4/4] app/test-pmd: test tunnel filter for IP in GRE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2016 02:40:49 -0000 Hi Pablo, > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Thursday, February 18, 2016 8:17 PM > To: Sun, Xutao ; dev@dpdk.org > Cc: Zhang, Helin ; Wu, Jingjing > ; Liu, Jijiang > Subject: RE: [PATCH v4 4/4] app/test-pmd: test tunnel filter for IP in GR= E >=20 > Hi Xutao, >=20 > > -----Original Message----- > > From: Sun, Xutao > > Sent: Thursday, February 18, 2016 9:58 AM > > To: dev@dpdk.org > > Cc: Zhang, Helin; Wu, Jingjing; De Lara Guarch, Pablo; Sun, Xutao; > > Liu, Jijiang > > Subject: [PATCH v4 4/4] app/test-pmd: test tunnel filter for IP in GRE > > > > This patch add some options in tunnel_filter command to test IP in GRE > > packet classification on i40e. > > > > Signed-off-by: Xutao Sun > > Signed-off-by: Jijiang Liu >=20 > Sorry, I see your point now, that the tunnel/filter types are not being > specified in the testpmd documentation. > But actually, I think it would be a good idea to enumerate the different = types > in that document as well (and maybe add a description like "set fwd"). >=20 > Plus, see one extra comment below. >=20 > > --- > > app/test-pmd/cmdline.c | 36 ++++++++++++++++++++++++------------ > > 1 file changed, 24 insertions(+), 12 deletions(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > c707318..6a5cd9f 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -301,12 +301,14 @@ static void cmd_help_long_parsed(void > > *parsed_result, > > " Set the outer VLAN TPID for Packet Filtering on" > > " a port\n\n" > > > > - "tunnel_filter add (port_id) (outer_mac) (inner_mac) > > (ip_addr) " > > - "(inner_vlan) (vxlan|nvgre) (filter_type) (tenant_id) > > (queue_id)\n" > > + "tunnel_filter add (port_id) (outer_mac) (inner_mac) > > (ip_addr)" > > + "(inner_vlan) (vxlan|nvgre|iningre) (filter_type)" >=20 > Should be ipingre? >=20 > > + "(tenant_id) (queue_id)\n" > > " add a tunnel filter of a port.\n\n" > > > > - "tunnel_filter rm (port_id) (outer_mac) (inner_mac) > > (ip_addr) " > > - "(inner_vlan) (vxlan|nvgre) (filter_type) (tenant_id) > > (queue_id)\n" > > + "tunnel_filter rm (port_id) (outer_mac) (inner_mac) > > (ip_addr)" > > + "(inner_vlan) (vxlan|nvgre|ipingre) (filter_type)" > > + "(tenant_id) (queue_id)\n" > > " remove a tunnel filter of a port.\n\n" > > Thanks for your advice, I will update the document. Regards, Xutao