From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Ido Barnea (ibarnea)" <ibarnea@cisco.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] i40e:Fix for wrong publish of card speed (was mixed between 10G and 40G)
Date: Mon, 18 Jul 2016 01:52:10 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F80E16E24C@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <C6BC4AC1-A666-40D2-916B-D03244DD6FE9@cisco.com>
Hi, Barnea
Thanks for the patch. But for 40G link, I think it should be
dev_info->speed_capa = ETH_LINK_SPEED_40G.
Thanks
Jingjing
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ido Barnea (ibarnea)
> Sent: Sunday, July 17, 2016 11:43 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] i40e:Fix for wrong publish of card speed (was
> mixed between 10G and 40G)
>
> Signed-off-by: Ido Barnea <ibarnea@cisco.com>
>
>
> ---
> drivers/net/i40e/i40e_ethdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 3f9f05e..64d60ef 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -2628,10 +2628,10 @@ i40e_dev_info_get(struct rte_eth_dev *dev,
> struct rte_eth_dev_info *dev_info
> if (i40e_is_40G_device(hw->device_id)) /* For XL710
> */
>
> - dev_info->speed_capa = ETH_LINK_SPEED_1G |
> ETH_LINK_SPEED_10G;
> + dev_info->speed_capa = ETH_LINK_SPEED_10G |
> ETH_LINK_SPEED_40G;
> else
> /* For X710 */
> - dev_info->speed_capa = ETH_LINK_SPEED_10G |
> ETH_LINK_SPEED_40G;
> + dev_info->speed_capa = ETH_LINK_SPEED_1G |
> ETH_LINK_SPEED_10G;
> }
> static int
> --
> 2.8.3
next prev parent reply other threads:[~2016-07-18 1:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160717153404.12790-1-ibarnea@cisco.com>
2016-07-17 15:43 ` Ido Barnea (ibarnea)
2016-07-18 1:52 ` Wu, Jingjing [this message]
2016-07-18 4:43 ` Ido Barnea (ibarnea)
2016-07-18 5:09 ` Wu, Jingjing
[not found] ` <20160718095433.31383-1-ibarnea@cisco.com>
2016-07-18 9:56 ` [dpdk-dev] [PATCH v2] " Ido Barnea (ibarnea)
2016-07-20 1:01 ` Wu, Jingjing
2016-07-21 23:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F80E16E24C@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=ibarnea@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).