From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 16BF129D2 for ; Mon, 24 Oct 2016 11:10:06 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP; 24 Oct 2016 02:10:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,541,1473145200"; d="scan'208";a="1049134037" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 24 Oct 2016 02:10:06 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 24 Oct 2016 02:10:05 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 24 Oct 2016 02:10:05 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.139]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.209]) with mapi id 14.03.0248.002; Mon, 24 Oct 2016 17:10:03 +0800 From: "Wu, Jingjing" To: "Guo, Jia" , "Zhang, Helin" CC: "dev@dpdk.org" , "Yigit, Ferruh" Thread-Topic: [PATCH] net/i40e: fix the hash filter invalid calculation in X722 Thread-Index: AQHSKnwjiVkK2+lCC0a4e9n4iyAbl6C3VOxg Date: Mon, 24 Oct 2016 09:10:02 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F80E293A6B@SHSMSX103.ccr.corp.intel.com> References: <1476582005-110811-2-git-send-email-jia.guo@intel.com> <1476931738-44140-1-git-send-email-jia.guo@intel.com> In-Reply-To: <1476931738-44140-1-git-send-email-jia.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTM2YzU0MDktYWI1Zi00OTZmLTg5MTctNWQzZTRkZjg2YTY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IllMZU1OcjQ3dXRiSUNPck53aGJhZjN1OXNEWmNteVBDa3diY0FKSGhzVHM9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix the hash filter invalid calculation in X722 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Oct 2016 09:10:07 -0000 > -----Original Message----- > From: Guo, Jia > Sent: Thursday, October 20, 2016 10:49 AM > To: Zhang, Helin ; Wu, Jingjing > Cc: dev@dpdk.org; Guo, Jia ; Yigit, Ferruh > Subject: [PATCH] net/i40e: fix the hash filter invalid calculation in X72= 2 >=20 > As X722 extracts IPv4 header to Field Vector different with XL710/X710, > need to corresponding to modify the fields of IPv4 header in input set > to map different default Field Vector Table of different NICs. > Signed-off-by: Jeff Guo > --- > v3: > remove the x722 macro > v2: > fix compile error when x722 macro is not defined and simplify > the code to avoid duplication. > --- > drivers/net/i40e/i40e_ethdev.c | 60 +++++++++++++++++++++++++++++++++---= ------ > 1 file changed, 47 insertions(+), 13 deletions(-) >=20 How about change the commit log it like: When verifying the Hash filtering on X722, we found the behavior was not ex= pected. For example, the hash value in descriptor is incorrect. That was because X722 uses different way of hash key word selection compari= ng with X710/XL710. This patch fixes it by setting X722 specific key selection. And few minor comments: If this is not the first patch, please use [PATCH v3] instead of [PATCH]. And the fixes line is missed. Thanks Jingijng