From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Yang, Qiming" <qiming.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix link status change interrupt
Date: Mon, 24 Oct 2016 09:32:52 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F80E293AC1@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1476338840-50003-1-git-send-email-qiming.yang@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
> Sent: Thursday, October 13, 2016 2:07 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>
> Subject: [dpdk-dev] [PATCH 1/2] net/i40e: fix link status change interrupt
>
> Previously, link status interrupt in i40e is achieved by checking
> LINK_STAT_CHANGE_MASK in PFINT_ICR0 register which is provided only
> for diagnostic use. Instead, drivers need to get the link status
> change notification by using LSE (Link Status Event).
>
> This patch enables LSE and calls LSC callback when the event is
> received. This patch also removes the processing on
> LINK_STAT_CHANGE_MASK.
Good description! Thanks!
> Fixes: 5c9222058df7 ("i40e: move to drivers/net/")
Acked-by: Jingjing Wu <jingjing.wu@intel.com> with minor comment:
The commit 5c9222058df7 ("i40e: move to drivers/net/") is just a moving i40e PMD driver code to current folder. It is not exactly that introduced the issue.
Maybe what you are looking for is 4861cde46116 ("i40e: new poll mode driver")
Thanks
Jingjing
prev parent reply other threads:[~2016-10-24 9:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 6:07 Qiming Yang
2016-10-13 6:07 ` [dpdk-dev] [PATCH 2/2] net/i40e: fix VF bonded device link down Qiming Yang
2016-10-24 9:50 ` Wu, Jingjing
2016-10-19 10:56 ` [dpdk-dev] [PATCH 1/2] net/i40e: fix link status change interrupt Ferruh Yigit
2016-10-24 2:21 ` Yang, Qiming
2016-10-24 9:32 ` Wu, Jingjing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F80E293AC1@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).