From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 05747590B for ; Tue, 25 Oct 2016 12:22:13 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP; 25 Oct 2016 03:22:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,545,1473145200"; d="scan'208";a="23336012" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 25 Oct 2016 03:22:13 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 25 Oct 2016 03:22:12 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 25 Oct 2016 03:22:12 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.139]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.209]) with mapi id 14.03.0248.002; Tue, 25 Oct 2016 18:22:10 +0800 From: "Wu, Jingjing" To: "Guo, Jia" , "Zhang, Helin" CC: "dev@dpdk.org" Thread-Topic: [PATCH v4] net/i40e: fix hash filter invalid issue in X722 Thread-Index: AQHSLmkeliM/TRulFEuVvc2xoUTADKC49KiA Date: Tue, 25 Oct 2016 10:22:09 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F80E294671@SHSMSX103.ccr.corp.intel.com> References: <1476931738-44140-1-git-send-email-jia.guo@intel.com> <1477363356-112272-1-git-send-email-jia.guo@intel.com> In-Reply-To: <1477363356-112272-1-git-send-email-jia.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzNhOWFkMWItZDMzOC00YzE4LTkxOGYtZTcxMzhlNDQzYmU2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImRLeGdnd050dHdVYmlNWHNDVUtRb1VPemU2M2NwVGZCblY4bzlFbE8xUVU9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: fix hash filter invalid issue in X722 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Oct 2016 10:22:14 -0000 > -----Original Message----- > From: Guo, Jia > Sent: Tuesday, October 25, 2016 10:43 AM > To: Zhang, Helin ; Wu, Jingjing > Cc: dev@dpdk.org; Guo, Jia > Subject: [PATCH v4] net/i40e: fix hash filter invalid issue in X722 >=20 > When verifying the Hash filtering on X722, we found a problem that > the hash value in descriptor is incorrect. The root caused is X722 > uses different way of hash key word selection comparing with X710/XL710. > This patch fixes it by setting X722 specific key selection. >=20 > Signed-off-by: Jeff Guo If we use default configuration on HW, this issue will not exist. But our software sets the default value through i40e_filter_input_set_init. So I think fix line need to be the commit which introduced input set changing feature. Acked-by: Jingjing Wu with additional line: Fixes: commit 98f055707685 ("i40e: configure input fields for RSS or flow d= irector ") Thanks Jingjing