From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 286DD58EB for ; Wed, 26 Oct 2016 18:34:39 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 26 Oct 2016 09:33:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,551,1473145200"; d="scan'208";a="1059512648" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 26 Oct 2016 09:33:47 -0700 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 26 Oct 2016 09:33:47 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 26 Oct 2016 09:33:46 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.139]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Thu, 27 Oct 2016 00:33:43 +0800 From: "Wu, Jingjing" To: "Iremonger, Bernard" , "dev@dpdk.org" , "Shah, Rahul R" , "Lu, Wenzhuo" , "Dumitrescu, Cristian" Thread-Topic: [PATCH v6 1/2] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV Thread-Index: AQHSLuACgoZrMpD9vUKV+M2zuDgaQqC6zTqg//+KRICAAAtSAIAAjMVw Date: Wed, 26 Oct 2016 16:33:42 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F80E295AF9@SHSMSX103.ccr.corp.intel.com> References: <1476872471-23362-1-git-send-email-bernard.iremonger@intel.com> <1477414269-27156-2-git-send-email-bernard.iremonger@intel.com> <9BB6961774997848B5B42BEC655768F80E2953E7@SHSMSX103.ccr.corp.intel.com> <8CEF83825BEC744B83065625E567D7C21A09E16F@IRSMSX108.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C21A09E1FF@IRSMSX108.ger.corp.intel.com> In-Reply-To: <8CEF83825BEC744B83065625E567D7C21A09E1FF@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmFmOTM0NzAtYzMxNC00YzY3LWE4MGUtNzdjYWJiZmI4YjdmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IitmNlZwZWVsMjMrbXpGcGQ2TVcrblpZUmhKTkVseVNvVkdpTDlGR0E2bUk9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 1/2] net/ixgbe: support multiqueue mode VMDq DCB with SRIOV X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Oct 2016 16:34:41 -0000 > -----Original Message----- > From: Iremonger, Bernard > Sent: Thursday, October 27, 2016 12:10 AM > To: Wu, Jingjing ; dev@dpdk.org; Shah, Rahul R > ; Lu, Wenzhuo ; Dumitrescu,= Cristian > > Subject: RE: [PATCH v6 1/2] net/ixgbe: support multiqueue mode VMDq DCB w= ith SRIOV >=20 > Hi Jingling, >=20 > >=20 > > > > Subject: [PATCH v6 1/2] net/ixgbe: support multiqueue mode VMDq DCB > > > > with SRIOV > > > > > > > > The folowing changes have been made to allow Data Centre Bridge > > > > (DCB) configuration when SRIOV is enabled. > > > > > > > > Modify ixgbe_check_mq_mode function, when SRIOV is enabled, enable > > > > mq_mode ETH_MQ_RX_VMDQ_DCB and ETH_MQ_TX_VMDQ_DCB. > > > > > > > > Modify ixgbe_dcb_tx_hw_config function, replace the struct ixgbe_hw > > > > parameter with a struct rte_eth_dev parameter and handle SRIOV > > > > enabled. > > > > > > > > Modify ixgbe_dev_mq_rx_configure function, when SRIOV is enabled, > > > > enable mq_mode ETH_MQ_RX_VMDQ_DCB. > > > > > > > > Modify ixgbe_configure_dcb function, revise check on > > > > dev->data->nb_rx_queues. > > > > > > > > Signed-off-by: Rahul R Shah > > > > Signed-off-by: Bernard Iremonger > > > > Acked-by: Wenzhuo Lu > > > > --- > > > > drivers/net/ixgbe/ixgbe_ethdev.c | 11 ++++++----- > > > > drivers/net/ixgbe/ixgbe_rxtx.c | 35 ++++++++++++++++++++++------= -- > > --- > > > -- > > > > 2 files changed, 28 insertions(+), 18 deletions(-) > > > > > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > > > index 4ca5747..4d5ce83 100644 > > > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > > > @@ -1977,6 +1977,9 @@ ixgbe_check_mq_mode(struct rte_eth_dev > > > *dev) > > > > /* check multi-queue mode */ > > > > switch (dev_conf->rxmode.mq_mode) { > > > > case ETH_MQ_RX_VMDQ_DCB: > > > > + PMD_INIT_LOG(INFO, "ETH_MQ_RX_VMDQ_DCB > > > mode supported in SRIOV"); > > > > + dev->data->dev_conf.rxmode.mq_mode =3D > > > ETH_MQ_RX_VMDQ_DCB; > > > This line is duplicated, mq_mode is ETH_MQ_RX_VMDQ_DCB already. > > > > The mq_mode is assigned at this point in the other cases. This case is = coded > > in line with the other cases. > > > > > and it's better to check if the nb_queue is valid. > > > The nb_rx_q and nb_tx_q are checked after the switch statements at line 2= 027 with the v6 > patch applied. Thanks, it's fine then. :) > Regards, >=20 > Bernard.