From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id D75A3F63E for ; Wed, 4 Jan 2017 08:48:42 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP; 03 Jan 2017 23:48:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,458,1477983600"; d="scan'208";a="1107719621" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 03 Jan 2017 23:48:41 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 3 Jan 2017 23:48:41 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 3 Jan 2017 23:48:39 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0248.002; Wed, 4 Jan 2017 15:48:39 +0800 From: "Wu, Jingjing" To: "Yang, Qiming" , "Yigit, Ferruh" CC: "dev@dpdk.org" , "Horton, Remy" , Thomas Monjalon Thread-Topic: [PATCH v3 1/4] ethdev: add firmware information get Thread-Index: AQHSZjt0QgBaRD1DpESig5KdyNCLSaEn8I1Q Date: Wed, 4 Jan 2017 07:48:39 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810CC2AF1@SHSMSX103.ccr.corp.intel.com> References: <1481008582-69416-1-git-send-email-qiming.yang@intel.com> <20053497.vNKJpYf1IB@xps13> <10603884.vrshqR2O82@xps13> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add firmware information get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 07:48:43 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Qiming > Sent: Wednesday, January 4, 2017 11:33 AM > To: Yigit, Ferruh > Cc: dev@dpdk.org; Horton, Remy ; Thomas Monjalon > > Subject: Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add firmware information g= et >=20 > Yes, in my opinion it is. And I use this name already exist in the share = code from > ND team. >=20 > -----Original Message----- > From: Yigit, Ferruh > Sent: Tuesday, January 3, 2017 10:49 PM > To: Yang, Qiming > Cc: dev@dpdk.org; Horton, Remy ; Thomas Monjalon > > Subject: Re: [PATCH v3 1/4] ethdev: add firmware information get >=20 > On 1/3/2017 9:05 AM, Yang, Qiming wrote: > > Hi, Ferruh > > Please see the question below. In my opinion, etrack_id is just a name = used to > define the ID of one NIC. > > In kernel version ethtool, it will print this ID in the line of firmwar= e verison. > > I know what is etrack_id mean, but I really don't know why this named > etrack_id. >=20 > Hi Qiming, >=20 > I suggested the API based on fields you already used in your patch. >=20 > So, this API is to get FW version, is etrack_id something that defines (p= art of) > firmware version? >=20 > Thanks, > ferruh >=20 >=20 Different HW may have different version format, so it is better to use stri= ng. And I prefer the API definition in your v2 patch like rte_eth_dev_fwver_get(uint8_t port_id, char *fw_version, int fw_length); Thanks Jingjing