From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 17DE5282 for ; Tue, 7 Feb 2017 16:35:17 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP; 07 Feb 2017 07:35:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,346,1477983600"; d="scan'208";a="62203507" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 07 Feb 2017 07:35:16 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 7 Feb 2017 07:35:16 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 7 Feb 2017 07:35:16 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by shsmsx102.ccr.corp.intel.com ([169.254.2.88]) with mapi id 14.03.0248.002; Tue, 7 Feb 2017 23:35:12 +0800 From: "Wu, Jingjing" To: "Yigit, Ferruh" , Tom Crugnale , "Zhang, Helin" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] net/i40evf: fix reporting of imissed packets Thread-Index: AQHST/2k7kS4D8f8gEaKzR/rXfNix6D8SbIAgGHFffA= Date: Tue, 7 Feb 2017 15:35:12 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810CD5C4B@SHSMSX103.ccr.corp.intel.com> References: <1481055381-14243-1-git-send-email-tcrugnale@sandvine.com> <23ab0bd6-be41-893c-87e6-1ed43897dd2b@intel.com> In-Reply-To: <23ab0bd6-be41-893c-87e6-1ed43897dd2b@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/i40evf: fix reporting of imissed packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Feb 2017 15:35:18 -0000 > -----Original Message----- > From: Yigit, Ferruh > Sent: Thursday, December 8, 2016 2:30 AM > To: Tom Crugnale ; Wu, Jingjing > ; Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/i40evf: fix reporting of imissed p= ackets >=20 > On 12/6/2016 8:16 PM, Tom Crugnale wrote: > > Missed packets on RX were erroneously being assigned to the ierrors > > struct member. Change it to be assigned to imissed. > > > > Fixes: 4861cde4 ("i40e: new poll mode driver") > > > > Signed-off-by: Tom Crugnale > > --- > > v3: > > * Fixed coding style issues > > v2: > > * Fixed line breaks in original patch submission > > --- > > > > drivers/net/i40e/i40e_ethdev_vf.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c > > b/drivers/net/i40e/i40e_ethdev_vf.c > > index aa306d6..90876c8 100644 > > --- a/drivers/net/i40e/i40e_ethdev_vf.c > > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > > @@ -952,7 +952,7 @@ struct rte_i40evf_xstats_name_off { } > > > > static int > > -i40evf_get_statics(struct rte_eth_dev *dev, struct rte_eth_stats > > *stats) > > +i40evf_get_stats(struct rte_eth_dev *dev, struct rte_eth_stats > > +*stats) >=20 > I aware this is simple modification, but if you can, can you please make = this > separate patch? > Stable trees may not interested in internal function name changes but may= want > to get stats counter fix. >=20 > > { > > int ret; > > struct i40e_eth_stats *pstats =3D NULL; @@ -965,7 +965,7 @@ struct > > rte_i40evf_xstats_name_off { > > pstats->rx_broadcast; > > stats->opackets =3D pstats->tx_broadcast + pstats->tx_multicast + > > pstats->tx_unicast; > > - stats->ierrors =3D pstats->rx_discards; > > + stats->imissed =3D pstats->rx_discards; >=20 > so won't VF driver report any rx_error? Yes, i40evf can not get the error stats. I agree with this change. Acked-by: Jingjing Wu