From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 63D761094; Wed, 22 Mar 2017 13:22:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490185354; x=1521721354; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=tKhW2EhRb5SwhuvGttYju1hp1g4lK2pOnhjvUCbVU7E=; b=LnI7IqSb3oYy2gn4vNnIs6lVpLyNRKj6B+oQM67BAwSiT9u/HD3Cm6Vx AlEuijzx3PeHLQlxtaGjgVTjEgtlWg==; Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2017 05:22:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,205,1486454400"; d="scan'208";a="78161774" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 22 Mar 2017 05:22:32 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Mar 2017 05:22:32 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by shsmsx102.ccr.corp.intel.com ([169.254.2.88]) with mapi id 14.03.0248.002; Wed, 22 Mar 2017 20:22:29 +0800 From: "Wu, Jingjing" To: "Guo, Jia" , "Zhang, Helin" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev v2 2/3] app: enable HW CRC strip by default Thread-Index: AQHSoWDFYSNlhmBD/UGFn0UEHiaQdKGgyqfA Date: Wed, 22 Mar 2017 12:22:28 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810CF9851@SHSMSX103.ccr.corp.intel.com> References: <1490003874-37766-1-git-send-email-jia.guo@intel.com> <1490003874-37766-2-git-send-email-jia.guo@intel.com> In-Reply-To: <1490003874-37766-2-git-send-email-jia.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-dev v2 2/3] app: enable HW CRC strip by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 12:22:35 -0000 > -----Original Message----- > From: Guo, Jia > Sent: Monday, March 20, 2017 5:58 PM > To: Zhang, Helin ; Wu, Jingjing > Cc: dev@dpdk.org; Guo, Jia ; stable@dpdk.org > Subject: [dpdk-dev v2 2/3] app: enable HW CRC strip by default >=20 > Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF dr= ivers, > and for most case of kernel driver default enable HW CRC strip, if disabl= e HW > CRC strip in app's rxmode, VF driver will return fail and result the VF l= aunch > failure. So this patch default to enable HW CRC strip to let VF launch su= ccessful. >=20 > Signed-off-by: Jeff Guo > Cc: stable@dpdk.org > --- > app/test-pmd/testpmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > e04e215..f01522c 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -284,7 +284,7 @@ struct rte_eth_rxmode rx_mode =3D { > .hw_vlan_strip =3D 1, /**< VLAN strip enabled. */ > .hw_vlan_extend =3D 0, /**< Extended VLAN disabled. */ > .jumbo_frame =3D 0, /**< Jumbo Frame Support disabled. */ > - .hw_strip_crc =3D 0, /**< CRC stripping by hardware disabled. */ > + .hw_strip_crc =3D 1, /**< CRC stripping by hardware disabled. */ > }; >=20 You change the default hw_strip_crc to 1, then the argument "crc-strip" of testpmd becomes meaningless. It's better to change it too.