From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 9FF3411C5; Wed, 22 Mar 2017 13:24:59 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP; 22 Mar 2017 05:24:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,205,1486454400"; d="scan'208";a="78162356" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 22 Mar 2017 05:24:57 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Mar 2017 05:24:57 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Mar 2017 05:24:57 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Wed, 22 Mar 2017 20:24:53 +0800 From: "Wu, Jingjing" To: "Guo, Jia" , "Zhang, Helin" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev v2 2/3] app: enable HW CRC strip by default Thread-Index: AQHSoWDFYSNlhmBD/UGFn0UEHiaQdKGgyqfAgAABCVA= Date: Wed, 22 Mar 2017 12:24:53 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810CF9869@SHSMSX103.ccr.corp.intel.com> References: <1490003874-37766-1-git-send-email-jia.guo@intel.com> <1490003874-37766-2-git-send-email-jia.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-dev v2 2/3] app: enable HW CRC strip by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 12:25:00 -0000 > -----Original Message----- > From: Wu, Jingjing > Sent: Wednesday, March 22, 2017 8:22 PM > To: Guo, Jia ; Zhang, Helin > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [dpdk-dev v2 2/3] app: enable HW CRC strip by default >=20 >=20 >=20 > > -----Original Message----- > > From: Guo, Jia > > Sent: Monday, March 20, 2017 5:58 PM > > To: Zhang, Helin ; Wu, Jingjing > > > > Cc: dev@dpdk.org; Guo, Jia ; stable@dpdk.org > > Subject: [dpdk-dev v2 2/3] app: enable HW CRC strip by default > > > > Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF > > drivers, and for most case of kernel driver default enable HW CRC > > strip, if disable HW CRC strip in app's rxmode, VF driver will return > > fail and result the VF launch failure. So this patch default to enable = HW CRC > strip to let VF launch successful. > > > > Signed-off-by: Jeff Guo > > Cc: stable@dpdk.org > > --- > > app/test-pmd/testpmd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > > e04e215..f01522c 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -284,7 +284,7 @@ struct rte_eth_rxmode rx_mode =3D { > > .hw_vlan_strip =3D 1, /**< VLAN strip enabled. */ > > .hw_vlan_extend =3D 0, /**< Extended VLAN disabled. */ > > .jumbo_frame =3D 0, /**< Jumbo Frame Support disabled. */ > > - .hw_strip_crc =3D 0, /**< CRC stripping by hardware disabled. */ > > + .hw_strip_crc =3D 1, /**< CRC stripping by hardware disabled. */ > > }; > > > You change the default hw_strip_crc to 1, then the argument "crc-strip" o= f > testpmd becomes meaningless. > It's better to change it too. And the comment should be changed to enabled!