From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 32D6B11C5; Wed, 22 Mar 2017 13:26:53 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 22 Mar 2017 05:26:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,205,1486454400"; d="scan'208";a="78162911" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 22 Mar 2017 05:26:52 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 22 Mar 2017 05:26:51 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Wed, 22 Mar 2017 20:26:48 +0800 From: "Wu, Jingjing" To: "Guo, Jia" , "Zhang, Helin" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev v2 3/3] test: enable HW CRC strip by default Thread-Index: AQHSoWDLia2Stx3RBkyzg4sUzLFHJKGgzCZg Date: Wed, 22 Mar 2017 12:26:47 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810CF987F@SHSMSX103.ccr.corp.intel.com> References: <1490003874-37766-1-git-send-email-jia.guo@intel.com> <1490003874-37766-3-git-send-email-jia.guo@intel.com> In-Reply-To: <1490003874-37766-3-git-send-email-jia.guo@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-dev v2 3/3] test: enable HW CRC strip by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 12:26:53 -0000 > -----Original Message----- > From: Guo, Jia > Sent: Monday, March 20, 2017 5:58 PM > To: Zhang, Helin ; Wu, Jingjing > Cc: dev@dpdk.org; Guo, Jia ; stable@dpdk.org > Subject: [dpdk-dev v2 3/3] test: enable HW CRC strip by default >=20 > Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF dr= ivers, > and for most case of kernel driver default enable HW CRC strip, if disabl= e HW > CRC strip in test app's rxmode, VF driver will return fail and result the= VF launch > failure. So this patch default to enable HW CRC strip to let VF launch su= ccessful. >=20 > Signed-off-by: Jeff Guo > Cc: stable@dpdk.org > --- > test/test-pipeline/init.c | 2 +- > test/test/test_kni.c | 2 +- > test/test/test_link_bonding.c | 4 ++-- > test/test/test_link_bonding_mode4.c | 2 +- > test/test/test_link_bonding_rssconf.c | 4 ++-- > test/test/test_pmd_perf.c | 2 +- > 6 files changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/test/test-pipeline/init.c b/test/test-pipeline/init.c index > aef082f..00dbc27 100644 > --- a/test/test-pipeline/init.c > +++ b/test/test-pipeline/init.c > @@ -105,7 +105,7 @@ static struct rte_eth_conf port_conf =3D { > .hw_ip_checksum =3D 1, /* IP checksum offload enabled */ > .hw_vlan_filter =3D 0, /* VLAN filtering disabled */ > .jumbo_frame =3D 0, /* Jumbo Frame Support disabled */ > - .hw_strip_crc =3D 0, /* CRC stripped by hardware */ > + .hw_strip_crc =3D 1, /* CRC stripped by hardware */ > }, > .rx_adv_conf =3D { > .rss_conf =3D { > diff --git a/test/test/test_kni.c b/test/test/test_kni.c index 309741c..d= b17fdf > 100644 > --- a/test/test/test_kni.c > +++ b/test/test/test_kni.c > @@ -92,7 +92,7 @@ static const struct rte_eth_conf port_conf =3D { > .hw_ip_checksum =3D 0, > .hw_vlan_filter =3D 0, > .jumbo_frame =3D 0, > - .hw_strip_crc =3D 0, > + .hw_strip_crc =3D 1, > }, > .txmode =3D { > .mq_mode =3D ETH_DCB_NONE, > diff --git a/test/test/test_link_bonding.c b/test/test/test_link_bonding.= c index > 3229660..3a1194c 100644 > --- a/test/test/test_link_bonding.c > +++ b/test/test/test_link_bonding.c > @@ -172,7 +172,7 @@ struct rte_eth_rxmode rx_mode =3D { > .hw_vlan_strip =3D 1, /**< VLAN strip enabled. */ > .hw_vlan_extend =3D 0, /**< Extended VLAN disabled. */ > .jumbo_frame =3D 0, /**< Jumbo Frame Support disabled. */ > - .hw_strip_crc =3D 0, /**< CRC stripping by hardware disabled. */ > + .hw_strip_crc =3D 1, /**< CRC stripping by hardware disabled. */ > }; Comment "/**< CRC stripping by hardware disabled. */" need to be Changed too.