From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jingjing.wu@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 7BDAB11C5;
 Wed, 22 Mar 2017 13:29:05 +0100 (CET)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga104.jf.intel.com with ESMTP; 22 Mar 2017 05:29:04 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,205,1486454400"; d="scan'208";a="79798732"
Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206])
 by fmsmga006.fm.intel.com with ESMTP; 22 Mar 2017 05:29:04 -0700
Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by
 FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Wed, 22 Mar 2017 05:29:03 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Wed, 22 Mar 2017 05:29:03 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.20]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.88]) with mapi id 14.03.0248.002;
 Wed, 22 Mar 2017 20:29:00 +0800
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Guo, Jia" <jia.guo@intel.com>, "Zhang, Helin" <helin.zhang@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [dpdk-dev v2 1/3] examples: enable HW CRC strip by default
Thread-Index: AQHSoWDD76GnSaHJlUyWQuMH2nS26KGgwqAggAAKBwA=
Date: Wed, 22 Mar 2017 12:28:59 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F810CF9898@SHSMSX103.ccr.corp.intel.com>
References: <1490003874-37766-1-git-send-email-jia.guo@intel.com> 
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [dpdk-dev v2 1/3] examples: enable HW CRC strip by
	default
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Mar 2017 12:29:06 -0000



> -----Original Message-----
> From: Wu, Jingjing
> Sent: Wednesday, March 22, 2017 7:53 PM
> To: Guo, Jia <jia.guo@intel.com>; Zhang, Helin <helin.zhang@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: RE: [dpdk-dev v2 1/3] examples: enable HW CRC strip by default
>=20
>=20
>=20
> > -----Original Message-----
> > From: Guo, Jia
> > Sent: Monday, March 20, 2017 5:58 PM
> > To: Zhang, Helin <helin.zhang@intel.com>; Wu, Jingjing
> > <jingjing.wu@intel.com>
> > Cc: dev@dpdk.org; Guo, Jia <jia.guo@intel.com>; stable@dpdk.org
> > Subject: [dpdk-dev v2 1/3] examples: enable HW CRC strip by default
> >
> > Since VF has no ability to disable/enable HW CRC strip for non-DPDK PF
> > drivers, and for most case of kernel driver default enable HW CRC
> > strip, if disable HW CRC strip in example app's rxmode, VF driver will
> > return fail and result the VF launch failure. So this patch default to
> > enable HW CRC strip to let VF launch successful.
> >
> > Signed-off-by: Jeff Guo <jia.guo@intel.com>
> > Cc: stable@dpdk.org
>=20
>=20
> Series Acked-by Jingjing Wu <jingjing.wu@intel.com>

Have minor comments on patch [2/3] and [3/3], so the ACK is not for the ser=
ies, just for this patch.