From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id AE75B3B5 for ; Tue, 28 Mar 2017 05:34:04 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP; 27 Mar 2017 20:34:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,235,1486454400"; d="scan'208";a="1147727007" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 27 Mar 2017 20:34:03 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 27 Mar 2017 20:34:03 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 27 Mar 2017 20:34:03 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.253]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.42]) with mapi id 14.03.0248.002; Tue, 28 Mar 2017 11:34:01 +0800 From: "Wu, Jingjing" To: "Yigit, Ferruh" , "Zhang, Qi Z" , "Zhang, Helin" CC: "dev@dpdk.org" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH v2 3/3] app/testpmd: add CL for ptype mapping configure Thread-Index: AQHSmyJafek3yhGQO0ydUOl4kR6MbaGXJ+iAgBKIRCA= Date: Tue, 28 Mar 2017 03:34:00 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810D17B9C@SHSMSX103.ccr.corp.intel.com> References: <20170227045612.48030-1-qi.z.zhang@intel.com> <20170312120845.31666-1-qi.z.zhang@intel.com> <20170312120845.31666-4-qi.z.zhang@intel.com> <18f75650-47bd-e82f-dcc6-c0d4f7000b2a@intel.com> In-Reply-To: <18f75650-47bd-e82f-dcc6-c0d4f7000b2a@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: add CL for ptype mapping configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 03:34:05 -0000 > -----Original Message----- > From: Yigit, Ferruh > Sent: Friday, March 17, 2017 12:27 AM > To: Zhang, Qi Z ; Wu, Jingjing ; > Zhang, Helin > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: Re: [dpdk-dev] [PATCH v2 3/3] app/testpmd: add CL for ptype mapp= ing > configure >=20 > On 3/12/2017 12:08 PM, Qi Zhang wrote: > > Add below command line to configure ptype mapping. > > ptype mapping get . > > ptype mapping replace . > > ptype mapping reset . > > ptype mapping update . > > > > Signed-off-by: Qi Zhang > > --- > > app/test-pmd/cmdline.c | 372 > > +++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 372 insertions(+) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > 43fc636..85f07ba 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -575,6 +575,18 @@ static void cmd_help_long_parsed(void > *parsed_result, > > "E-tag set filter del e-tag-id (value) port (port_id)\n" > > " Delete an E-tag forwarding filter on a port\n\n" > > > > + "ptype mapping get (port_id) (valid_only)\n" > > + " Get ptype mapping on a port\n\n" > > + > > + "ptype mapping replace (port_id) (target) (mask) > (pky_type)\n" > > + " Replace target with the pkt_type in ptype > mapping\n\n" > > + > > + "ptype mapping reset (port_id)\n" > > + " Reset ptype mapping on a port\n\n" > > + > > + "ptype mapping update (port_id) (hw_ptype) > (sw_ptype)\n" > > + " Update a ptype mapping item on a port\n\n" > > + >=20 > This adds new root level "ptype" command, I think it would be nice to get= an Ack > from testpmd maintainers for this. >=20 > testpmd now supports many commands, and I don't know if it is only me, bu= t I > am having hard time to find some commands. Perhaps commands can be > grouped better. Now following groups are used. I think the most confusing one is config or ports. Too many commands are included in it. But it looks like new group is not necessary for Qi's commands. We need extra work to refine it. "Help is available for the following sections:\n\n" " help control : Start and stop forwarding.\n" " help display : Displaying port, stats and config " "information.\n" " help config : Configuration information.\n" " help ports : Configuring ports.\n" " help registers : Reading and setting port registers.\n" " help filters : Filters configuration help.\n" " help all : All of the above sections.\n\n"