From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 613BC3777 for ; Fri, 28 Apr 2017 09:36:34 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Apr 2017 00:36:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,387,1488873600"; d="scan'208";a="93191769" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 28 Apr 2017 00:36:32 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 28 Apr 2017 00:36:32 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 28 Apr 2017 00:36:31 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.117]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.217]) with mapi id 14.03.0319.002; Fri, 28 Apr 2017 15:36:30 +0800 From: "Wu, Jingjing" To: "Pei, Yulong" , "dev@dpdk.org" CC: "Richardson, Bruce" , "thomas@monjalon.net" Thread-Topic: [PATCH] app/testpmd: initalize port_numa and ring_numa Thread-Index: AQHSvMq1UstLsZRq+0KlMc5sH5kYyqHaalbw Date: Fri, 28 Apr 2017 07:36:29 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810D59D9A@SHSMSX103.ccr.corp.intel.com> References: <1493018159-6882-1-git-send-email-yulong.pei@intel.com> In-Reply-To: <1493018159-6882-1-git-send-email-yulong.pei@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: initalize port_numa and ring_numa X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Apr 2017 07:36:34 -0000 > -----Original Message----- > From: Pei, Yulong > Sent: Monday, April 24, 2017 3:16 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Wu, Jingjing > ; thomas@monjalon.net; Pei, Yulong > > Subject: [PATCH] app/testpmd: initalize port_numa and ring_numa >=20 > Previous numa_support =3D 0 by default, it need to add --numa to testpmd > command line to enable numa, so port_numa and ring_numa were initalized a= t > function launch_args_parse(), now testpmd change numa_support =3D 1 as > default, so port_numa and ring_numa also need to initalize by default, > otherwise port->socket_id will be probed to wrong value. >=20 > Signed-off-by: Yulong Pei Thanks! Patch is fine. Could you add Fixes line for this patch? I think should be this commit? commit 999b2ee0fe4511c44462b29566f264e8d9326e1b Author: Bruce Richardson Date: Fri Mar 24 17:00:38 2017 +0000 app/testpmd: enable NUMA support by default There is little reason for NUMA support in testpmd to be off by default= , so enable it, and add in a new commandline parameter to disable it, if tha= t is wanted by users. Signed-off-by: Bruce Richardson