From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: fix number of mbufs in pool
Date: Fri, 28 Apr 2017 09:04:10 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810D5A19E@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20170424123358.5959-2-olivier.matz@6wind.com>
> -----Original Message-----
> From: Olivier Matz [mailto:olivier.matz@6wind.com]
> Sent: Monday, April 24, 2017 8:34 PM
> To: dev@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; stable@dpdk.org
> Subject: [PATCH 2/2] app/testpmd: fix number of mbufs in pool
>
> The number of mbufs in pools is not consistent depending on the options passed
> by the user and the number of ports, especially in numa mode, when the number
> of mbuf is specified by the user.
>
> When the user specifies the number of mbuf (per pool), it should overrides the
> default value.
>
> - before the patch
>
> ./build/app/testpmd -- -i
> <mbuf_pool_socket_0>: n=331456, size=2176, socket=0
> <mbuf_pool_socket_1>: n=331456, size=2176, socket=1
>
> ./build/app/testpmd -- --total-num-mbufs=8000 -i
> <mbuf_pool_socket_0>: n=256000, size=2176, socket=0
> <mbuf_pool_socket_1>: n=256000, size=2176, socket=1
> # BAD, should be n=8000 for each socket
>
> ./build/app/testpmd -- --no-numa -i
> <mbuf_pool_socket_0>: n=331456, size=2176, socket=0
>
> ./build/app/testpmd -- --no-numa --total-num-mbufs=8000 -i
> <mbuf_pool_socket_0>: n=8000, size=2176, socket=0
>
> ./build/app/testpmd --vdev=eth_null0 --vdev=eth_null1 -- -i
> <mbuf_pool_socket_0>: n=331456, size=2176, socket=0
> <mbuf_pool_socket_1>: n=331456, size=2176, socket=1
>
> ./build/app/testpmd --vdev=eth_null0 --vdev=eth_null1 -- \
> --total-num-mbufs=8000 -i
> <mbuf_pool_socket_0>: n=128000, size=2176, socket=0
> <mbuf_pool_socket_1>: n=128000, size=2176, socket=1
> # BAD, should be n=8000 for each socket
>
> ./build/app/testpmd --vdev=eth_null0 --vdev=eth_null1 -- --no-numa -i
> <mbuf_pool_socket_0>: n=331456, size=2176, socket=0
>
> ./build/app/testpmd --vdev=eth_null0 --vdev=eth_null1 -- --no-numa \
> --total-num-mbufs=8000 -i
> <mbuf_pool_socket_0>: n=8000, size=2176, socket=0
>
> - after the patch
>
> ./build/app/testpmd -- -i
> <mbuf_pool_socket_0>: n=331456, size=2176, socket=0
> <mbuf_pool_socket_1>: n=331456, size=2176, socket=1
>
> ./build/app/testpmd -- --total-num-mbufs=8000 -i
> <mbuf_pool_socket_0>: n=8000, size=2176, socket=0
> <mbuf_pool_socket_1>: n=8000, size=2176, socket=1
>
> ./build/app/testpmd -- --no-numa -i
> <mbuf_pool_socket_0>: n=331456, size=2176, socket=0
>
> ./build/app/testpmd -- --no-numa --total-num-mbufs=8000 -i
> <mbuf_pool_socket_0>: n=8000, size=2176, socket=0
>
> ./build/app/testpmd --vdev=eth_null0 --vdev=eth_null1 -- -i
> <mbuf_pool_socket_0>: n=331456, size=2176, socket=0
> <mbuf_pool_socket_1>: n=331456, size=2176, socket=1
>
> ./build/app/testpmd --vdev=eth_null0 --vdev=eth_null1 -- \
> --total-num-mbufs=8000 -i
> <mbuf_pool_socket_0>: n=8000, size=2176, socket=0
> <mbuf_pool_socket_1>: n=8000, size=2176, socket=1
>
> ./build/app/testpmd --vdev=eth_null0 --vdev=eth_null1 -- --no-numa -i
> <mbuf_pool_socket_0>: n=331456, size=2176, socket=0
>
> ./build/app/testpmd --vdev=eth_null0 --vdev=eth_null1 -- --no-numa \
> --total-num-mbufs=8000 -i
> <mbuf_pool_socket_0>: n=8000, size=2176, socket=0
>
> Fixes: b6ea6408fbc7 ("ethdev: store numa_node per device")
>
> CC: stable@dpdk.org
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
next prev parent reply other threads:[~2017-04-28 9:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 12:33 [dpdk-dev] [PATCH 1/2] app/testpmd: fix crash at mbuf pool creation Olivier Matz
2017-04-24 12:33 ` [dpdk-dev] [PATCH 2/2] app/testpmd: fix number of mbufs in pool Olivier Matz
2017-04-28 9:04 ` Wu, Jingjing [this message]
2017-04-28 8:51 ` [dpdk-dev] [PATCH 1/2] app/testpmd: fix crash at mbuf pool creation Wu, Jingjing
2017-05-01 13:18 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810D5A19E@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).