[dpdk-dev] [PATCH] app/testpmd: print all or no events

[dpdk-dev] [PATCH] app/testpmd: print all or no events

[Gaetan Rivet]

Adds the "all" option to the print-event and mask-event parameters. This
option will enable or disable all event notifications from being
displayed.

Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: Jingjing Wu <jingjing.wu@intel.com>
---
 app/test-pmd/parameters.c             | 10 ++++++----
 doc/guides/testpmd_app_ug/run_app.rst | 10 ++++++----
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 23f2fa3..24ed046 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -206,10 +206,10 @@ usage(char* progname)
 	printf("  --no-rmv-interrupt: disable device removal interrupt.\n");
 	printf("  --bitrate-stats=N: set the logical core N to perform "
 		"bit-rate calculation.\n");
-	printf("  --print-event <unknown|intr_lsc|queue_state|intr_reset|vf_mbox|macsec|intr_rmv>: "
-	       "enable print of designated event");
-	printf("  --mask-event <unknown|intr_lsc|queue_state|intr_reset|vf_mbox|macsec|intr_rmv>: "
-	       "disable print of designated event");
+	printf("  --print-event <unknown|intr_lsc|queue_state|intr_reset|vf_mbox|macsec|intr_rmv|all>: "
+	       "enable print of designated event or all of them.");
+	printf("  --mask-event <unknown|intr_lsc|queue_state|intr_reset|vf_mbox|macsec|intr_rmv|all>: "
+	       "disable print of designated event or all of them.");
 }
 
 #ifdef RTE_LIBRTE_CMDLINE
@@ -526,6 +526,8 @@ parse_event_printing_config(const char *optarg, int enable)
 		mask = UINT32_C(1) << RTE_ETH_EVENT_MACSEC;
 	else if (!strcmp(optarg, "intr_rmv"))
 		mask = UINT32_C(1) << RTE_ETH_EVENT_INTR_RMV;
+	else if (!strcmp(optarg, "all"))
+		mask = ~UINT32_C(0);
 	else {
 		fprintf(stderr, "Invalid event: %s\n", optarg);
 		return -1;
diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst
index 98f6d1f..2a43214 100644
--- a/doc/guides/testpmd_app_ug/run_app.rst
+++ b/doc/guides/testpmd_app_ug/run_app.rst
@@ -478,10 +478,12 @@ The commandline options are:
 
     Set the logical core N to perform bitrate calculation.
 
-*   ``--print-event <unknown|intr_lsc|queue_state|intr_reset|vf_mbox|macsec|intr_rmv>``
+*   ``--print-event <unknown|intr_lsc|queue_state|intr_reset|vf_mbox|macsec|intr_rmv|all>``
 
-    Enable printing the occurrence of the designated event.
+    Enable printing the occurrence of the designated event. Using all will
+    enable all of them.
 
-*   ``--mask-event <unknown|intr_lsc|queue_state|intr_reset|vf_mbox|macsec|intr_rmv>``
+*   ``--mask-event <unknown|intr_lsc|queue_state|intr_reset|vf_mbox|macsec|intr_rmv|all>``
 
-    Disable printing the occurrence of the designated event.
+    Disable printing the occurrence of the designated event. Using all will
+    disable all of them.
-- 
2.1.4

Re: [dpdk-dev] [PATCH] app/testpmd: print all or no events

[Wu, Jingjing]

> -----Original Message-----
> From: Gaetan Rivet [mailto:gaetan.rivet@6wind.com]
> Sent: Sunday, May 7, 2017 6:36 AM
> To: dev@dpdk.org
> Cc: Wu, Jingjing <jingjing.wu@intel.com>
> Subject: [PATCH] app/testpmd: print all or no events
> 
> Adds the "all" option to the print-event and mask-event parameters. This option
> will enable or disable all event notifications from being displayed.
> 
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> Cc: Jingjing Wu <jingjing.wu@intel.com>

Thanks for the quick update.

Acked-by: Jingjing Wu <jingjing.wu@intel.com>

Re: [dpdk-dev] [PATCH] app/testpmd: print all or no events

[Thomas Monjalon]

08/05/2017 02:55, Wu, Jingjing:
> From: Gaetan Rivet [mailto:gaetan.rivet@6wind.com]
> > 
> > Adds the "all" option to the print-event and mask-event parameters. This option
> > will enable or disable all event notifications from being displayed.
> > 
> > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> > Cc: Jingjing Wu <jingjing.wu@intel.com>
> 
> Thanks for the quick update.
> 
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>

Applied, thanks