From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 39E3723B for ; Wed, 7 Jun 2017 11:17:38 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jun 2017 02:17:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,310,1493708400"; d="scan'208";a="110174056" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 07 Jun 2017 02:17:38 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 7 Jun 2017 02:17:37 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 7 Jun 2017 02:17:37 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.56]) with mapi id 14.03.0319.002; Wed, 7 Jun 2017 17:17:33 +0800 From: "Wu, Jingjing" To: "De Lara Guarch, Pablo" CC: "dev@dpdk.org" Thread-Topic: [PATCH] app/testpmd: add parameter to start forwarding sending Thread-Index: AQHS1/qQZtcM2k+D5k+rCmEf/aq5wKIZLOiQ Date: Wed, 7 Jun 2017 09:17:33 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810D9CBF6@SHSMSX103.ccr.corp.intel.com> References: <1496007391-182136-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: <1496007391-182136-1-git-send-email-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add parameter to start forwarding sending X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2017 09:17:39 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Monday, May 29, 2017 5:37 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] app/testpmd: add parameter to start forwarding sending >=20 > Add parameter to start forwarding sending first > a burst of packets, which is useful when testing > a loopback connection. >=20 > This was already implemented as an internal command, > but adding it as a parameter is interesting, as it > allows the user to test a loopback connection without > entering in the internal command line. >=20 > Signed-off-by: Pablo de Lara > --- > app/test-pmd/parameters.c | 5 +++++ > app/test-pmd/testpmd.c | 5 +++-- > app/test-pmd/testpmd.h | 1 + > doc/guides/testpmd_app_ug/run_app.rst | 4 ++++ > 4 files changed, 13 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c > index fbe6284..0da4172 100644 > --- a/app/test-pmd/parameters.c > +++ b/app/test-pmd/parameters.c > @@ -89,6 +89,7 @@ usage(char* progname) > "[--cmdline-file=3DFILENAME] " > #endif > "[--help|-h] | [--auto-start|-a] | [" > + "--tx-first" Just consider about the interactive mode. If using command start, will it still call start_packet_forwarding(0)? And if start tx_first, still call start_packet_forwarding(1)? It may cause confused whether this argu "--tx-first" works. If it only works for non-interactive, you'd better to comment it. Thanks Jingjing