From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jingjing.wu@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 64A5537A0
 for <dev@dpdk.org>; Fri, 30 Jun 2017 04:26:45 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by orsmga105.jf.intel.com with ESMTP; 29 Jun 2017 19:26:43 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,284,1496127600"; d="scan'208";a="121090570"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
 by fmsmga006.fm.intel.com with ESMTP; 29 Jun 2017 19:26:43 -0700
Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Thu, 29 Jun 2017 19:26:43 -0700
Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by
 fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Thu, 29 Jun 2017 19:26:42 -0700
Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by
 SHSMSX152.ccr.corp.intel.com ([169.254.6.122]) with mapi id 14.03.0319.002;
 Fri, 30 Jun 2017 10:26:41 +0800
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Hu, Jiayu" <jiayu.hu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "Tan, Jianfeng"
 <jianfeng.tan@intel.com>, "yliu@fridaylinux.org" <yliu@fridaylinux.org>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>, "Bie, Tiwei"
 <tiwei.bie@intel.com>, "Yao, Lei A" <lei.a.yao@intel.com>
Thread-Topic: [PATCH v8 3/3] app/testpmd: enable TCP/IPv4 GRO
Thread-Index: AQHS8MaPiKDqlzn2BEyWN63BZHrGiaI8rrqw
Date: Fri, 30 Jun 2017 02:26:40 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F810DB7172@SHSMSX103.ccr.corp.intel.com>
References: <1498459430-116048-1-git-send-email-jiayu.hu@intel.com>
 <1498733940-117800-1-git-send-email-jiayu.hu@intel.com>
 <1498733940-117800-4-git-send-email-jiayu.hu@intel.com>
In-Reply-To: <1498733940-117800-4-git-send-email-jiayu.hu@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v8 3/3] app/testpmd: enable TCP/IPv4 GRO
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Jun 2017 02:26:45 -0000



> -----Original Message-----
> From: Hu, Jiayu
> Sent: Thursday, June 29, 2017 6:59 PM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Tan, Jianfeng
> <jianfeng.tan@intel.com>; yliu@fridaylinux.org; stephen@networkplumber.or=
g;
> Wu, Jingjing <jingjing.wu@intel.com>; Bie, Tiwei <tiwei.bie@intel.com>; Y=
ao,
> Lei A <lei.a.yao@intel.com>; Hu, Jiayu <jiayu.hu@intel.com>
> Subject: [PATCH v8 3/3] app/testpmd: enable TCP/IPv4 GRO
>=20
> This patch enables TCP/IPv4 GRO library in csum forwarding engine.
> By default, GRO is turned off. Users can use command "gro (on|off) (port_=
id)"
> to enable or disable GRO for a given port. If a port is enabled GRO, all =
TCP/IPv4
> packets received from the port are performed GRO. Besides, users can set =
max
> flow number and packets number per-flow by command "gro set
> (max_flow_num) (max_item_num_per_flow) (port_id)".
>=20
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>

Looks fine from me about those new commands.

Reviewed-by: Jingjing Wu <jingjing.wu@intel.com>

Thanks
Jingjing