From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9B1775689 for ; Fri, 30 Jun 2017 11:07:23 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jun 2017 02:07:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,285,1496127600"; d="scan'208";a="119309083" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 30 Jun 2017 02:07:22 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 30 Jun 2017 02:07:22 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 30 Jun 2017 02:07:21 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Fri, 30 Jun 2017 17:07:20 +0800 From: "Wu, Jingjing" To: "Dai, Wei" , "thomas@monjalon.net" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , "Zhang, Helin" , "Peng, Yuan" CC: "dev@dpdk.org" Thread-Topic: [PATCH v4 4/5] app/testpmd: display PCI address in port info Thread-Index: AQHS8Om3rj7fn0UomECe0am1Am2o8aI9HhFQ Date: Fri, 30 Jun 2017 09:07:19 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810DB7639@SHSMSX103.ccr.corp.intel.com> References: <20170629083404.1271-1-wei.dai@intel.com> <1498748282-69914-1-git-send-email-wei.dai@intel.com> <1498748282-69914-5-git-send-email-wei.dai@intel.com> In-Reply-To: <1498748282-69914-5-git-send-email-wei.dai@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 4/5] app/testpmd: display PCI address in port info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2017 09:07:24 -0000 > -----Original Message----- > From: Dai, Wei > Sent: Thursday, June 29, 2017 10:58 PM > To: thomas@monjalon.net; Lu, Wenzhuo ; Ananyev, Kon= stantin > ; Zhang, Helin ; Wu,= Jingjing > ; yuan.pntel.com > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH v4 4/5] app/testpmd: display PCI address in port info >=20 > Add the PCI address when running "show port info port_id". >=20 > Signed-off-by: Wei Dai > --- > app/test-pmd/config.c | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index b0b340e..c2d5c03 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -438,6 +438,11 @@ port_infos_display(portid_t port_id) > rte_eth_dev_info_get(port_id, &dev_info); > printf("\n%s Infos for port %-2d %s\n", > info_border, port_id, info_border); > + printf("PCI Address: " PCI_PRI_FMT "\n", > + dev_info.pci_dev->addr.domain, > + dev_info.pci_dev->addr.bus, > + dev_info.pci_dev->addr.devid, > + dev_info.pci_dev->addr.function); > rte_eth_macaddr_get(port_id, &mac_addr); > print_ethaddr("MAC address: ", &mac_addr); > printf("\nDriver name: %s", dev_info.driver_name); > -- > 2.7.4 The field pci_dev will probably be removed. Yulong already submit a patch like this and rejected. http://www.dpdk.org/dev/patchwork/patch/23899/ So, you can add more info when the Bus refine work is done. You can drop this change from your patch set. Thanks Jingjing