From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2F3611B53 for ; Sat, 9 Sep 2017 05:21:36 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Sep 2017 20:21:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,364,1500966000"; d="scan'208";a="133436091" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 08 Sep 2017 20:21:35 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 8 Sep 2017 20:21:35 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 8 Sep 2017 20:21:34 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.219]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.98]) with mapi id 14.03.0319.002; Sat, 9 Sep 2017 11:21:33 +0800 From: "Wu, Jingjing" To: Zang MingJie , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping Thread-Index: AQHTHN0QfX7/tSscBkuMMcgjvoCSV6Kr+nQw Date: Sat, 9 Sep 2017 03:21:32 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810E43C98@SHSMSX103.ccr.corp.intel.com> References: <20170824132909.31253-1-zealot0630@gmail.com> In-Reply-To: <20170824132909.31253-1-zealot0630@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGE1NTQwM2ItNzM2MS00OTMzLWExZmUtZWNmN2I4YzQyMzg2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ilc3aXhRWjBEbmFCUFJacU5nRVc1anRHQlphdm92ZFpTMVJGWjFcL2FuR0lFPSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Sep 2017 03:21:37 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zang MingJie > Sent: Thursday, August 24, 2017 9:29 PM > To: dev@dpdk.org > Cc: Zang MingJie > Subject: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping >=20 > Function i40e_vsi_config_vlan_stripping doesn't strip vlan tag for vf. > The patch should fix the problem. >=20 > Signed-off-by: Zang MingJie > --- > drivers/net/i40e/i40e_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 5f26e24a3..cd48ebbc1 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -5189,7 +5189,7 @@ i40e_vsi_config_vlan_stripping(struct i40e_vsi *vsi= , bool on) > } >=20 > if (on) > - vlan_flags =3D I40E_AQ_VSI_PVLAN_EMOD_STR_BOTH; > + vlan_flags =3D I40E_AQ_VSI_PVLAN_EMOD_STR; > else > vlan_flags =3D I40E_AQ_VSI_PVLAN_EMOD_NOTHING; > vsi->info.valid_sections =3D How did you find this issue? In our cases, it works well. And according to the datasheet, the EMOD_STR meaning Hide vlan but not stri= p them to descriptor. Thanks Jingjing