* [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping
@ 2017-08-24 13:29 Zang MingJie
2017-09-09 3:21 ` Wu, Jingjing
0 siblings, 1 reply; 3+ messages in thread
From: Zang MingJie @ 2017-08-24 13:29 UTC (permalink / raw)
To: dev; +Cc: Zang MingJie
Function i40e_vsi_config_vlan_stripping doesn't strip vlan tag for vf.
The patch should fix the problem.
Signed-off-by: Zang MingJie <zealot0630@gmail.com>
---
drivers/net/i40e/i40e_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 5f26e24a3..cd48ebbc1 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -5189,7 +5189,7 @@ i40e_vsi_config_vlan_stripping(struct i40e_vsi *vsi, bool on)
}
if (on)
- vlan_flags = I40E_AQ_VSI_PVLAN_EMOD_STR_BOTH;
+ vlan_flags = I40E_AQ_VSI_PVLAN_EMOD_STR;
else
vlan_flags = I40E_AQ_VSI_PVLAN_EMOD_NOTHING;
vsi->info.valid_sections =
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping
2017-08-24 13:29 [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping Zang MingJie
@ 2017-09-09 3:21 ` Wu, Jingjing
2017-10-11 5:12 ` Wu, Jingjing
0 siblings, 1 reply; 3+ messages in thread
From: Wu, Jingjing @ 2017-09-09 3:21 UTC (permalink / raw)
To: Zang MingJie, dev
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zang MingJie
> Sent: Thursday, August 24, 2017 9:29 PM
> To: dev@dpdk.org
> Cc: Zang MingJie <zealot0630@gmail.com>
> Subject: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping
>
> Function i40e_vsi_config_vlan_stripping doesn't strip vlan tag for vf.
> The patch should fix the problem.
>
> Signed-off-by: Zang MingJie <zealot0630@gmail.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 5f26e24a3..cd48ebbc1 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -5189,7 +5189,7 @@ i40e_vsi_config_vlan_stripping(struct i40e_vsi *vsi, bool on)
> }
>
> if (on)
> - vlan_flags = I40E_AQ_VSI_PVLAN_EMOD_STR_BOTH;
> + vlan_flags = I40E_AQ_VSI_PVLAN_EMOD_STR;
> else
> vlan_flags = I40E_AQ_VSI_PVLAN_EMOD_NOTHING;
> vsi->info.valid_sections =
How did you find this issue? In our cases, it works well.
And according to the datasheet, the EMOD_STR meaning Hide vlan but not strip them to descriptor.
Thanks
Jingjing
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping
2017-09-09 3:21 ` Wu, Jingjing
@ 2017-10-11 5:12 ` Wu, Jingjing
0 siblings, 0 replies; 3+ messages in thread
From: Wu, Jingjing @ 2017-10-11 5:12 UTC (permalink / raw)
To: Wu, Jingjing, Zang MingJie, dev
NACK it.
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wu, Jingjing
> Sent: Saturday, September 9, 2017 11:22 AM
> To: Zang MingJie <zealot0630@gmail.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping
>
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zang MingJie
> > Sent: Thursday, August 24, 2017 9:29 PM
> > To: dev@dpdk.org
> > Cc: Zang MingJie <zealot0630@gmail.com>
> > Subject: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping
> >
> > Function i40e_vsi_config_vlan_stripping doesn't strip vlan tag for vf.
> > The patch should fix the problem.
> >
> > Signed-off-by: Zang MingJie <zealot0630@gmail.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_ethdev.c
> > b/drivers/net/i40e/i40e_ethdev.c index 5f26e24a3..cd48ebbc1 100644
> > --- a/drivers/net/i40e/i40e_ethdev.c
> > +++ b/drivers/net/i40e/i40e_ethdev.c
> > @@ -5189,7 +5189,7 @@ i40e_vsi_config_vlan_stripping(struct i40e_vsi *vsi,
> bool on)
> > }
> >
> > if (on)
> > - vlan_flags = I40E_AQ_VSI_PVLAN_EMOD_STR_BOTH;
> > + vlan_flags = I40E_AQ_VSI_PVLAN_EMOD_STR;
> > else
> > vlan_flags = I40E_AQ_VSI_PVLAN_EMOD_NOTHING;
> > vsi->info.valid_sections =
>
> How did you find this issue? In our cases, it works well.
> And according to the datasheet, the EMOD_STR meaning Hide vlan but not
> strip them to descriptor.
>
> Thanks
> Jingjing
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-11 5:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-24 13:29 [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping Zang MingJie
2017-09-09 3:21 ` Wu, Jingjing
2017-10-11 5:12 ` Wu, Jingjing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).