From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 038B25599 for ; Tue, 26 Sep 2017 15:56:35 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP; 26 Sep 2017 06:56:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,441,1500966000"; d="scan'208";a="1175938651" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 26 Sep 2017 06:56:33 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 26 Sep 2017 06:56:32 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 26 Sep 2017 06:56:31 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Tue, 26 Sep 2017 21:56:29 +0800 From: "Wu, Jingjing" To: Yong Wang CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix uninitialized variable Thread-Index: AQHTM3TFvpdqiauq7UyYrdHdg2Sj/qLHNvlQ Date: Tue, 26 Sep 2017 13:56:29 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810E801DC@SHSMSX103.ccr.corp.intel.com> References: <1506064695-31920-1-git-send-email-wang.yong19@zte.com.cn> In-Reply-To: <1506064695-31920-1-git-send-email-wang.yong19@zte.com.cn> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjRmZTNlNmMtMjBiYi00N2JhLWE2ZWMtN2JjNTRhZDFkOWRiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkV2RXJMNjVzeThkQUZPR3hvMzBrS1FUblwvMmFGaFdjUlArR2EyWHNcL1J6WT0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix uninitialized variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Sep 2017 13:56:36 -0000 > -----Original Message----- > From: Yong Wang [mailto:wang.yong19@zte.com.cn] > Sent: Friday, September 22, 2017 3:18 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Yong Wang > Subject: [PATCH] net/i40e: fix uninitialized variable >=20 > In func i40evf_dev_link_update(), "new_link.link_autoneg" is used in > func call i40evf_dev_atomic_write_link_status(), but is uninitialized. >=20 > Signed-off-by: Yong Wang > --- > drivers/net/i40e/i40e_ethdev_vf.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_et= hdev_vf.c > index 73c315a..3c0f436 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -2218,6 +2218,7 @@ static int eth_i40evf_pci_remove(struct rte_pci_dev= ice > *pci_dev) > new_link.link_duplex =3D ETH_LINK_FULL_DUPLEX; > new_link.link_status =3D vf->link_up ? ETH_LINK_UP : > ETH_LINK_DOWN; > + new_link.link_autoneg =3D ETH_LINK_AUTONEG; >=20 It is right, but it will be better to set it by checking (dev->data->dev_co= nf.link_speeds & ETH_LINK_SPEED_FIXED)? And if your patch is fixing some issue, please add fixes line in your patch= , and Cc: stable@dpdk.org Thanks Jingjing