From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 3E2DB1B194; Fri, 29 Sep 2017 16:25:31 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP; 29 Sep 2017 07:25:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,452,1500966000"; d="scan'208";a="133574142" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 29 Sep 2017 07:25:30 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 29 Sep 2017 07:25:30 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 29 Sep 2017 07:25:30 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002; Fri, 29 Sep 2017 22:25:28 +0800 From: "Wu, Jingjing" To: "Jastrzebski, MichalX K" CC: "dev@dpdk.org" , "Jain, Deepak K" , "Kulasek, TomaszX" , "Chilikin, Andrey" , "stable@dpdk.org" Thread-Topic: [PATCH] app/testpmd: fix runtime dead code Thread-Index: AQHTOSKoiA/GzNFRYU+gnfdMrqGMJqLL6pYA Date: Fri, 29 Sep 2017 14:25:28 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810E83FB9@SHSMSX103.ccr.corp.intel.com> References: <20170929125656.33164-1-michalx.k.jastrzebski@intel.com> In-Reply-To: <20170929125656.33164-1-michalx.k.jastrzebski@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjU5ZWIzZjYtNTUyYi00M2ZkLWJkMjItMmNlY2UwMzU5YjFiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkYxUWszcThzQU9rZU5lM1NLZkx0OTRcLzZEbVFKaEhYTzlcL3RCdHdBMHhqQT0ifQ== x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix runtime dead code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2017 14:25:32 -0000 > -----Original Message----- > From: Jastrzebski, MichalX K > Sent: Friday, September 29, 2017 8:57 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Jain, Deepak K ; Kulasek, Toma= szX > ; Chilikin, Andrey = ; > stable@dpdk.org > Subject: [PATCH] app/testpmd: fix runtime dead code >=20 > From: Tomasz Kulasek >=20 > Coverity reports DEADCODE, as assumes that RTE_LIBRTE_I40E_PMD > is defined and function compiles entirely. > The fix is about to place printf function into #else branch > of conditional compilation, since it is known at compile > time if i40e is supported. No need to check it at runtime. >=20 > Coverity issue: 158646 > Fixes: 37a56cce7b8e ("app/testpmd: enable DDP get info feature") > Cc: andrey.chilikin@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Tomasz Kulasek Acked-by: Jingjing Wu