From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 21F6D1B259 for ; Tue, 10 Oct 2017 09:57:59 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP; 10 Oct 2017 00:57:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,503,1500966000"; d="scan'208";a="144729024" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 10 Oct 2017 00:57:58 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Oct 2017 00:57:58 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Oct 2017 00:57:58 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.98]) with mapi id 14.03.0319.002; Tue, 10 Oct 2017 15:56:59 +0800 From: "Wu, Jingjing" To: 'Stephen Hemminger' , "Li, Xiaoyun" CC: "'dev@dpdk.org'" Thread-Topic: [dpdk-dev] [PATCH v2] examples/l3fwd: pass flow arguments when start app Thread-Index: AQHTOZAH6oOGuT1KC0KOnT34Bho7EqLOuvMAgAY6boCAB83KIA== Date: Tue, 10 Oct 2017 07:57:00 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810E8FAF3@SHSMSX103.ccr.corp.intel.com> References: <1506565888-194214-1-git-send-email-xiaoyun.li@intel.com> <1506736748-50515-1-git-send-email-xiaoyun.li@intel.com> <20171001102410.3c928ad5@xeon-e3> <9BB6961774997848B5B42BEC655768F810E8A04E@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810E8A04E@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: pass flow arguments when start app X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 07:58:01 -0000 > -----Original Message----- > From: Wu, Jingjing > Sent: Thursday, October 5, 2017 4:36 PM > To: Stephen Hemminger ; Li, Xiaoyun > > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] examples/l3fwd: pass flow arguments wh= en > start app >=20 >=20 >=20 > > -----Original Message----- > > From: Stephen Hemminger [mailto:stephen@networkplumber.org] > > Sent: Monday, October 2, 2017 1:24 AM > > To: Li, Xiaoyun > > Cc: Wu, Jingjing ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: pass flow arguments > > when start app > > > > On Sat, 30 Sep 2017 09:59:08 +0800 > > Xiaoyun Li wrote: > > > > > To make the performance can be tuning on different NICs or > > > platforms. We need to make the number of descriptors and Rx/TX > > > threshold as arguments when starting l3fwd application. > > > > > > Signed-off-by: Xiaoyun Li > > > > Not sure about this. The point of l3fwd is to make it as simple an > > application as possible to help users. > > > > Given that drivers can now supply default values for thresholds, I > > think the l3fwd sample should get rid of all the special descriptor > > values it is setting. Then if the values are not right for best > > performance that should be pushed back to the driver writer to fix. >=20 > But now what the driver using are the arguments passed from l3fwd > application, such as RTE_TEST_RX_DESC_DEFAULT. About the threshold, I gue= ss > it is already done by driver to use default value. For number of descript= ors, any > ideas? Diver to provide a suggestion one? >=20 And additionally, even driver provides a suggestion value for descriptors o= r threshold, on different platform, the performance result also varies. So I think xiaoy= un's change to pass those are arguments makes sense. Thanks Jingjing