From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 055BB2BE1 for ; Wed, 11 Oct 2017 07:12:53 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2017 22:12:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,359,1503385200"; d="scan'208";a="161281317" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 10 Oct 2017 22:12:33 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 10 Oct 2017 22:12:33 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.98]) with mapi id 14.03.0319.002; Wed, 11 Oct 2017 13:12:30 +0800 From: "Wu, Jingjing" To: "Wu, Jingjing" , Zang MingJie , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping Thread-Index: AQHTHN0QfX7/tSscBkuMMcgjvoCSV6Kr+nQwgDJq2wA= Date: Wed, 11 Oct 2017 05:12:30 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810E91060@SHSMSX103.ccr.corp.intel.com> References: <20170824132909.31253-1-zealot0630@gmail.com> <9BB6961774997848B5B42BEC655768F810E43C98@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810E43C98@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2017 05:12:54 -0000 NACK it. > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wu, Jingjing > Sent: Saturday, September 9, 2017 11:22 AM > To: Zang MingJie ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zang MingJie > > Sent: Thursday, August 24, 2017 9:29 PM > > To: dev@dpdk.org > > Cc: Zang MingJie > > Subject: [dpdk-dev] [PATCH] net/i40e: fix vsi vlan stripping > > > > Function i40e_vsi_config_vlan_stripping doesn't strip vlan tag for vf. > > The patch should fix the problem. > > > > Signed-off-by: Zang MingJie > > --- > > drivers/net/i40e/i40e_ethdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > b/drivers/net/i40e/i40e_ethdev.c index 5f26e24a3..cd48ebbc1 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -5189,7 +5189,7 @@ i40e_vsi_config_vlan_stripping(struct i40e_vsi *v= si, > bool on) > > } > > > > if (on) > > - vlan_flags =3D I40E_AQ_VSI_PVLAN_EMOD_STR_BOTH; > > + vlan_flags =3D I40E_AQ_VSI_PVLAN_EMOD_STR; > > else > > vlan_flags =3D I40E_AQ_VSI_PVLAN_EMOD_NOTHING; > > vsi->info.valid_sections =3D >=20 > How did you find this issue? In our cases, it works well. > And according to the datasheet, the EMOD_STR meaning Hide vlan but not > strip them to descriptor. >=20 > Thanks > Jingjing