From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 649D71B620 for ; Mon, 16 Oct 2017 12:18:10 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP; 16 Oct 2017 03:18:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,386,1503385200"; d="scan'208";a="323720764" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 16 Oct 2017 03:18:08 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 16 Oct 2017 03:18:08 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 16 Oct 2017 03:18:08 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Mon, 16 Oct 2017 18:18:06 +0800 From: "Wu, Jingjing" To: "Singh, Jasvinder" , "dev@dpdk.org" CC: "Dumitrescu, Cristian" , "Pei, Yulong" Thread-Topic: [PATCH v9 3/3] app/test-pmd: add CLI for TM nodes and hierarchy commit Thread-Index: AQHTRNRWVw5ZYSku9keu6tRY8KFu0KLmQBfg Date: Mon, 16 Oct 2017 10:18:05 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810E96EBB@SHSMSX103.ccr.corp.intel.com> References: <20171013170000.26118-1-jasvinder.singh@intel.com> <20171014102025.101462-1-jasvinder.singh@intel.com> <20171014102025.101462-3-jasvinder.singh@intel.com> In-Reply-To: <20171014102025.101462-3-jasvinder.singh@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v9 3/3] app/test-pmd: add CLI for TM nodes and hierarchy commit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 10:18:11 -0000 > -----Original Message----- > From: Singh, Jasvinder > Sent: Saturday, October 14, 2017 6:20 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Wu, Jingjing > ; Pei, Yulong > Subject: [PATCH v9 3/3] app/test-pmd: add CLI for TM nodes and hierarchy > commit >=20 > Add following CLIs in testpmd application for device traffic management; > - commands to add TM hierarchy nodes (leaf and nonleaf). > - command for runtime update of node weight. > - command to commit the TM hierarchy >=20 > Signed-off-by: Jasvinder Singh > Acked-by: Cristian Dumitrescu > --- > v8 change: > - change command defintion for leaf and nonleaf nodes (mulitple shared > shapers can be specified) > - pre-allocate memory for shared shaper ids array in nonleaf and leaf > node add cli. > - change clean_on_fail to string type in hierarchy commit cli >=20 > v7 change: > - fix the help info on leaf node add >=20 > v5 change: > - add shaper related parameters to leaf node add command >=20 > v4 change: > - remove softnic specific checks to make it generic for the devices >=20 > app/test-pmd/cmdline.c | 27 ++ > app/test-pmd/cmdline_tm.c | 651 > ++++++++++++++++++++++++++++++++++++++++++++++ > app/test-pmd/cmdline_tm.h | 5 + > 3 files changed, 683 insertions(+) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > 4259012..094cbb8 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -720,6 +720,28 @@ static void cmd_help_long_parsed(void > *parsed_result, > "del port tm node wred profile (port_id) > (wred_profile_id)\n" > " Delete port tm node wred profile.\n\n" >=20 > + "add port tm nonleaf node (port_id) (node_id) > (parent_node_id)" > + " (priority) (weight) (level_id) (shaper_profile_id)" > + " (n_sp_priorities) (stats_mask) (n_shared_shapers)" > + " [(shared_shaper_id_0) (shared_shaper_id_1)...]\n" > + " Add port tm nonleaf node.\n\n" > + > + "add port tm leaf node (port_id) (node_id) > (parent_node_id)" > + " (priority) (weight) (level_id) (shaper_profile_id)" > + " (cman_mode) (wred_profile_id) (stats_mask) > (n_shared_shapers)" > + " [(shared_shaper_id_0) (shared_shaper_id_1)...]\n" > + " Add port tm leaf node.\n\n" > + > + "del port tm node (port_id) (node_id)\n" > + " Delete port tm node.\n\n" > + > + "set port tm node parent (port_id) (node_id) > (parent_node_id)" > + " (priority) (weight)\n" > + " Set port tm node parent.\n\n" > + > + "port tm hierarchy commit (port_id) (clean_on_fail)\n" > + " Commit tm hierarchy.\n\n" > + > , list_pkt_forwarding_modes() > ); > } > @@ -15650,6 +15672,11 @@ cmdline_parse_ctx_t main_ctx[] =3D { > (cmdline_parse_inst_t *)&cmd_add_port_tm_node_wred_profile, > (cmdline_parse_inst_t *)&cmd_del_port_tm_node_wred_profile, > (cmdline_parse_inst_t *)&cmd_set_port_tm_node_shaper_profile, > + (cmdline_parse_inst_t *)&cmd_add_port_tm_nonleaf_node, > + (cmdline_parse_inst_t *)&cmd_add_port_tm_leaf_node, > + (cmdline_parse_inst_t *)&cmd_del_port_tm_node, > + (cmdline_parse_inst_t *)&cmd_set_port_tm_node_parent, > + (cmdline_parse_inst_t *)&cmd_port_tm_hierarchy_commit, > NULL, > }; >=20 > diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c index > 38048ae..002209c 100644 > --- a/app/test-pmd/cmdline_tm.c > +++ b/app/test-pmd/cmdline_tm.c > @@ -42,6 +42,17 @@ > #include "testpmd.h" > #include "cmdline_tm.h" >=20 > +#define PARSE_DELIMITER " \f\n\r\t\v" > +#define MAX_NUM_SHARED_SHAPERS 256 > + > +#define skip_white_spaces(pos) \ > +({ \ > + __typeof__(pos) _p =3D (pos); \ > + for ( ; isspace(*_p); _p++) \ > + ; \ > + _p; \ > +}) > + > /** Display TM Error Message */ > static void > print_err_msg(struct rte_tm_error *error) @@ -118,6 +129,100 @@ > print_err_msg(struct rte_tm_error *error) > error->type); > } >=20 > +static int > +read_uint64(uint64_t *value, const char *p) { > + char *next; > + uint64_t val; > + > + p =3D skip_white_spaces(p); > + if (!isdigit(*p)) > + return -EINVAL; > + > + val =3D strtoul(p, &next, 10); > + if (p =3D=3D next) > + return -EINVAL; > + > + p =3D next; > + switch (*p) { > + case 'T': > + val *=3D 1024ULL; > + /* fall through */ > + case 'G': > + val *=3D 1024ULL; > + /* fall through */ > + case 'M': > + val *=3D 1024ULL; > + /* fall through */ > + case 'k': > + case 'K': > + val *=3D 1024ULL; > + p++; > + break; > + } > + > + p =3D skip_white_spaces(p); > + if (*p !=3D '\0') > + return -EINVAL; > + > + *value =3D val; > + return 0; > +} > + > +static int > +read_uint32(uint32_t *value, const char *p) { > + uint64_t val =3D 0; > + int ret =3D read_uint64(&val, p); > + > + if (ret < 0) > + return ret; > + > + if (val > UINT32_MAX) > + return -ERANGE; > + > + *value =3D val; > + return 0; > +} > + > +static int > +parse_multi_ss_id_str(char *s_str, uint32_t *n_ssp, uint32_t > +shaper_id[]) { > + uint32_t n_shared_shapers =3D 0, i =3D 0; > + char *token; > + > + /* First token: num of shared shapers */ > + token =3D strtok_r(s_str, PARSE_DELIMITER, &s_str); > + if (token =3D=3D NULL) > + return -1; > + > + if (read_uint32(&n_shared_shapers, token)) > + return -1; > + > + /* Check: num of shared shaper */ > + if (n_shared_shapers >=3D MAX_NUM_SHARED_SHAPERS) { > + printf(" Number of shared shapers exceed the max (error)\n"); > + return -1; > + } > + > + /* Parse shared shaper ids */ > + while (1) { > + token =3D strtok_r(s_str, PARSE_DELIMITER, &s_str); > + if ((token !=3D NULL && n_shared_shapers =3D=3D 0) || > + (token =3D=3D NULL && i < n_shared_shapers)) > + return -1; > + > + if (token =3D=3D NULL) > + break; > + > + if (read_uint32(&shaper_id[i], token)) > + return -1; > + i++; > + } > + *n_ssp =3D n_shared_shapers; > + > + return 0; > +} Thanks for the change, can those be done by rte_strsplit? > /* *** Port TM Capability *** */ > struct cmd_show_port_tm_cap_result { > cmdline_fixed_string_t show; > @@ -1410,3 +1515,549 @@ cmdline_parse_inst_t > cmd_set_port_tm_node_shaper_profile =3D { > NULL, > }, > }; > + > +/* *** Add Port TM nonleaf node *** */ > +struct cmd_add_port_tm_nonleaf_node_result { > + cmdline_fixed_string_t add; > + cmdline_fixed_string_t port; > + cmdline_fixed_string_t tm; > + cmdline_fixed_string_t nonleaf; > + cmdline_fixed_string_t node; > + uint16_t port_id; > + uint32_t node_id; > + int32_t parent_node_id; > + uint32_t priority; > + uint32_t weight; > + uint32_t level_id; > + uint32_t shaper_profile_id; > + uint32_t n_sp_priorities; > + uint64_t stats_mask; > + cmdline_multi_string_t multi_shared_shaper_id; }; > + > +cmdline_parse_token_string_t cmd_add_port_tm_nonleaf_node_add =3D > + TOKEN_STRING_INITIALIZER( > + struct cmd_add_port_tm_nonleaf_node_result, add, "add"); > +cmdline_parse_token_string_t cmd_add_port_tm_nonleaf_node_port =3D > + TOKEN_STRING_INITIALIZER( > + struct cmd_add_port_tm_nonleaf_node_result, port, "port"); > +cmdline_parse_token_string_t cmd_add_port_tm_nonleaf_node_tm =3D > + TOKEN_STRING_INITIALIZER( > + struct cmd_add_port_tm_nonleaf_node_result, tm, "tm"); > +cmdline_parse_token_string_t cmd_add_port_tm_nonleaf_node_nonleaf =3D > + TOKEN_STRING_INITIALIZER( > + struct cmd_add_port_tm_nonleaf_node_result, nonleaf, > "nonleaf"); > +cmdline_parse_token_string_t cmd_add_port_tm_nonleaf_node_node =3D > + TOKEN_STRING_INITIALIZER( > + struct cmd_add_port_tm_nonleaf_node_result, node, "node"); > +cmdline_parse_token_num_t cmd_add_port_tm_nonleaf_node_port_id =3D > + TOKEN_NUM_INITIALIZER( > + struct cmd_add_port_tm_nonleaf_node_result, > + port_id, UINT16); > +cmdline_parse_token_num_t cmd_add_port_tm_nonleaf_node_node_id =3D > + TOKEN_NUM_INITIALIZER(struct > cmd_add_port_tm_nonleaf_node_result, > + node_id, UINT32); > +cmdline_parse_token_num_t > cmd_add_port_tm_nonleaf_node_parent_node_id =3D > + TOKEN_NUM_INITIALIZER(struct > cmd_add_port_tm_nonleaf_node_result, > + parent_node_id, INT32); > +cmdline_parse_token_num_t cmd_add_port_tm_nonleaf_node_priority =3D > + TOKEN_NUM_INITIALIZER(struct > cmd_add_port_tm_nonleaf_node_result, > + priority, UINT32); > +cmdline_parse_token_num_t cmd_add_port_tm_nonleaf_node_weight =3D > + TOKEN_NUM_INITIALIZER(struct > cmd_add_port_tm_nonleaf_node_result, > + weight, UINT32); > +cmdline_parse_token_num_t cmd_add_port_tm_nonleaf_node_level_id =3D > + TOKEN_NUM_INITIALIZER(struct > cmd_add_port_tm_nonleaf_node_result, > + level_id, UINT32); > +cmdline_parse_token_num_t > cmd_add_port_tm_nonleaf_node_shaper_profile_id =3D > + TOKEN_NUM_INITIALIZER(struct > cmd_add_port_tm_nonleaf_node_result, > + shaper_profile_id, UINT32); > +cmdline_parse_token_num_t > cmd_add_port_tm_nonleaf_node_n_sp_priorities =3D > + TOKEN_NUM_INITIALIZER(struct > cmd_add_port_tm_nonleaf_node_result, > + n_sp_priorities, UINT32); > +cmdline_parse_token_num_t cmd_add_port_tm_nonleaf_node_stats_mask =3D > + TOKEN_NUM_INITIALIZER(struct > cmd_add_port_tm_nonleaf_node_result, > + stats_mask, UINT64); > +cmdline_parse_token_string_t > + cmd_add_port_tm_nonleaf_node_multi_shared_shaper_id =3D > + TOKEN_STRING_INITIALIZER(struct > cmd_add_port_tm_nonleaf_node_result, > + multi_shared_shaper_id, TOKEN_STRING_MULTI); > + > +static void cmd_add_port_tm_nonleaf_node_parsed(void *parsed_result, > + __attribute__((unused)) struct cmdline *cl, > + __attribute__((unused)) void *data) > +{ > + struct cmd_add_port_tm_nonleaf_node_result *res =3D parsed_result; > + struct rte_tm_error error; > + struct rte_tm_node_params np; > + uint32_t *shared_shaper_id; > + uint32_t parent_node_id, n_shared_shapers =3D 0; > + char *s_str =3D res->multi_shared_shaper_id; > + portid_t port_id =3D res->port_id; > + int ret; > + > + if (port_id_is_invalid(port_id, ENABLED_WARN)) > + return; > + > + /* Port status */ > + if (port_is_started(port_id)) { > + printf(" Port %u not stopped (error)\n", port_id); > + return; > + } > + > + memset(&np, 0, sizeof(struct rte_tm_node_params)); > + > + /* Node parameters */ > + if (res->parent_node_id < 0) > + parent_node_id =3D UINT32_MAX; > + else > + parent_node_id =3D res->parent_node_id; > + > + shared_shaper_id =3D (uint32_t *)malloc(MAX_NUM_SHARED_SHAPERS > * > + sizeof(uint32_t)); > + /* Parse multi shared shaper id string */ > + ret =3D parse_multi_ss_id_str(s_str, &n_shared_shapers, > shared_shaper_id); > + if (ret) { > + printf(" Shared shapers params string parse error\n"); > + return; You forgot to free shared_shaper_id.=20 > + } > + > + np.shaper_profile_id =3D res->shaper_profile_id; > + np.n_shared_shapers =3D n_shared_shapers; > + if (np.n_shared_shapers) > + np.shared_shaper_id =3D &shared_shaper_id[0]; > + else > + np.shared_shaper_id =3D NULL; > + > + np.nonleaf.n_sp_priorities =3D res->n_sp_priorities; > + np.stats_mask =3D res->stats_mask; > + np.nonleaf.wfq_weight_mode =3D NULL; > + > + ret =3D rte_tm_node_add(port_id, res->node_id, parent_node_id, > + res->priority, res->weight, res->level_id, > + &np, &error); > + if (ret !=3D 0) { > + print_err_msg(&error); > + return; > + } You forgot to free shared_shaper_id. > +} > + > +cmdline_parse_inst_t cmd_add_port_tm_nonleaf_node =3D { > + .f =3D cmd_add_port_tm_nonleaf_node_parsed, > + .data =3D NULL, > + .help_str =3D "Add port tm nonleaf node", > + .tokens =3D { > + (void *)&cmd_add_port_tm_nonleaf_node_add, > + (void *)&cmd_add_port_tm_nonleaf_node_port, > + (void *)&cmd_add_port_tm_nonleaf_node_tm, > + (void *)&cmd_add_port_tm_nonleaf_node_nonleaf, > + (void *)&cmd_add_port_tm_nonleaf_node_node, > + (void *)&cmd_add_port_tm_nonleaf_node_port_id, > + (void *)&cmd_add_port_tm_nonleaf_node_node_id, > + (void *)&cmd_add_port_tm_nonleaf_node_parent_node_id, > + (void *)&cmd_add_port_tm_nonleaf_node_priority, > + (void *)&cmd_add_port_tm_nonleaf_node_weight, > + (void *)&cmd_add_port_tm_nonleaf_node_level_id, > + (void *)&cmd_add_port_tm_nonleaf_node_shaper_profile_id, > + (void *)&cmd_add_port_tm_nonleaf_node_n_sp_priorities, > + (void *)&cmd_add_port_tm_nonleaf_node_stats_mask, > + (void > *)&cmd_add_port_tm_nonleaf_node_multi_shared_shaper_id, > + NULL, > + }, > +}; > + > +/* *** Add Port TM leaf node *** */ > +struct cmd_add_port_tm_leaf_node_result { > + cmdline_fixed_string_t add; > + cmdline_fixed_string_t port; > + cmdline_fixed_string_t tm; > + cmdline_fixed_string_t leaf; > + cmdline_fixed_string_t node; > + uint16_t port_id; > + uint32_t node_id; > + int32_t parent_node_id; > + uint32_t priority; > + uint32_t weight; > + uint32_t level_id; > + uint32_t shaper_profile_id; > + uint32_t cman_mode; > + uint32_t wred_profile_id; > + uint64_t stats_mask; > + cmdline_multi_string_t multi_shared_shaper_id; }; > + > +cmdline_parse_token_string_t cmd_add_port_tm_leaf_node_add =3D > + TOKEN_STRING_INITIALIZER( > + struct cmd_add_port_tm_leaf_node_result, add, "add"); > +cmdline_parse_token_string_t cmd_add_port_tm_leaf_node_port =3D > + TOKEN_STRING_INITIALIZER( > + struct cmd_add_port_tm_leaf_node_result, port, "port"); > +cmdline_parse_token_string_t cmd_add_port_tm_leaf_node_tm =3D > + TOKEN_STRING_INITIALIZER( > + struct cmd_add_port_tm_leaf_node_result, tm, "tm"); > +cmdline_parse_token_string_t cmd_add_port_tm_leaf_node_nonleaf =3D > + TOKEN_STRING_INITIALIZER( > + struct cmd_add_port_tm_leaf_node_result, leaf, "leaf"); > +cmdline_parse_token_string_t cmd_add_port_tm_leaf_node_node =3D > + TOKEN_STRING_INITIALIZER( > + struct cmd_add_port_tm_leaf_node_result, node, "node"); > +cmdline_parse_token_num_t cmd_add_port_tm_leaf_node_port_id =3D > + TOKEN_NUM_INITIALIZER(struct cmd_add_port_tm_leaf_node_result, > + port_id, UINT16); > +cmdline_parse_token_num_t cmd_add_port_tm_leaf_node_node_id =3D > + TOKEN_NUM_INITIALIZER(struct cmd_add_port_tm_leaf_node_result, > + node_id, UINT32); > +cmdline_parse_token_num_t cmd_add_port_tm_leaf_node_parent_node_id =3D > + TOKEN_NUM_INITIALIZER(struct cmd_add_port_tm_leaf_node_result, > + parent_node_id, INT32); > +cmdline_parse_token_num_t cmd_add_port_tm_leaf_node_priority =3D > + TOKEN_NUM_INITIALIZER(struct cmd_add_port_tm_leaf_node_result, > + priority, UINT32); > +cmdline_parse_token_num_t cmd_add_port_tm_leaf_node_weight =3D > + TOKEN_NUM_INITIALIZER(struct cmd_add_port_tm_leaf_node_result, > + weight, UINT32); > +cmdline_parse_token_num_t cmd_add_port_tm_leaf_node_level_id =3D > + TOKEN_NUM_INITIALIZER(struct cmd_add_port_tm_leaf_node_result, > + level_id, UINT32); > +cmdline_parse_token_num_t cmd_add_port_tm_leaf_node_shaper_profile_id > =3D > + TOKEN_NUM_INITIALIZER(struct cmd_add_port_tm_leaf_node_result, > + shaper_profile_id, UINT32); > +cmdline_parse_token_num_t cmd_add_port_tm_leaf_node_cman_mode =3D > + TOKEN_NUM_INITIALIZER(struct cmd_add_port_tm_leaf_node_result, > + cman_mode, UINT32); > +cmdline_parse_token_num_t cmd_add_port_tm_leaf_node_wred_profile_id > =3D > + TOKEN_NUM_INITIALIZER(struct cmd_add_port_tm_leaf_node_result, > + wred_profile_id, UINT32); > +cmdline_parse_token_num_t cmd_add_port_tm_leaf_node_stats_mask =3D > + TOKEN_NUM_INITIALIZER(struct cmd_add_port_tm_leaf_node_result, > + stats_mask, UINT64); > +cmdline_parse_token_string_t > + cmd_add_port_tm_leaf_node_multi_shared_shaper_id =3D > + TOKEN_STRING_INITIALIZER(struct > cmd_add_port_tm_leaf_node_result, > + multi_shared_shaper_id, TOKEN_STRING_MULTI); > + > +static void cmd_add_port_tm_leaf_node_parsed(void *parsed_result, > + __attribute__((unused)) struct cmdline *cl, > + __attribute__((unused)) void *data) > +{ > + struct cmd_add_port_tm_leaf_node_result *res =3D parsed_result; > + struct rte_tm_error error; > + struct rte_tm_node_params np; > + uint32_t *shared_shaper_id; > + uint32_t parent_node_id, n_shared_shapers =3D 0; > + portid_t port_id =3D res->port_id; > + char *s_str =3D res->multi_shared_shaper_id; > + int ret; > + > + if (port_id_is_invalid(port_id, ENABLED_WARN)) > + return; > + > + /* Port status */ > + if (port_is_started(port_id)) { > + printf(" Port %u not stopped (error)\n", port_id); > + return; > + } > + > + memset(&np, 0, sizeof(struct rte_tm_node_params)); > + > + /* Node parameters */ > + if (res->parent_node_id < 0) > + parent_node_id =3D UINT32_MAX; > + else > + parent_node_id =3D res->parent_node_id; > + > + shared_shaper_id =3D (uint32_t *)malloc(MAX_NUM_SHARED_SHAPERS > * > + sizeof(uint32_t)); > + /* Parse multi shared shaper id string */ > + ret =3D parse_multi_ss_id_str(s_str, &n_shared_shapers, > shared_shaper_id); > + if (ret) { > + printf(" Shared shapers params string parse error\n"); The same, free the memory you malloced.