From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id BC4121B60E for ; Mon, 16 Oct 2017 12:29:41 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP; 16 Oct 2017 03:29:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,386,1503385200"; d="scan'208";a="323724727" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 16 Oct 2017 03:29:40 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 16 Oct 2017 03:29:40 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 16 Oct 2017 03:29:39 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Mon, 16 Oct 2017 18:29:37 +0800 From: "Wu, Jingjing" To: Thomas Monjalon CC: "dev@dpdk.org" , "Tan, Jianfeng" , "shreyansh.jain@nxp.com" , "hemant.agrawal@nxp.com" , "santosh.shukla@caviumnetworks.com" , Tomasz Duszynski , Jacek Siuda , "jerin.jacob@caviumnetworks.com" Thread-Topic: [dpdk-dev] [PATCH v3] eal: add counter size for efd clean Thread-Index: AQHTHH7WhO8z0Yvv2kmJkXYWrn5jT6LeZa2AgAgy8rA= Date: Mon, 16 Oct 2017 10:29:37 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810E96F36@SHSMSX103.ccr.corp.intel.com> References: <1502636600-46889-1-git-send-email-jingjing.wu@intel.com> <1503540656-104421-1-git-send-email-jingjing.wu@intel.com> <4513487.fCd9laRvq9@xps> In-Reply-To: <4513487.fCd9laRvq9@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] eal: add counter size for efd clean X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 10:29:42 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Wednesday, October 11, 2017 9:11 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Tan, Jianfeng ; > shreyansh.jain@nxp.com; hemant.agrawal@nxp.com; > santosh.shukla@caviumnetworks.com; Tomasz Duszynski ; > Jacek Siuda ; jerin.jacob@caviumnetworks.com > Subject: Re: [dpdk-dev] [PATCH v3] eal: add counter size for efd clean >=20 > Hi, >=20 > 24/08/2017 04:10, Jingjing Wu: > > } else if (intr_handle->type =3D=3D RTE_INTR_HANDLE_VDEV) { > > - /* do nothing, and let vdev driver to initialize this s= truct */ > > + /* only check, initialization would be done in vdev dri= ver.*/ > > + if (intr_handle->efd_counter_size > > > + sizeof(union rte_intr_read_buffer)) { > > + RTE_LOG(ERR, EAL, "the efd_counter_size is over= sized"); > > + return -EINVAL; > > + } >=20 > How interrupts are working with other buses? >=20 > Is it something we should manage in bus drivers code? Any plan to move interrupts from EAL to bus?