From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id CE2061B800 for ; Tue, 24 Oct 2017 15:38:48 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2017 06:38:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,427,1503385200"; d="scan'208";a="1028741785" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 24 Oct 2017 06:38:46 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 24 Oct 2017 06:38:46 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 24 Oct 2017 06:38:46 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.159]) with mapi id 14.03.0319.002; Tue, 24 Oct 2017 21:38:44 +0800 From: "Wu, Jingjing" To: Thomas Monjalon CC: "dev@dpdk.org" , "Tan, Jianfeng" , "shreyansh.jain@nxp.com" , "hemant.agrawal@nxp.com" , "santosh.shukla@caviumnetworks.com" , Tomasz Duszynski , Jacek Siuda , "jerin.jacob@caviumnetworks.com" Thread-Topic: [dpdk-dev] [PATCH v3] eal: add counter size for efd clean Thread-Index: AQHTHH7WhO8z0Yvv2kmJkXYWrn5jT6LeZa2AgAgy8rD//4ATAIANSN4g Date: Tue, 24 Oct 2017 13:38:43 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810EA053D@SHSMSX103.ccr.corp.intel.com> References: <1502636600-46889-1-git-send-email-jingjing.wu@intel.com> <4513487.fCd9laRvq9@xps> <9BB6961774997848B5B42BEC655768F810E96F36@SHSMSX103.ccr.corp.intel.com> <1985896.boakGMOk3P@xps> In-Reply-To: <1985896.boakGMOk3P@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjQ3N2I4ZWUtNWRlMC00NWExLWIzOTItNDcyOTlmNGQzYTVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImJiNGxBK1FwK2VjamgwSHBROCtJR0Njdkx2Q3lyUVkyQUxUVTcxbHZheVk9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] eal: add counter size for efd clean X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 13:38:49 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, October 16, 2017 6:46 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Tan, Jianfeng ; shreyansh.jain@= nxp.com; > hemant.agrawal@nxp.com; santosh.shukla@caviumnetworks.com; Tomasz Duszyns= ki > ; Jacek Siuda ; > jerin.jacob@caviumnetworks.com > Subject: Re: [dpdk-dev] [PATCH v3] eal: add counter size for efd clean >=20 > 16/10/2017 12:29, Wu, Jingjing: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > Hi, > > > > > > 24/08/2017 04:10, Jingjing Wu: > > > > } else if (intr_handle->type =3D=3D RTE_INTR_HANDLE_VDEV) { > > > > - /* do nothing, and let vdev driver to initialize th= is struct */ > > > > + /* only check, initialization would be done in vdev= driver.*/ > > > > + if (intr_handle->efd_counter_size > > > > > + sizeof(union rte_intr_read_buffer)) { > > > > + RTE_LOG(ERR, EAL, "the efd_counter_size is > oversized"); > > > > + return -EINVAL; > > > > + } > > > > > > How interrupts are working with other buses? > > > > > > Is it something we should manage in bus drivers code? > > > > Any plan to move interrupts from EAL to bus? >=20 > It is an open question :) OK. How about the patch on current interrupt? I think it is OK, right :)