From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 74F7758CE for ; Tue, 31 Oct 2017 14:26:32 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Oct 2017 06:26:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,324,1505804400"; d="scan'208";a="1237710581" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 31 Oct 2017 06:26:05 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 31 Oct 2017 06:25:59 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 31 Oct 2017 06:25:58 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.175]) with mapi id 14.03.0319.002; Tue, 31 Oct 2017 21:25:56 +0800 From: "Wu, Jingjing" To: 'Thomas Monjalon' CC: "'dev@dpdk.org'" , "Tan, Jianfeng" , "'shreyansh.jain@nxp.com'" , "'hemant.agrawal@nxp.com'" , "'santosh.shukla@caviumnetworks.com'" , 'Tomasz Duszynski' , 'Jacek Siuda' , "'jerin.jacob@caviumnetworks.com'" Thread-Topic: [dpdk-dev] [PATCH v3] eal: add counter size for efd clean Thread-Index: AQHTHH7WhO8z0Yvv2kmJkXYWrn5jT6LeZa2AgAgy8rD//4ATAIANSN4ggAr88aA= Date: Tue, 31 Oct 2017 13:25:56 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810EA9574@SHSMSX103.ccr.corp.intel.com> References: <1502636600-46889-1-git-send-email-jingjing.wu@intel.com> <4513487.fCd9laRvq9@xps> <9BB6961774997848B5B42BEC655768F810E96F36@SHSMSX103.ccr.corp.intel.com> <1985896.boakGMOk3P@xps> <9BB6961774997848B5B42BEC655768F810EA053D@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810EA053D@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjQ3N2I4ZWUtNWRlMC00NWExLWIzOTItNDcyOTlmNGQzYTVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImJiNGxBK1FwK2VjamgwSHBROCtJR0Njdkx2Q3lyUVkyQUxUVTcxbHZheVk9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] eal: add counter size for efd clean X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Oct 2017 13:26:33 -0000 Ping > -----Original Message----- > From: Wu, Jingjing > Sent: Tuesday, October 24, 2017 9:39 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; Tan, Jianfeng ; shreyansh.jain@= nxp.com; > hemant.agrawal@nxp.com; santosh.shukla@caviumnetworks.com; Tomasz Duszyns= ki > ; Jacek Siuda ; > jerin.jacob@caviumnetworks.com > Subject: RE: [dpdk-dev] [PATCH v3] eal: add counter size for efd clean >=20 >=20 >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > Sent: Monday, October 16, 2017 6:46 PM > > To: Wu, Jingjing > > Cc: dev@dpdk.org; Tan, Jianfeng ; shreyansh.jai= n@nxp.com; > > hemant.agrawal@nxp.com; santosh.shukla@caviumnetworks.com; Tomasz Duszy= nski > > ; Jacek Siuda ; > > jerin.jacob@caviumnetworks.com > > Subject: Re: [dpdk-dev] [PATCH v3] eal: add counter size for efd clean > > > > 16/10/2017 12:29, Wu, Jingjing: > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > Hi, > > > > > > > > 24/08/2017 04:10, Jingjing Wu: > > > > > } else if (intr_handle->type =3D=3D RTE_INTR_HANDLE_VDEV)= { > > > > > - /* do nothing, and let vdev driver to initialize = this struct */ > > > > > + /* only check, initialization would be done in vd= ev driver.*/ > > > > > + if (intr_handle->efd_counter_size > > > > > > + sizeof(union rte_intr_read_buffer)) { > > > > > + RTE_LOG(ERR, EAL, "the efd_counter_size i= s > > oversized"); > > > > > + return -EINVAL; > > > > > + } > > > > > > > > How interrupts are working with other buses? > > > > > > > > Is it something we should manage in bus drivers code? > > > > > > Any plan to move interrupts from EAL to bus? > > > > It is an open question :) >=20 > OK. How about the patch on current interrupt? I think it is OK, right :)