From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix FDIR issue
Date: Thu, 8 Feb 2018 12:39:18 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810F711E9@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1518093340-22768-1-git-send-email-beilei.xing@intel.com>
> -----Original Message-----
> From: Xing, Beilei
> Sent: Thursday, February 8, 2018 8:36 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [PATCH] app/testpmd: fix FDIR issue
>
> This patch fixes issue during dealing with flow
> director filter.
>
> Fixes: 6c684f579df5 ("app/testpmd: add or delete flow director filter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> ---
> app/test-pmd/cmdline.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index b4522f4..d1dc1de 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -9900,11 +9900,11 @@ struct cmd_flow_director_result {
> uint16_t port_dst;
> cmdline_fixed_string_t verify_tag;
> uint32_t verify_tag_value;
> - cmdline_ipaddr_t tos;
> + cmdline_fixed_string_t tos;
> uint8_t tos_value;
> - cmdline_ipaddr_t proto;
> + cmdline_fixed_string_t proto;
> uint8_t proto_value;
> - cmdline_ipaddr_t ttl;
> + cmdline_fixed_string_t ttl;
> uint8_t ttl_value;
> cmdline_fixed_string_t vlan;
> uint16_t vlan_value;
> @@ -10515,7 +10515,7 @@ cmdline_parse_inst_t cmd_add_del_sctp_flow_director = {
> (void *)&cmd_flow_director_flow_type,
> (void *)&cmd_flow_director_src,
> (void *)&cmd_flow_director_ip_src,
> - (void *)&cmd_flow_director_port_dst,
> + (void *)&cmd_flow_director_port_src,
> (void *)&cmd_flow_director_dst,
> (void *)&cmd_flow_director_ip_dst,
> (void *)&cmd_flow_director_port_dst,
Good catch, thanks!
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
next prev parent reply other threads:[~2018-02-08 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 12:35 Beilei Xing
2018-02-08 12:39 ` Wu, Jingjing [this message]
2018-02-08 21:28 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810F711E9@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).