From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 7180A1B6CE for ; Thu, 8 Feb 2018 14:39:02 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Feb 2018 05:39:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,478,1511856000"; d="scan'208";a="25745839" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 08 Feb 2018 05:39:00 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 8 Feb 2018 05:39:00 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 8 Feb 2018 05:39:00 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.116]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.125]) with mapi id 14.03.0319.002; Thu, 8 Feb 2018 21:38:58 +0800 From: "Wu, Jingjing" To: "Xing, Beilei" , "dev@dpdk.org" , "Zhang, Qi Z" Thread-Topic: [PATCH] net/i40e: fix unchecked return in parse devarg Thread-Index: AQHToN804u3bBJC340q+5054HP7zAaOago+w Date: Thu, 8 Feb 2018 13:38:58 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F810F71318@SHSMSX103.ccr.corp.intel.com> References: <1518095892-61961-1-git-send-email-beilei.xing@intel.com> In-Reply-To: <1518095892-61961-1-git-send-email-beilei.xing@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDQ1MzllYWQtZGRmNi00NDdlLTljOTAtM2ZmNDUwZDdkYjljIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6ImdxUmQ2elNtdUx3ZHZpUW9UZUhoTU9iN0NcL2dVVW9uTlVnRGxYWFNTMzc0PSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix unchecked return in parse devarg X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 13:39:03 -0000 > -----Original Message----- > From: Xing, Beilei > Sent: Thursday, February 8, 2018 9:18 PM > To: Wu, Jingjing ; dev@dpdk.org; Zhang, Qi Z > > Subject: [PATCH] net/i40e: fix unchecked return in parse devarg >=20 > This patch fixes the coverity CHECKED_RETURN issue. >=20 > Coverity issue: 261779 > Fixes: cfdfca493cae ("net/i40e: fix multiple driver support") >=20 > Reported-by: John McNamara > Signed-off-by: Beilei Xing > --- > drivers/net/i40e/i40e_ethdev.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 65a4b7a..508b417 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -1107,8 +1107,12 @@ i40e_support_multi_driver(struct rte_eth_dev *dev) > "the first invalid or last valid one is used !", > ETH_I40E_SUPPORT_MULTI_DRIVER); >=20 > - rte_kvargs_process(kvlist, ETH_I40E_SUPPORT_MULTI_DRIVER, > - i40e_parse_multi_drv_handler, pf); > + if (rte_kvargs_process(kvlist, ETH_I40E_SUPPORT_MULTI_DRIVER, > + i40e_parse_multi_drv_handler, pf) < 0) { > + rte_kvargs_free(kvlist); > + return -EINVAL; > + } > + > rte_kvargs_free(kvlist); > return 0; > } > -- > 2.5.5 Acked-by: Jingjing Wu