From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 308F62C17 for ; Wed, 6 Mar 2019 03:14:08 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Mar 2019 18:14:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,446,1544515200"; d="scan'208";a="149627292" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 05 Mar 2019 18:14:07 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 5 Mar 2019 18:14:07 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 5 Mar 2019 18:14:06 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.134]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.144]) with mapi id 14.03.0415.000; Wed, 6 Mar 2019 10:14:04 +0800 From: "Wu, Jingjing" To: "Babu Radhakrishnan, AgalyaX" , "dev@dpdk.org" CC: "reshma.pattan@intel.com??" , "Lu, Wenzhuo" Thread-Topic: [PATCH] app/testpmd: fix help info for interactive commands Thread-Index: AQHU00a7stZsPWfyIk20nMy4VzVvZKX92+Cw Date: Wed, 6 Mar 2019 02:14:03 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F811384D87@SHSMSX103.ccr.corp.intel.com> References: <1551785289-4543-1-git-send-email-agalyax.babu.radhakrishnan@intel.com> In-Reply-To: <1551785289-4543-1-git-send-email-agalyax.babu.radhakrishnan@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTBmZGMxOGQtMDc2YS00YWNhLWEyOTYtNGFhY2Y0MzFlYjg4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibXBrd0JUSjZNOXRjSTJKVFwvQTI4dDNzUUI3R1hSVWFKUVd4T3B0QlVEZWQwTGY3TisybmdTcEZkVGd2eW43QmoifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix help info for interactive commands X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2019 02:14:09 -0000 Glad to see the help info is added. Could you categorize this related TM commands to a new group? As you know, = the commands in "help config" almost over flow. Thanks Jingjing > -----Original Message----- > From: Babu Radhakrishnan, AgalyaX > Sent: Tuesday, March 5, 2019 7:28 PM > To: dev@dpdk.org > Cc: reshma.pattan@intel.com??; Lu, Wenzhuo ; Wu, Ji= ngjing > ; Babu Radhakrishnan, AgalyaX > > Subject: [PATCH] app/testpmd: fix help info for interactive commands >=20 > From: Agalya Babu RadhaKrishnan >=20 > Added some missing help info for interactive mode commands >=20 > Fixes: 6673fe0ce2 ("app/testpmd: add TM commands to mark packets") > Fixes: c73a907187 ("app/testpmd: add commands to test new offload API") > Fixes: e977e4199a ("app/testpmd: add commands to load/unload BPF filters"= ) > Fixes: c18feafa19 ("app/testpmd: support metadata as flow rule item") > Signed-off-by: Agalya Babu RadhaKrishnan > --- > app/test-pmd/cmdline.c | 82 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 82 insertions(+) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index db53cc0cc..149711ddc 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -225,6 +225,26 @@ static void cmd_help_long_parsed(void *parsed_result= , > "show port tm node stats (port_id) (node_id) (cl= ear)\n" > " Display the port TM node stats.\n\n" >=20 > + "show port (port_id) rx_offload capabilities\n" > + " List all per queue and per port Rx offloading" > + " capabilities of a port\n\n" > + > + "show port (port_id) rx_offload configuration\n" > + " List port level and all queue level" > + " Rx offloading configuration\n\n" > + > + "show port (port_id) tx_offload capabilities\n" > + " List all per queue and per port" > + " Tx offloading capabilities of a port\n\n" > + > + "show port (port_id) tx_offload configuration\n" > + " List port level and all queue level" > + " Tx offloading configuration\n\n" > + > + "show port (port_id) tx_metadata\n" > + " Show Tx metadata value set" > + " for a specific port\n\n" > + > ); > } >=20 > @@ -783,6 +803,22 @@ static void cmd_help_long_parsed(void *parsed_result= , > "port tm hierarchy commit (port_id) (clean_on_fail)\n" > " Commit tm hierarchy.\n\n" >=20 > + "set port tm mark ip_ecn (port) (green) (yellow)" > + " (red)\n" > + " Enables/Disables the traffic management marking" > + " for IP ECN (Explicit Congestion Notification)" > + " packets on a given port\n\n" > + > + "set port tm mark ip_dscp (port) (green) (yellow)" > + " (red)\n" > + " Enables/Disables the traffic management marking" > + " on the port for IP dscp packets\n\n" > + > + "set port tm mark vlan_dei (port) (green) (yellow)" > + " (red)\n" > + " Enables/Disables the traffic management marking" > + " on the port for VLAN packets with DEI enabled\n\n" > + > "vxlan ip-version (ipv4|ipv6) vni (vni) udp-src" > " (udp-src) udp-dst (udp-dst) ip-src (ip-src) ip-dst" > " (ip-dst) eth-src (eth-src) eth-dst (eth-dst)\n" > @@ -924,6 +960,52 @@ static void cmd_help_long_parsed(void *parsed_result= , >=20 > "port config (port_id) udp_tunnel_port add|rm vxlan|geneve > (udp_port)\n\n" > " Add/remove UDP tunnel port for tunneling offload\n\n" > + > + "port config rx_offload vlan_strip|" > + "ipv4_cksum|udp_cksum|tcp_cksum|tcp_lro|qinq_strip|" > + "outer_ipv4_cksum|macsec_strip|header_split|" > + "vlan_filter|vlan_extend|jumbo_frame|crc_strip|" > + "scatter|timestamp|security|keep_crc on|off\n" > + " Enable or disable a per port Rx offloading" > + " on all Rx queues of a port\n\n" > + > + "port (port_id) rxq (queue_id) rx_offload vlan_strip|" > + "ipv4_cksum|udp_cksum|tcp_cksum|tcp_lro|qinq_strip|" > + "outer_ipv4_cksum|macsec_strip|header_split|" > + "vlan_filter|vlan_extend|jumbo_frame|crc_strip|" > + "scatter|timestamp|security|keep_crc on|off\n" > + " Enable or disable a per queue Rx offloading" > + " only on a specific Rx queue\n\n" > + > + "port config (port_id) tx_offload vlan_insert|" > + "ipv4_cksum|udp_cksum|tcp_cksum|sctp_cksum|tcp_tso|" > + "udp_tso|outer_ipv4_cksum|qinq_insert|vxlan_tnl_tso|" > + "gre_tnl_tso|ipip_tnl_tso|geneve_tnl_tso|" > + "macsec_insert|mt_lockfree|multi_segs|mbuf_fast_free|" > + "security|match_metadata on|off\n" > + " Enable or disable a per port Tx offloading" > + " on all Tx queues of a port\n\n" > + > + "port (port_id) txq (queue_id) tx_offload vlan_insert|" > + "ipv4_cksum|udp_cksum|tcp_cksum|sctp_cksum|tcp_tso|" > + "udp_tso|outer_ipv4_cksum|qinq_insert|vxlan_tnl_tso|" > + "gre_tnl_tso|ipip_tnl_tso|geneve_tnl_tso|macsec_insert" > + "|mt_lockfree|multi_segs|mbuf_fast_free|security" > + " on|off\n" > + " Enable or disable a per queue Tx offloading" > + " only on a specific Tx queue\n\n" > + > + "bpf-load rx|tx (port) (queue) (J|M|B) (file_name)\n" > + " Load an eBPF program as a callback" > + " for partciular RX/TX queue\n\n" > + > + "bpf-unload rx|tx (port) (queue)\n" > + " Unload previously loaded eBPF program" > + " for partciular RX/TX queue\n\n" > + > + "port config (port_id) tx_metadata (value)\n" > + " Set Tx metadata value per port.testpmd will add this value" > + " to any Tx packet sent from this port\n\n" > ); > } >=20 > -- > 2.17.2