From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <jingjing.wu@intel.com> Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by dpdk.org (Postfix) with ESMTP id B097E5930 for <dev@dpdk.org>; Tue, 20 May 2014 02:55:43 +0200 (CEST) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 19 May 2014 17:55:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.98,870,1392192000"; d="scan'208";a="434218205" Received: from fmsmsx103.amr.corp.intel.com ([10.19.9.34]) by azsmga001.ch.intel.com with ESMTP; 19 May 2014 17:55:32 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX103.amr.corp.intel.com (10.19.9.34) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 19 May 2014 17:55:13 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.192]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.34]) with mapi id 14.03.0123.003; Tue, 20 May 2014 08:55:11 +0800 From: "Wu, Jingjing" <jingjing.wu@intel.com> To: Thomas Monjalon <thomas.monjalon@6wind.com> Thread-Topic: [dpdk-dev] [PATCH][PMD][GENERIC_FILTER] add NIC filters support for generic filter feature Thread-Index: AQHPcbNiDagwS2fP+UC/2EjXur3OD5tHLXwAgAF7RwA= Date: Tue, 20 May 2014 00:55:11 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8A761EA@SHSMSX104.ccr.corp.intel.com> References: <1400319309-25231-1-git-send-email-jingjing.wu@intel.com> <2436549.UhLCUXjEFZ@xps13> In-Reply-To: <2436549.UhLCUXjEFZ@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH][PMD][GENERIC_FILTER] add NIC filters support for generic filter feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 20 May 2014 00:55:44 -0000 Fine, I will split it. -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Monday, May 19, 2014 6:17 PM To: Wu, Jingjing Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH][PMD][GENERIC_FILTER] add NIC filters suppor= t for generic filter feature Hi Jingjing, 2014-05-17 17:35, Jingjing Wu: > A generic filter mechanism for handling special packet is required. It=20 > will allows filters to be set in HW when available for so that=20 > specific packets may be filtered by NICs to specific desriptor queues for= processing. > Currently only the Flow Director for Intel's 10GbE 82599 devices is=20 > available. Other types of filter are not supported. >=20 > This pacth adds following NIC filters used to assign different packets=20 > to certain receive queues. ethertype filter/syn filter/2tuple=20 > filter/flex filter for E1000(82580, i350) ethertype filter/syn=20 > filter/5tuple filter for > 10G(82599) >=20 > Signed-off-by: jingjing.wu <jingjing.wu@intel.com> > --- > app/test-pmd/cmdline.c | 905 > +++++++++++++++++++++++++++++++++++- app/test-pmd/config.c = | > 143 ++++++ > app/test-pmd/testpmd.h | 6 + > lib/librte_ether/rte_ethdev.c | 300 ++++++++++++ > lib/librte_ether/rte_ethdev.h | 429 ++++++++++++++++- > lib/librte_pmd_e1000/e1000_ethdev.h | 38 ++ > lib/librte_pmd_e1000/igb_ethdev.c | 512 ++++++++++++++++++++ > lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 365 +++++++++++++++ =20 > lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 33 ++ > 9 files changed, 2729 insertions(+), 2 deletions(-) It would be really easier to review if you split it in 4 parts: - ethdev API - igb implementation - ixgbe implementation - testpmd Thanks -- Thomas