From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E6B33B112 for ; Thu, 12 Jun 2014 10:08:55 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 12 Jun 2014 01:09:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,463,1400050800"; d="scan'208";a="556201898" Received: from fmsmsx107.amr.corp.intel.com ([10.19.9.54]) by orsmga002.jf.intel.com with ESMTP; 12 Jun 2014 01:08:25 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX107.amr.corp.intel.com (10.19.9.54) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 12 Jun 2014 01:08:24 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.123.3; Thu, 12 Jun 2014 01:08:24 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.122]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.210]) with mapi id 14.03.0123.003; Thu, 12 Jun 2014 16:08:19 +0800 From: "Wu, Jingjing" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 0/4] NIC filters support for generic filter Thread-Index: AQHPdvDNbUccjvmsc0uwK9LYw6o4fJtUkOCAgACfFNCAAAN0EIAWcNmAgAGUvHA= Date: Thu, 12 Jun 2014 08:08:18 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8A8BBB5@SHSMSX104.ccr.corp.intel.com> References: <1400895442-32433-1-git-send-email-jingjing.wu@intel.com> <9BB6961774997848B5B42BEC655768F8A789C6@SHSMSX104.ccr.corp.intel.com> <9BB6961774997848B5B42BEC655768F8A78A07@SHSMSX104.ccr.corp.intel.com> <2116871.SYCYqgDKRI@xps13> In-Reply-To: <2116871.SYCYqgDKRI@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 0/4] NIC filters support for generic filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jun 2014 08:08:56 -0000 Hi, Thomas Thanks for your reply. About your first concern: The pool field is used in virtualization scenario. It is acting as one of i= nput set during filter matching in ixgbe.=20 My patch didn't consider the virtualization scenario in generic filter feat= ure. Because in 82599 datasheet, it is recommended to assign rx queues not = used by DCB/RSS, that is virtualization without RSS and DCB mode. For this = mode, current DPDK version makes the number of queue to 1 by default in IOV= mode. So in this case it makes no sense make pool as a input set and the r= x queue also need to be set to in this pool, so just keep the consistent wi= th flow director who also ignore it in previous version.=20 And further E1000/Niantic/Fortville have different definitions for VF, we n= eed to think how to define it more generic. And even just need offer pool number in configuration of the filters as wha= t Vladimir did, it also need to verify the interworking with Virtualization= for different kinds of NICs, and the interworking with DCB and RSS which i= s not recommended in 82599's datasheet. So I think it will be a good choice to implement generic filter interworkin= g with virtualization in future patch. If there is any volunteer to send pa= tch for support this concern later, it will be also cool. About your second concern: I will send out a new version for that soon. -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Wednesday, June 11, 2014 11:45 PM To: Wu, Jingjing Cc: dev@dpdk.org; Vladimir Medvedkin Subject: Re: [dpdk-dev] [PATCH v2 0/4] NIC filters support for generic filt= er Hi Jingjing, Please reply below the question. 2014-05-28 01:12, Wu, Jingjing: > You are discussing whether the APIs provide for NIC filters is generic=20 > or not. About that we can use same API for a type of filter. For=20 > example, if we want to configure ethertype filter, we can use the same=20 > API, no matter the NIC is 82580, i350, 82576 or 82599. We think these=20 > NICs may be most common used. I was wondering if this API can apply to non-Intel devices. But nobody talk= ed about it. So let's forget it. My main concern is that Vladimir Medvedkin suggested another API and I'd li= ke you give your opinion about it: http://dpdk.org/ml/archives/dev/2014-June/003053.html It offers pool number in configuration of the filters. Last comment: patches would be more pleasant to read with right alignment a= nd spaces in comments. This is an extract to illustrate what I'm talking ab= out: + uint16_t priority; /**< used when more than one filter matches */ + uint8_t dst_port_mask : 1, /**