From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 923173975 for ; Thu, 28 Aug 2014 05:47:26 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 27 Aug 2014 20:51:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="377963622" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by FMSMGA003.fm.intel.com with ESMTP; 27 Aug 2014 20:47:18 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 27 Aug 2014 20:51:32 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 27 Aug 2014 20:51:32 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.17]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.174]) with mapi id 14.03.0195.001; Thu, 28 Aug 2014 11:51:30 +0800 From: "Wu, Jingjing" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config functions for i40e flow director support Thread-Index: AQHPwZyuUuNR6DPrqUGFqFfP1yAUpJvj/v+AgAFhSpA= Date: Thu, 28 Aug 2014 03:51:29 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8ADBF4E@SHSMSX104.ccr.corp.intel.com> References: <1409105634-29980-1-git-send-email-jingjing.wu@intel.com> <1409105634-29980-8-git-send-email-jingjing.wu@intel.com> <8438692.KHYKcsiDRz@xps13> In-Reply-To: <8438692.KHYKcsiDRz@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and config functions for i40e flow director support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Aug 2014 03:47:27 -0000 Hi, Thomas > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, August 27, 2014 10:36 PM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 7/7]app/testpmd: add commands and confi= g functions for > i40e flow director support >=20 > Hi Jingjing, >=20 > 2014-08-27 10:13, Jingjing Wu: > > add structure definition to construct programming packet. >=20 > What is a "programming packet"? For Fortville, we need to set a flow director filter by sending a packet wh= ich contains the input set values through the queue belonging to flow direc= tor. >=20 > > +#ifdef RTE_LIBRTE_I40E_PMD > > + "i40e_flow_director_filter (port_id) (add|del)" > > + " flow (ip4|ip6) src (src_ip_address) dst (dst_ip_address)" > > + " flexwords (flexwords_value) (drop|fwd)" > > + " queue (queue_id) fd_id (fd_id_value)\n" > > + " Add/Del a IP type flow director filter for i40e NIC.\n\n" > > + > > + "i40e_flow_director_filter (port_id) (add|del)" > > + " flow (udp4|tcp4|udp6|tcp6)" > > + " src (src_ip_address) (src_port)" > > + " dst (dst_ip_address) (dst_port)" > > + " flexwords (flexwords_value) (drop|fwd)" > > + " queue (queue_id) fd_id (fd_id_value)\n" > > + " Add/Del a UDP/TCP type flow director filter for i40e NIC.\n\n" > > + > > + "i40e_flush_flow_diretor (port_id)\n" > > + " Flush all flow director entries of a device on i40e NIC.\n\n" > > +#endif /* RTE_LIBRTE_I40E_PMD */ >=20 > I'd really like to stop seeing this kind of thing. > We cannot add some ifdef for each PMD in generic code. >=20 > I stopped reading after that. >=20 > Sorry, I don't want to be rude but my feeling is that adding such feature > with global picture in mind is not easy. I know you want to offer all i40= e > capabilities but you should think at future evolutions and how other driv= ers > will be integrated with yours. >=20 Sorry to make you feel uncomfortable for such code. Just as you say, I want= to offer more i40e capabilities. I will rework code in testpmd.=20 > Thanks > -- > Thomas