From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id F0E7B212 for ; Thu, 9 Oct 2014 07:10:25 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 08 Oct 2014 22:15:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,682,1406617200"; d="scan'208";a="585814214" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 08 Oct 2014 22:17:43 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 8 Oct 2014 22:17:33 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.230]) by shsmsx102.ccr.corp.intel.com ([169.254.2.192]) with mapi id 14.03.0195.001; Thu, 9 Oct 2014 13:17:32 +0800 From: "Wu, Jingjing" To: 'Thomas Monjalon' Thread-Topic: [dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro conflict Thread-Index: AQHP3FkgZuWg1TJnZE62rzm9sYZLW5wYmhOAgA6Q/4A= Date: Thu, 9 Oct 2014 05:17:31 +0000 Message-ID: <9BB6961774997848B5B42BEC655768F8B04AFE@SHSMSX104.ccr.corp.intel.com> References: <1412045348-18543-1-git-send-email-jingjing.wu@intel.com> <1916931.VRG6JyPOdY@xps13> In-Reply-To: <1916931.VRG6JyPOdY@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro conflict X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Oct 2014 05:10:26 -0000 Hi, Thomas The reason why I didn't remover all the macros in rte_ip.h is: netinet/in.h contains a lot of extra references to the sockets definitions,= some external functions declarations, etc. These are useless some DPDK app= lications, such as classification. rte_ip.h provides a more simplify way for the IP protocol layer.=20 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, September 30, 2014 1:08 PM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro= conflict >=20 > Hi Jingjing, >=20 > 2014-09-30 10:49, Jingjing Wu: > > Macros such as IPPROTO_TCP, IPPROTO_UDP are already defined in . > > If user's application includes and rte_ip.h at the same = time, > > there will be conflict error. > > > > This patch uses the way "#ifndef #endif" to avoid the conflict. >=20 > I still think it is not the good approach. > see http://dpdk.org/ml/archives/dev/2014-August/005006.html > and http://dpdk.org/ml/archives/dev/2014-August/005026.html > Why not simply remove these definitions? >=20 > -- > Thomas